timesheet lockdown with grace period (#1644)

2020-07-02 18:54:17 +02:00
parent e22830790b
commit 091740f407
32 changed files with 1180 additions and 148 deletions
--- a/tests/Validator/Constraints/TimesheetFutureTimesValidatorTest.php
+++ b/tests/Validator/Constraints/TimesheetFutureTimesValidatorTest.php
@@ -0,0 +1,88 @@
+<?php
+
+/*
+ * This file is part of the Kimai time-tracking app.
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
+namespace App\Tests\Validator\Constraints;
+
+use App\Configuration\ConfigLoaderInterface;
+use App\Configuration\TimesheetConfiguration;
+use App\Entity\Timesheet;
+use App\Validator\Constraints\TimesheetFutureTimes;
+use App\Validator\Constraints\TimesheetFutureTimesValidator;
+use Symfony\Component\Validator\Constraints\NotBlank;
+use Symfony\Component\Validator\Exception\UnexpectedTypeException;
+use Symfony\Component\Validator\Test\ConstraintValidatorTestCase;
+
+/**
+ * @covers \App\Validator\Constraints\TimesheetFutureTimesValidator
+ */
+class TimesheetFutureTimesValidatorTest extends ConstraintValidatorTestCase
+{
+    protected function createValidator()
+    {
+        return $this->createMyValidator(false);
+    }
+
+    protected function createMyValidator(bool $allowFutureTimes = false)
+    {
+        $loader = $this->createMock(ConfigLoaderInterface::class);
+        $config = new TimesheetConfiguration($loader, [
+            'rules' => [
+                'allow_future_times' => $allowFutureTimes,
+            ],
+            'rounding' => [
+                'default' => [
+                    'begin' => 1
+                ]
+            ]
+        ]);
+
+        return new TimesheetFutureTimesValidator($config);
+    }
+
+    public function testConstraintIsInvalid()
+    {
+        $this->expectException(UnexpectedTypeException::class);
+
+        $this->validator->validate(new Timesheet(), new NotBlank());
+    }
+
+    public function testInvalidValueThrowsException()
+    {
+        $this->expectException(UnexpectedTypeException::class);
+
+        $this->validator->validate(new NotBlank(), new TimesheetFutureTimes(['message' => 'myMessage']));
+    }
+
+    public function testFutureBeginIsDisallowed()
+    {
+        $begin = new \DateTime('+10 hour');
+        $timesheet = new Timesheet();
+        $timesheet->setBegin($begin);
+
+        $this->validator->validate($timesheet, new TimesheetFutureTimes(['message' => 'myMessage']));
+
+        $this->buildViolation('The begin date cannot be in the future.')
+            ->atPath('property.path.begin')
+            ->setCode(TimesheetFutureTimes::BEGIN_IN_FUTURE_ERROR)
+            ->assertRaised();
+    }
+
+    public function testFutureBeginIsAllowed()
+    {
+        $this->validator = $this->createMyValidator(true);
+        $this->validator->initialize($this->context);
+
+        $begin = new \DateTime('+10 hour');
+        $timesheet = new Timesheet();
+        $timesheet->setBegin($begin);
+
+        $this->validator->validate($timesheet, new TimesheetFutureTimes(['message' => 'myMessage']));
+        self::assertEmpty($this->context->getViolations());
+    }
+}