Release 2.0.5 (#3888)

- Fixed: mandatory fields / form validation for invoice template
- Added: Duration as calendar title replacer (open: running records)
- Fixed: HTML injection in Calendar
- Fixed: Doctrine Proxies are not initialized (leads to empty customer/project)
- Fixed: tag creation
- Fixed: validation errors do not need to be logged in prod
- Removed: Customer VCard download, as used library is outdated and not maintained
- Added: supporting translations domains in many new places (menu, help_text, page_setup, report, exporter, calendar)

src/Entity/Invoice.php

@@ -190,6 +190,16 @@ class Invoice implements EntityWithMetaFields
 
     public function setModel(InvoiceModel $model): Invoice
     {
+        $template = $model->getTemplate();
+
+        if ($template === null) {
+            throw new \InvalidArgumentException('Missing invoice template');
+        }
+
+        if ($template->getDueDays() === null || $template->getVat() === null) {
+            throw new \InvalidArgumentException('Missing due-days or vat setting');
+        }
+
         $this->customer = $model->getCustomer();
         $this->user = $model->getUser();
         $this->total = $model->getCalculator()->getTotal();
@@ -201,7 +211,6 @@ class Invoice implements EntityWithMetaFields
         $this->createdAt = $createdAt;
         $this->timezone = $createdAt->getTimezone()->getName();
 
-        $template = $model->getTemplate();
         $this->dueDays = $template->getDueDays();
         $this->vat = $template->getVat();