human friendly name for bundles (#1491)

src/Plugin/Plugin.php

@@ -11,6 +11,10 @@ namespace App\Plugin;
 
 class Plugin
 {
+    /**
+     * @var string
+     */
+    private $id;
     /**
      * @var string
      */
@@ -24,60 +28,51 @@ class Plugin
      */
     private $metadata;
 
-    /**
-     * @return PluginMetadata
-     */
     public function getMetadata(): ?PluginMetadata
     {
         return $this->metadata;
     }
 
-    /**
-     * @param PluginMetadata $metadata
-     * @return Plugin
-     */
-    public function setMetadata(PluginMetadata $metadata)
+    public function setMetadata(PluginMetadata $metadata): Plugin
     {
         $this->metadata = $metadata;
 
         return $this;
     }
 
-    /**
-     * @return string
-     */
     public function getPath(): ?string
     {
         return $this->path;
     }
 
-    /**
-     * @param string $path
-     * @return Plugin
-     */
-    public function setPath(string $path)
+    public function setPath(string $path): Plugin
     {
         $this->path = $path;
 
         return $this;
     }
 
-    /**
-     * @return string
-     */
     public function getName(): ?string
     {
         return $this->name;
     }
 
-    /**
-     * @param string $name
-     * @return Plugin
-     */
-    public function setName(string $name)
+    public function setName(string $name): Plugin
     {
         $this->name = $name;
 
         return $this;
     }
+
+    public function getId(): ?string
+    {
+        return $this->id;
+    }
+
+    public function setId(string $id): Plugin
+    {
+        $this->id = $id;
+
+        return $this;
+    }
 }

src/Plugin/PluginManager.php

@@ -71,6 +71,7 @@ class PluginManager
     {
         $plugin = new Plugin();
         $plugin
+            ->setId($bundle->getName())
             ->setName($bundle->getName())
             ->setPath($bundle->getPath())
             ->setMetadata(new PluginMetadata())
@@ -100,6 +101,10 @@ class PluginManager
 
         $homepage = $json['homepage'] ?? Constants::HOMEPAGE . '/store/';
 
+        if (array_key_exists('name', $json['extra']['kimai'])) {
+            $plugin->setName($json['extra']['kimai']['name']);
+        }
+
         $plugin
             ->getMetadata()
             ->setHomepage($homepage)