jjsm01/kimai2
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

Code improvements (#1649)

Browse Source 
* use global namespace for faster lookups
* phpstan level 5
This commit is contained in:
Kevin Papst
2020-04-19 14:37:14 +02:00
committed by GitHub
parent 7b25e9acaf
commit 0f3fa8fdbe
183 changed files with 604 additions and 574 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/Controller/DoctorController.php
View File

@@ -110,14 +110,14 @@ class DoctorController extends AbstractController
foreach (self::REQUIRED_EXTENSIONS as $extName) {
$results[$extName] = false;
if (extension_loaded($extName)) {
if (\extension_loaded($extName)) {
$results[$extName] = true;
}
}
$results['Freetype Support'] = true;
// @see AvatarService::hasDependencies()
if (!function_exists('imagettfbbox')) {
if (!\function_exists('imagettfbbox')) {
$results['Freetype Support'] = false;
}
@@ -135,7 +135,7 @@ class DoctorController extends AbstractController
private function getLogFilename(): string
{
// why is this check here ???
if (!in_array(getenv('APP_ENV'), ['test', 'dev', 'prod'])) {
if (!\in_array(getenv('APP_ENV'), ['test', 'dev', 'prod'])) {
throw new \RuntimeException('Unsupported log environment');
}

2
src/Controller/PermissionController.php
View File

@@ -72,7 +72,7 @@ final class PermissionController extends AbstractController
// automatically import all hard coded (default) roles into the database table
foreach ($this->roleService->getAvailableNames() as $roleName) {
$roleName = strtoupper($roleName);
if (!in_array($roleName, $existing)) {
if (!\in_array($roleName, $existing)) {
$role = new Role();
$role->setName($roleName);
$this->roleRepository->saveRole($role);

4
src/Controller/TimesheetAbstractController.php
View File

@@ -172,7 +172,7 @@ abstract class TimesheetAbstractController extends AbstractController
protected function getTags(TagRepository $tagRepository, $tagNames)
{
$tags = [];
if (!is_array($tagNames)) {
if (!\is_array($tagNames)) {
$tagNames = explode(',', $tagNames);
}
foreach ($tagNames as $tagName) {
@@ -296,7 +296,7 @@ abstract class TimesheetAbstractController extends AbstractController
$dto->setEntities($timesheets);
if (count($dto->getEntities()) === 0) {
if (\count($dto->getEntities()) === 0) {
return $this->redirectToRoute($this->getTimesheetRoute());
}