jjsm01/kimai2
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

Code improvements (#1649)

Browse Source 
* use global namespace for faster lookups
* phpstan level 5
This commit is contained in:
Kevin Papst
2020-04-19 14:37:14 +02:00
committed by GitHub
parent 7b25e9acaf
commit 0f3fa8fdbe
183 changed files with 604 additions and 574 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/DependencyInjection/AppExtension.php
View File

@@ -90,11 +90,11 @@ class AppExtension extends Extension
// this should happen always at the end, so bundles do not mess with the base configuration
if ($container->hasParameter('kimai.bundles.config')) {
$bundleConfig = $container->getParameter('kimai.bundles.config');
if (!is_array($bundleConfig)) {
if (!\is_array($bundleConfig)) {
trigger_error('Invalid bundle configuration found, skipping all bundle configuration');
}
foreach ($bundleConfig as $key => $value) {
if (array_key_exists($key, $config)) {
if (\array_key_exists($key, $config)) {
trigger_error(sprintf('Invalid bundle configuration "%s" found, skipping', $key));
continue;
}
@@ -110,7 +110,7 @@ class AppExtension extends Extension
// make sure all allowed locales are registered
foreach ($locales as $locale) {
if (!array_key_exists($locale, $config)) {
if (!\array_key_exists($locale, $config)) {
$config[$locale] = $config[Constants::DEFAULT_LOCALE];
}
}
@@ -190,7 +190,7 @@ class AppExtension extends Extension
return false;
}
return !in_array('!' . $permission, $deleteFromArray);
return !\in_array('!' . $permission, $deleteFromArray);
});
}

2
src/DependencyInjection/Compiler/DoctrineCompilerPass.php
View File

@@ -50,7 +50,7 @@ class DoctrineCompilerPass implements CompilerPassInterface
);
}
if (!in_array($engine, $this->allowedEngines)) {
if (!\in_array($engine, $this->allowedEngines)) {
throw new \Exception(
'Unsupported database engine: ' . $engine . '. Kimai only supports one of: ' .
implode(', ', $this->allowedEngines)

2
src/DependencyInjection/Compiler/ExportServiceCompilerPass.php
View File

@@ -42,7 +42,7 @@ class ExportServiceCompilerPass implements CompilerPassInterface
$definition->addMethodCall('addTimesheetExporter', [new Reference($id)]);
}
$path = dirname(dirname(dirname(__DIR__))) . DIRECTORY_SEPARATOR;
$path = \dirname(\dirname(\dirname(__DIR__))) . DIRECTORY_SEPARATOR;
foreach ($container->getParameter('kimai.export.documents') as $exportPath) {
if (!is_dir($path . $exportPath)) {
continue;

2
src/DependencyInjection/Compiler/TwigContextCompilerPass.php
View File

@@ -34,7 +34,7 @@ class TwigContextCompilerPass implements CompilerPassInterface
$definition = $container->getDefinition('twig.loader.native_filesystem');
$path = dirname(dirname(dirname(__DIR__))) . DIRECTORY_SEPARATOR;
$path = \dirname(\dirname(\dirname(__DIR__))) . DIRECTORY_SEPARATOR;
foreach ($container->getParameter('kimai.invoice.documents') as $invoicePath) {
if (!is_dir($path . $invoicePath)) {
continue;

4
src/DependencyInjection/Configuration.php
View File

@@ -690,7 +690,7 @@ class Configuration implements ConfigurationInterface
->end()
->validate()
->ifTrue(static function ($v) {
return null !== $v['connection']['host'] && !extension_loaded('ldap');
return null !== $v['connection']['host'] && !\extension_loaded('ldap');
})
->thenInvalid('LDAP is activated, but the LDAP PHP extension is not loaded.')
->end()
@@ -833,7 +833,7 @@ class Configuration implements ConfigurationInterface
->variableNode('requestedAuthnContext')
->validate()
->ifTrue(function ($v) {
return !is_bool($v) && !is_array($v);
return !\is_bool($v) && !\is_array($v);
})
->thenInvalid('Must be an array or a bool.')
->end()