jjsm01/kimai2
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

Code improvements (#1649)

Browse Source 
* use global namespace for faster lookups
* phpstan level 5
This commit is contained in:
Kevin Papst
2020-04-19 14:37:14 +02:00
committed by GitHub
parent 7b25e9acaf
commit 0f3fa8fdbe
183 changed files with 604 additions and 574 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/Invoice/Renderer/AbstractSpreadsheetRenderer.php
View File

@@ -45,7 +45,7 @@ abstract class AbstractSpreadsheetRenderer extends AbstractRenderer
$worksheet = $spreadsheet->getActiveSheet();
$entries = $model->getCalculator()->getEntries();
$sheetReplacer = $model->toArray();
$invoiceItemCount = count($entries);
$invoiceItemCount = \count($entries);
if ($invoiceItemCount > 1) {
$this->addTemplateRows($worksheet, $invoiceItemCount);
}

2
src/Invoice/Renderer/AdvancedValueBinder.php
View File

@@ -30,7 +30,7 @@ class AdvancedValueBinder extends DefaultValueBinder implements IValueBinder
*/
public function bindValue(Cell $cell, $value = null)
{
if (is_string($value)) {
if (\is_string($value)) {
$value = StringHelper::sanitizeUTF8($value);
}

4
src/Invoice/Renderer/DocxRenderer.php
View File

@@ -41,10 +41,10 @@ final class DocxRenderer extends AbstractRenderer implements RendererInterface
}
try {
$template->cloneRow('entry.description', count($model->getCalculator()->getEntries()));
$template->cloneRow('entry.description', \count($model->getCalculator()->getEntries()));
} catch (OfficeException $ex) {
try {
$template->cloneRow('entry.row', count($model->getCalculator()->getEntries()));
$template->cloneRow('entry.row', \count($model->getCalculator()->getEntries()));
} catch (OfficeException $ex) {
@trigger_error(
sprintf('Invoice document (%s) did not contain a clone row, was that on purpose?', $document->getFilename())