Code improvements (#1649)

* use global namespace for faster lookups
* phpstan level 5

src/Saml/Provider/SamlProvider.php

@@ -9,6 +9,7 @@
 
 namespace App\Saml\Provider;
 
+use App\Entity\User;
 use App\Repository\UserRepository;
 use App\Saml\SamlTokenFactory;
 use App\Saml\User\SamlUserFactory;
@@ -46,11 +47,16 @@ final class SamlProvider implements AuthenticationProviderInterface
         $this->userFactory = $userFactory;
     }
 
+    /**
+     * @param SamlTokenInterface $token
+     * @return SamlTokenInterface
+     */
     public function authenticate(TokenInterface $token)
     {
         $user = null;
 
         try {
+            /** @var User $user */
             $user = $this->userProvider->loadUserByUsername($token->getUsername());
         } catch (UsernameNotFoundException $e) {
         }

src/Saml/User/SamlUserFactory.php

@@ -35,6 +35,10 @@ final class SamlUserFactory implements SamlUserFactoryInterface
         $this->groupMapping = $attributes['roles']['mapping'];
     }
 
+    /**
+     * @param SamlTokenInterface $token
+     * @return User
+     */
     public function createUser(SamlTokenInterface $token)
     {
         $user = new User();
@@ -60,7 +64,7 @@ final class SamlUserFactory implements SamlUserFactoryInterface
             $roles = [];
             $samlGroups = $token->getAttribute($this->groupAttribute);
             foreach ($samlGroups as $groupName) {
-                if (array_key_exists($groupName, $groupMap)) {
+                if (\array_key_exists($groupName, $groupMap)) {
                     $roles[] = $groupMap[$groupName];
                 }
             }