jjsm01/kimai2
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

Code improvements (#1649)

Browse Source 
* use global namespace for faster lookups
* phpstan level 5
This commit is contained in:
Kevin Papst
2020-04-19 14:37:14 +02:00
committed by GitHub
parent 7b25e9acaf
commit 0f3fa8fdbe
183 changed files with 604 additions and 574 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/Security/DoctrineUserProvider.php
View File

@@ -54,7 +54,7 @@ final class DoctrineUserProvider implements UserProviderInterface
public function refreshUser(SecurityUserInterface $user)
{
if (!$user instanceof User) {
throw new UnsupportedUserException(sprintf('Expected an instance of %s, but got "%s".', User::class, get_class($user)));
throw new UnsupportedUserException(sprintf('Expected an instance of %s, but got "%s".', User::class, \get_class($user)));
}
/** @var User|null $reloadedUser */

10
src/Security/RolePermissionManager.php
View File

@@ -39,18 +39,18 @@ final class RolePermissionManager
$isAllowed = $item['allowed'];
// see permissions.html.twig for this special case
if ($role === User::ROLE_SUPER_ADMIN && in_array($perm, ['role_permissions', 'view_user'])) {
if ($role === User::ROLE_SUPER_ADMIN && \in_array($perm, ['role_permissions', 'view_user'])) {
continue;
}
if (!$isAllowed) {
if (array_key_exists($role, $this->permissions)) {
if (\array_key_exists($role, $this->permissions)) {
if (($key = array_search($perm, $this->permissions[$role])) !== false) {
unset($this->permissions[$role][$key]);
}
}
} else {
if (!array_key_exists($role, $this->permissions)) {
if (!\array_key_exists($role, $this->permissions)) {
$this->permissions[$role] = [];
}
$this->permissions[$role][] = $perm;
@@ -66,7 +66,7 @@ final class RolePermissionManager
*/
public function isRegisteredPermission(string $permission): bool
{
return in_array($permission, $this->knownPermissions);
return \in_array($permission, $this->knownPermissions);
}
public function hasPermission(string $role, string $permission): bool
@@ -77,7 +77,7 @@ final class RolePermissionManager
return false;
}
return in_array($permission, $this->permissions[$role]);
return \in_array($permission, $this->permissions[$role]);
}
/**

2
src/Security/RoleService.php
View File

@@ -39,7 +39,7 @@ final class RoleService
$roles = [];
foreach ($this->roles as $key => $value) {
$roles[] = $key;
if (is_array($value)) {
if (\is_array($value)) {
foreach ($value as $name) {
$roles[] = $name;
}