jjsm01/kimai2
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

Code improvements (#1649)

Browse Source 
* use global namespace for faster lookups
* phpstan level 5
This commit is contained in:
Kevin Papst
2020-04-19 14:37:14 +02:00
committed by GitHub
parent 7b25e9acaf
commit 0f3fa8fdbe
183 changed files with 604 additions and 574 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/Twig/DatatableExtensions.php
View File

@@ -86,7 +86,7 @@ class DatatableExtensions extends AbstractExtension
}
$values = $this->cookies[$cookie];
if (empty($values) || !is_array($values)) {
if (empty($values) || !\is_array($values)) {
return $this->checkInColumDefinition($columns, $column);
}
@@ -103,9 +103,9 @@ class DatatableExtensions extends AbstractExtension
private function checkInColumDefinition(array $columns, string $column)
{
if (array_key_exists($column, $columns)) {
if (\array_key_exists($column, $columns)) {
$tmp = $columns[$column];
if (is_array($tmp)) {
if (\is_array($tmp)) {
$tmp = $tmp['class'];
}
foreach (explode(' ', $tmp) as $class) {

6
src/Twig/Extensions.php
View File

@@ -92,11 +92,11 @@ class Extensions extends AbstractExtension
*/
public function getClassName($object)
{
if (!is_object($object)) {
if (!\is_object($object)) {
return null;
}
return get_class($object);
return \get_class($object);
}
public function multilineIndent(?string $string, string $indent): string
@@ -106,7 +106,7 @@ class Extensions extends AbstractExtension
}
$parts = explode("\r\n", $string);
if (count($parts) === 1) {
if (\count($parts) === 1) {
$parts = explode("\n", $string);
}

2
src/Twig/MarkdownExtension.php
View File

@@ -62,7 +62,7 @@ final class MarkdownExtension extends AbstractExtension
return '';
}
if (!$fullLength && strlen($content) > 101) {
if (!$fullLength && \strlen($content) > 101) {
$content = trim(substr($content, 0, 100)) . ' …';
}

2
src/Twig/PaginationExtension.php
View File

@@ -53,7 +53,7 @@ class PaginationExtension extends AbstractExtension
{
@trigger_error('Twig function pagerfanta() is deprecated and will be removed with 2.0, use pagination() instead', E_USER_DEPRECATED);
if (is_array($viewName)) {
if (\is_array($viewName)) {
$options = $viewName;
}

4
src/Twig/WidgetExtension.php
View File

@@ -46,11 +46,11 @@ class WidgetExtension extends AbstractExtension
*/
public function renderWidget($widget, array $options = [])
{
if (!($widget instanceof WidgetInterface) && !is_string($widget)) {
if (!($widget instanceof WidgetInterface) && !\is_string($widget)) {
throw new InvalidArgumentException('Widget must either implement WidgetInterface or be a string');
}
if (is_string($widget)) {
if (\is_string($widget)) {
if (!$this->service->hasWidget($widget)) {
throw new InvalidArgumentException(sprintf('Unknown widget "%s" requested', $widget));
}