jjsm01/kimai2
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

Code improvements (#1649)

Browse Source 
* use global namespace for faster lookups
* phpstan level 5
This commit is contained in:
Kevin Papst
2020-04-19 14:37:14 +02:00
committed by GitHub
parent 7b25e9acaf
commit 0f3fa8fdbe
183 changed files with 604 additions and 574 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
tests/API/ActivityControllerTest.php
View File

@@ -28,7 +28,7 @@ class ActivityControllerTest extends APIControllerBaseTest
{
use RateControllerTestTrait;
protected function getRateUrl(string $id = '1', ?string $rateId = null): string
protected function getRateUrl($id = '1', $rateId = null): string
{
if (null !== $rateId) {
return sprintf('/api/activities/%s/rates/%s', $id, $rateId);
@@ -37,7 +37,7 @@ class ActivityControllerTest extends APIControllerBaseTest
return sprintf('/api/activities/%s/rates', $id);
}
protected function importTestRates(string $id): array
protected function importTestRates($id): array
{
/** @var ActivityRateRepository $rateRepository */
$rateRepository = $this->getEntityManager()->getRepository(ActivityRate::class);
@@ -123,8 +123,8 @@ class ActivityControllerTest extends APIControllerBaseTest
$this->assertIsArray($result);
$this->assertNotEmpty($result);
$this->assertEquals(count($expected), count($result));
for ($i = 0; $i < count($result); $i++) {
$this->assertEquals(\count($expected), \count($result));
for ($i = 0; $i < \count($result); $i++) {
$activity = $result[$i];
$hasProject = $expected[$i][0];
$this->assertStructure($activity, false);
@@ -160,7 +160,7 @@ class ActivityControllerTest extends APIControllerBaseTest
$this->assertIsArray($result);
$this->assertNotEmpty($result);
$this->assertEquals(5, count($result));
$this->assertEquals(5, \count($result));
$this->assertStructure($result[0], false);
$this->assertEquals(1, $result[4]['project']);
$this->assertEquals(2, $result[3]['project']);

4
tests/API/ConfigurationControllerTest.php
View File

@@ -29,7 +29,7 @@ class ConfigurationControllerTest extends APIControllerBaseTest
$this->assertIsArray($result);
$this->assertNotEmpty($result);
$this->assertEquals(7, count($result));
$this->assertEquals(7, \count($result));
$this->assertI18nStructure($result);
}
@@ -56,7 +56,7 @@ class ConfigurationControllerTest extends APIControllerBaseTest
$this->assertIsArray($result);
$this->assertNotEmpty($result);
$this->assertEquals(5, count($result));
$this->assertEquals(5, \count($result));
$this->assertTimesheetStructure($result);
}

8
tests/API/CustomerControllerTest.php
View File

@@ -25,7 +25,7 @@ class CustomerControllerTest extends APIControllerBaseTest
{
use RateControllerTestTrait;
protected function getRateUrl(string $id = '1', ?string $rateId = null): string
protected function getRateUrl($id = '1', $rateId = null): string
{
if (null !== $rateId) {
return sprintf('/api/customers/%s/rates/%s', $id, $rateId);
@@ -34,7 +34,7 @@ class CustomerControllerTest extends APIControllerBaseTest
return sprintf('/api/customers/%s/rates', $id);
}
protected function importTestRates(string $id): array
protected function importTestRates($id): array
{
/** @var CustomerRateRepository $rateRepository */
$rateRepository = $this->getEntityManager()->getRepository(CustomerRate::class);
@@ -83,7 +83,7 @@ class CustomerControllerTest extends APIControllerBaseTest
$this->assertIsArray($result);
$this->assertNotEmpty($result);
$this->assertEquals(1, count($result));
$this->assertEquals(1, \count($result));
$this->assertStructure($result[0], false);
}
@@ -96,7 +96,7 @@ class CustomerControllerTest extends APIControllerBaseTest
$this->assertIsArray($result);
$this->assertNotEmpty($result);
$this->assertEquals(1, count($result));
$this->assertEquals(1, \count($result));
$this->assertStructure($result[0], false);
}

10
tests/API/ProjectControllerTest.php
View File

@@ -28,7 +28,7 @@ class ProjectControllerTest extends APIControllerBaseTest
{
use RateControllerTestTrait;
protected function getRateUrl(string $id = '1', ?string $rateId = null): string
protected function getRateUrl($id = '1', $rateId = null): string
{
if (null !== $rateId) {
return sprintf('/api/projects/%s/rates/%s', $id, $rateId);
@@ -37,7 +37,7 @@ class ProjectControllerTest extends APIControllerBaseTest
return sprintf('/api/projects/%s/rates', $id);
}
protected function importTestRates(string $id): array
protected function importTestRates($id): array
{
/** @var ProjectRateRepository $rateRepository */
$rateRepository = $this->getEntityManager()->getRepository(ProjectRate::class);
@@ -85,7 +85,7 @@ class ProjectControllerTest extends APIControllerBaseTest
$this->assertIsArray($result);
$this->assertNotEmpty($result);
$this->assertEquals(1, count($result));
$this->assertEquals(1, \count($result));
$this->assertStructure($result[0], false);
}
@@ -133,9 +133,9 @@ class ProjectControllerTest extends APIControllerBaseTest
$result = json_decode($client->getResponse()->getContent(), true);
$this->assertIsArray($result);
$this->assertEquals(count($expected), count($result), 'Found wrong amount of projects');
$this->assertEquals(\count($expected), \count($result), 'Found wrong amount of projects');
for ($i = 0; $i < count($expected); $i++) {
for ($i = 0; $i < \count($expected); $i++) {
$project = $result[$i];
$compare = $expected[$i];
$this->assertStructure($project, false);

17
tests/API/RateControllerTestTrait.php
View File

@@ -17,9 +17,18 @@ use Symfony\Component\HttpFoundation\Response;
*/
trait RateControllerTestTrait
{
abstract protected function getRateUrl(string $id = '1', ?string $rateId = null): string;
/**
* @param string|int $id
* @param string|int|null $rateId
* @return string
*/
abstract protected function getRateUrl($id = '1', $rateId = null): string;
abstract protected function importTestRates(string $id): array;
/**
* @param string|int $id
* @return array
*/
abstract protected function importTestRates($id): array;
public function testAddRateMissingEntityAction()
{
@@ -129,7 +138,7 @@ trait RateControllerTestTrait
$result = json_decode($client->getResponse()->getContent(), true);
$this->assertIsArray($result);
$this->assertNotEmpty($result);
$this->assertEquals(count($expectedRates), count($result));
$this->assertEquals(\count($expectedRates), \count($result));
foreach ($result as $rate) {
$this->assertRateStructure($rate, ($rate['user'] === null ? null : $rate['user']['id']));
@@ -161,7 +170,7 @@ trait RateControllerTestTrait
$result = json_decode($client->getResponse()->getContent(), true);
$this->assertIsArray($result);
$this->assertEquals(count($expectedRates) - 1, count($result));
$this->assertEquals(\count($expectedRates) - 1, \count($result));
}
public function testDeleteRateEntityNotFound()

10
tests/API/TagControllerTest.php
View File

@@ -26,7 +26,7 @@ class TagControllerTest extends APIControllerBaseTest
$fixture = new TagFixtures();
$fixture->setTagArray($tagList);
$this->importFixture($client, $fixture);
$this->importFixture($fixture);
}
public function testIsSecure()
@@ -43,7 +43,7 @@ class TagControllerTest extends APIControllerBaseTest
$this->assertIsArray($result);
$this->assertNotEmpty($result);
$this->assertEquals(10, count($result));
$this->assertEquals(10, \count($result));
$this->assertEquals('Test', $result[9]);
}
@@ -57,7 +57,7 @@ class TagControllerTest extends APIControllerBaseTest
$this->assertIsArray($result);
$this->assertEmpty($result);
$this->assertEquals(0, count($result));
$this->assertEquals(0, \count($result));
}
public function testPostAction()
@@ -101,7 +101,7 @@ class TagControllerTest extends APIControllerBaseTest
$this->assertIsArray($result);
$this->assertNotEmpty($result);
$this->assertEquals(3, count($result));
$this->assertEquals(3, \count($result));
$this->assertEquals('Administration', $result[0]);
$this->assertEquals('Bug Fixing', $result[1]);
@@ -121,7 +121,7 @@ class TagControllerTest extends APIControllerBaseTest
$this->assertAccessIsGranted($client, '/api/tags');
$result = json_decode($client->getResponse()->getContent(), true);
$this->assertEquals(9, count($result));
$this->assertEquals(9, \count($result));
}
public function testDeleteActionWithUnknownTimesheet()

4
tests/API/TeamControllerTest.php
View File

@@ -25,7 +25,7 @@ class TeamControllerTest extends APIControllerBaseTest
{
$fixture = new TeamFixtures();
$fixture->setAmount(1);
$this->importFixture($client, $fixture);
$this->importFixture($fixture);
}
public function testIsSecure()
@@ -58,7 +58,7 @@ class TeamControllerTest extends APIControllerBaseTest
$this->assertIsArray($result);
$this->assertNotEmpty($result);
self::assertEquals(2, count($result));
self::assertEquals(2, \count($result));
$this->assertStructure($result[0], false);
}

74
tests/API/TimesheetControllerTest.php
View File

@@ -32,18 +32,16 @@ class TimesheetControllerTest extends APIControllerBaseTest
protected function importFixtureForUser(string $role)
{
$em = $this->getEntityManager();
$fixture = new TimesheetFixtures();
$fixture
->setFixedRate(true)
->setHourlyRate(true)
->setAmount(10)
->setUser($this->getUserByRole($em, $role))
->setUser($this->getUserByRole($role))
->setStartDate((new \DateTime('first day of this month'))->setTime(0, 0, 1))
->setAllowEmptyDescriptions(false)
;
$this->importFixture($this, $fixture);
$this->importFixture($fixture);
}
public function testIsSecure()
@@ -60,7 +58,7 @@ class TimesheetControllerTest extends APIControllerBaseTest
$this->assertIsArray($result);
$this->assertNotEmpty($result);
$this->assertEquals(10, count($result));
$this->assertEquals(10, \count($result));
$this->assertDefaultStructure($result[0], false);
}
@@ -73,7 +71,7 @@ class TimesheetControllerTest extends APIControllerBaseTest
$this->assertIsArray($result);
$this->assertNotEmpty($result);
$this->assertEquals(10, count($result));
$this->assertEquals(10, \count($result));
$this->assertDefaultStructure($result[0], false);
$this->assertHasSubresources($result[0]);
}
@@ -89,10 +87,10 @@ class TimesheetControllerTest extends APIControllerBaseTest
->setFixedRate(true)
->setHourlyRate(true)
->setAmount(7)
->setUser($this->getUserByRole($em, User::ROLE_ADMIN))
->setUser($this->getUserByRole(User::ROLE_ADMIN))
->setStartDate(new \DateTime('-10 days'))
;
$this->importFixture($em, $fixture);
$this->importFixture($fixture);
$query = ['user' => 2];
$this->assertAccessIsGranted($client, '/api/timesheets', 'GET', $query);
@@ -100,7 +98,7 @@ class TimesheetControllerTest extends APIControllerBaseTest
$this->assertIsArray($result);
$this->assertNotEmpty($result);
$this->assertEquals(10, count($result));
$this->assertEquals(10, \count($result));
$this->assertDefaultStructure($result[0], false);
}
@@ -115,10 +113,10 @@ class TimesheetControllerTest extends APIControllerBaseTest
->setFixedRate(true)
->setHourlyRate(true)
->setAmount(7)
->setUser($this->getUserByRole($em, User::ROLE_ADMIN))
->setUser($this->getUserByRole(User::ROLE_ADMIN))
->setStartDate(new \DateTime('-10 days'))
;
$this->importFixture($em, $fixture);
$this->importFixture($fixture);
$query = ['user' => 'all'];
$this->assertAccessIsGranted($client, '/api/timesheets', 'GET', $query);
@@ -126,7 +124,7 @@ class TimesheetControllerTest extends APIControllerBaseTest
$this->assertIsArray($result);
$this->assertNotEmpty($result);
$this->assertEquals(17, count($result));
$this->assertEquals(17, \count($result));
$this->assertDefaultStructure($result[0], false);
}
@@ -169,7 +167,7 @@ class TimesheetControllerTest extends APIControllerBaseTest
$this->assertIsArray($result);
$this->assertNotEmpty($result);
$this->assertEquals(5, count($result));
$this->assertEquals(5, \count($result));
$this->assertDefaultStructure($result[0], false);
}
@@ -201,7 +199,7 @@ class TimesheetControllerTest extends APIControllerBaseTest
$this->assertIsArray($result);
$this->assertNotEmpty($result);
$this->assertEquals(5, count($result));
$this->assertEquals(5, \count($result));
$this->assertDefaultStructure($result[0], false);
}
@@ -215,11 +213,11 @@ class TimesheetControllerTest extends APIControllerBaseTest
$fixture
->setExported(true)
->setAmount(7)
->setUser($this->getUserByRole($em, User::ROLE_USER))
->setUser($this->getUserByRole(User::ROLE_USER))
->setStartDate(new \DateTime('first day of this month'))
->setAllowEmptyDescriptions(false)
;
$this->importFixture($em, $fixture);
$this->importFixture($fixture);
$begin = new \DateTime('first day of this month');
$begin->setTime(0, 0, 0);
@@ -239,7 +237,7 @@ class TimesheetControllerTest extends APIControllerBaseTest
$this->assertIsArray($result);
$this->assertNotEmpty($result);
$this->assertEquals(7, count($result));
$this->assertEquals(7, \count($result));
$this->assertDefaultStructure($result[0], false);
$query = [
@@ -255,7 +253,7 @@ class TimesheetControllerTest extends APIControllerBaseTest
$this->assertIsArray($result);
$this->assertNotEmpty($result);
$this->assertEquals(10, count($result));
$this->assertEquals(10, \count($result));
$this->assertDefaultStructure($result[0], false);
$query = [
@@ -269,7 +267,7 @@ class TimesheetControllerTest extends APIControllerBaseTest
$this->assertIsArray($result);
$this->assertNotEmpty($result);
$this->assertEquals(17, count($result));
$this->assertEquals(17, \count($result));
$this->assertDefaultStructure($result[0], false);
}
@@ -424,11 +422,11 @@ class TimesheetControllerTest extends APIControllerBaseTest
->setFixedRate(true)
->setHourlyRate(true)
->setAmount(10)
->setUser($this->getUserByRole($em, User::ROLE_TEAMLEAD))
->setUser($this->getUserByRole(User::ROLE_TEAMLEAD))
->setStartDate(new \DateTime('-10 days'))
->setAllowEmptyDescriptions(false)
;
$this->importFixture($em, $fixture);
$this->importFixture($fixture);
$data = [
'activity' => 1,
@@ -567,10 +565,10 @@ class TimesheetControllerTest extends APIControllerBaseTest
->setFixedRate(true)
->setHourlyRate(true)
->setAmount(10)
->setUser($this->getUserByRole($em, User::ROLE_ADMIN))
->setUser($this->getUserByRole(User::ROLE_ADMIN))
->setStartDate($start)
;
$this->importFixture($em, $fixture);
$this->importFixture($fixture);
$query = [
'user' => 'all',
@@ -583,7 +581,7 @@ class TimesheetControllerTest extends APIControllerBaseTest
$this->assertIsArray($result);
$this->assertNotEmpty($result);
$this->assertEquals(1, count($result));
$this->assertEquals(1, \count($result));
$this->assertDefaultStructure($result[0], false);
$this->assertHasSubresources($result[0]);
}
@@ -600,17 +598,17 @@ class TimesheetControllerTest extends APIControllerBaseTest
->setFixedRate(true)
->setHourlyRate(true)
->setAmount(0)
->setUser($this->getUserByRole($em, User::ROLE_USER))
->setUser($this->getUserByRole(User::ROLE_USER))
->setStartDate($start)
->setAmountRunning(3)
;
$this->importFixture($em, $fixture);
$this->importFixture($fixture);
$this->request($client, '/api/timesheets/active');
$this->assertTrue($client->getResponse()->isSuccessful());
$results = json_decode($client->getResponse()->getContent(), true);
$this->assertEquals(3, count($results));
$this->assertEquals(3, \count($results));
foreach ($results as $timesheet) {
$this->assertDefaultStructure($timesheet, false);
}
@@ -629,11 +627,11 @@ class TimesheetControllerTest extends APIControllerBaseTest
->setFixedRate(true)
->setHourlyRate(true)
->setAmount(0)
->setUser($this->getUserByRole($em, User::ROLE_USER))
->setUser($this->getUserByRole(User::ROLE_USER))
->setStartDate($start)
->setAmountRunning(1)
;
$this->importFixture($em, $fixture);
$this->importFixture($fixture);
$this->request($client, '/api/timesheets/11/stop', 'PATCH');
$this->assertTrue($client->getResponse()->isSuccessful());
@@ -671,11 +669,11 @@ class TimesheetControllerTest extends APIControllerBaseTest
->setFixedRate(true)
->setHourlyRate(true)
->setAmount(2)
->setUser($this->getUserByRole($em, User::ROLE_ADMIN))
->setUser($this->getUserByRole(User::ROLE_ADMIN))
->setStartDate($start)
->setAmountRunning(3)
;
$this->importFixture($em, $fixture);
$this->importFixture($fixture);
$this->request($client, '/api/timesheets/12/stop', 'PATCH');
$this->assertApiResponseAccessDenied($client->getResponse(), 'You are not allowed to stop this timesheet');
@@ -692,12 +690,12 @@ class TimesheetControllerTest extends APIControllerBaseTest
->setFixedRate(true)
->setHourlyRate(true)
->setAmount(10)
->setUser($this->getUserByRole($em, User::ROLE_USER))
->setUser($this->getUserByRole(User::ROLE_USER))
->setStartDate(new \DateTime('-10 days'))
->setAllowEmptyDescriptions(false)
->setUseTags(true)
->setTags(['Test', 'Administration']);
$this->importFixture($em, $fixture);
$this->importFixture($fixture);
$query = ['tags' => 'Test'];
$this->assertAccessIsGranted($client, '/api/timesheets', 'GET', $query);
@@ -705,7 +703,7 @@ class TimesheetControllerTest extends APIControllerBaseTest
$this->assertIsArray($result);
$this->assertNotEmpty($result);
$this->assertEquals(5, count($result));
$this->assertEquals(5, \count($result));
$this->assertDefaultStructure($result[0], false);
$query = ['tags' => 'Test,Admin'];
@@ -714,7 +712,7 @@ class TimesheetControllerTest extends APIControllerBaseTest
$this->assertIsArray($result);
$this->assertNotEmpty($result);
$this->assertEquals(10, count($result));
$this->assertEquals(10, \count($result));
$this->assertDefaultStructure($result[0], false);
$query = ['tags' => 'Nothing-2-see,here'];
@@ -723,7 +721,7 @@ class TimesheetControllerTest extends APIControllerBaseTest
$this->assertIsArray($result);
$this->assertNotEmpty($result);
$this->assertEquals(20, count($result));
$this->assertEquals(20, \count($result));
$this->assertDefaultStructure($result[0], false);
}
@@ -811,11 +809,11 @@ class TimesheetControllerTest extends APIControllerBaseTest
->setFixedRate(true)
->setHourlyRate(true)
->setAmount(2)
->setUser($this->getUserByRole($em, User::ROLE_ADMIN))
->setUser($this->getUserByRole(User::ROLE_ADMIN))
->setStartDate($start)
->setAmountRunning(3)
;
$this->importFixture($em, $fixture);
$this->importFixture($fixture);
$this->request($client, '/api/timesheets/2/restart', 'PATCH');
$this->assertApiResponseAccessDenied($client->getResponse(), 'You are not allowed to re-start this timesheet');

6
tests/API/UserControllerTest.php
View File

@@ -47,7 +47,7 @@ class UserControllerTest extends APIControllerBaseTest
$this->assertIsArray($result);
$this->assertNotEmpty($result);
$this->assertEquals(7, count($result));
$this->assertEquals(7, \count($result));
foreach ($result as $user) {
$this->assertStructure($user, false);
}
@@ -61,7 +61,7 @@ class UserControllerTest extends APIControllerBaseTest
$this->assertIsArray($result);
$this->assertNotEmpty($result);
$this->assertEquals(1, count($result));
$this->assertEquals(1, \count($result));
foreach ($result as $user) {
$this->assertStructure($user, false);
}
@@ -75,7 +75,7 @@ class UserControllerTest extends APIControllerBaseTest
$this->assertIsArray($result);
$this->assertNotEmpty($result);
$this->assertEquals(8, count($result));
$this->assertEquals(8, \count($result));
foreach ($result as $user) {
$this->assertStructure($user, false);
}

10
tests/Command/InvoiceCreateCommandTest.php
View File

@@ -165,7 +165,7 @@ class InvoiceCreateCommandTest extends KernelTestCase
public function testCreateInvoice()
{
$fixture = new InvoiceFixtures();
$this->importFixture($this, $fixture);
$this->importFixture($fixture);
$commandTester = $this->createInvoice(['--user' => UserFixtures::USERNAME_SUPER_ADMIN, '--set-exported' => null, '--customer' => 1, '--template' => 'Invoice', '--start' => '2020-01-01', '--end' => '2020-03-01']);
@@ -189,22 +189,22 @@ class InvoiceCreateCommandTest extends KernelTestCase
$meta->setValue('Invoice');
$customer->setMetaField($meta);
});
$this->importFixture($em, $fixture);
$this->importFixture($fixture);
$fixture = new ProjectFixtures();
$fixture->setCustomers([$em->getRepository(Customer::class)->find(2)]);
$fixture->setAmount(1);
$this->importFixture($em, $fixture);
$this->importFixture($fixture);
$fixture = new TimesheetFixtures();
$fixture->setUser($this->getUserByName(UserFixtures::USERNAME_SUPER_ADMIN));
$fixture->setAmount(20);
$fixture->setStartDate($start);
$fixture->setProjects([$em->getRepository(Project::class)->find(2)]);
$this->importFixture($em, $fixture);
$this->importFixture($fixture);
$fixture = new InvoiceFixtures();
$this->importFixture($em, $fixture);
$this->importFixture($fixture);
}
public function testCreateInvoiceByCustomer()

2
tests/Configuration/CalendarConfigurationTest.php
View File

@@ -79,6 +79,6 @@ class CalendarConfigurationTest extends TestCase
$this->assertEquals('wertwertwegsdfbdf243w567fg8ihuon', $sut->getGoogleApiKey());
$sources = $sut->getGoogleSources();
$this->assertEquals(2, count($sources));
$this->assertEquals(2, \count($sources));
}
}

4
tests/Controller/AboutControllerTest.php
View File

@@ -22,10 +22,10 @@ class AboutControllerTest extends ControllerBaseTest
$this->assertAccessIsGranted($client, '/about');
$result = $client->getCrawler()->filter('ul.nav.nav-stacked li a');
$this->assertEquals(4, count($result));
$this->assertEquals(4, \count($result));
$result = $client->getCrawler()->filter('div.box-body pre');
$this->assertEquals(1, count($result));
$this->assertEquals(1, \count($result));
$this->assertStringContainsString('MIT License', $result->text(null, true));
}
}

26
tests/Controller/ActivityControllerTest.php
View File

@@ -54,7 +54,7 @@ class ActivityControllerTest extends ControllerBaseTest
$activity->setMetaField((new ActivityMeta())->setName('location')->setValue('homeoffice'));
$activity->setMetaField((new ActivityMeta())->setName('feature')->setValue('timetracking'));
});
$this->importFixture($client, $fixture);
$this->importFixture($fixture);
$this->assertAccessIsGranted($client, '/admin/activity/');
@@ -82,14 +82,14 @@ class ActivityControllerTest extends ControllerBaseTest
$fixture = new TimesheetFixtures();
$fixture->setAmount(10);
$fixture->setActivities($em->getRepository(Activity::class)->findAll());
$fixture->setUser($this->getUserByRole($em, User::ROLE_ADMIN));
$this->importFixture($client, $fixture);
$fixture->setUser($this->getUserByRole(User::ROLE_ADMIN));
$this->importFixture($fixture);
$project = $em->getRepository(Project::class)->find(1);
$fixture = new ActivityFixtures();
$fixture->setAmount(6); // to trigger a second page
$fixture->setProjects([$project]);
$this->importFixture($client, $fixture);
$this->importFixture($fixture);
$this->assertAccessIsGranted($client, '/admin/activity/1/details');
self::assertHasProgressbar($client);
@@ -165,7 +165,7 @@ class ActivityControllerTest extends ControllerBaseTest
$fixture = new ProjectFixtures();
$fixture->setAmount(10);
$this->importFixture($client, $fixture);
$this->importFixture($fixture);
$this->assertAccessIsGranted($client, '/admin/activity/create');
$form = $client->getCrawler()->filter('form[name=activity_edit_form]')->form();
@@ -262,12 +262,12 @@ class ActivityControllerTest extends ControllerBaseTest
$em = $this->getEntityManager();
$fixture = new TimesheetFixtures();
$fixture->setUser($this->getUserByRole($em, User::ROLE_USER));
$fixture->setUser($this->getUserByRole(User::ROLE_USER));
$fixture->setAmount(10);
$this->importFixture($client, $fixture);
$this->importFixture($fixture);
$timesheets = $em->getRepository(Timesheet::class)->findAll();
$this->assertEquals(10, count($timesheets));
$this->assertEquals(10, \count($timesheets));
/** @var Timesheet $entry */
foreach ($timesheets as $entry) {
@@ -303,15 +303,15 @@ class ActivityControllerTest extends ControllerBaseTest
$em = $this->getEntityManager();
$fixture = new TimesheetFixtures();
$fixture->setUser($this->getUserByRole($em, User::ROLE_USER));
$fixture->setUser($this->getUserByRole(User::ROLE_USER));
$fixture->setAmount(10);
$this->importFixture($client, $fixture);
$this->importFixture($fixture);
$fixture = new ActivityFixtures();
$fixture->setAmount(1)->setIsGlobal(true)->setIsVisible(true);
$this->importFixture($client, $fixture);
$this->importFixture($fixture);
$timesheets = $em->getRepository(Timesheet::class)->findAll();
$this->assertEquals(10, count($timesheets));
$this->assertEquals(10, \count($timesheets));
/** @var Timesheet $entry */
foreach ($timesheets as $entry) {
@@ -335,7 +335,7 @@ class ActivityControllerTest extends ControllerBaseTest
$this->assertHasFlashSuccess($client);
$timesheets = $em->getRepository(Timesheet::class)->findAll();
$this->assertEquals(10, count($timesheets));
$this->assertEquals(10, \count($timesheets));
/** @var Timesheet $entry */
foreach ($timesheets as $entry) {

10
tests/Controller/ControllerBaseTest.php
View File

@@ -214,7 +214,7 @@ abstract class ControllerBaseTest extends WebTestCase
self::assertEquals($expectedUrl, $element->getAttribute('href'));
}
self::assertEquals(count($buttons), $node->count(), 'Invalid amount of page actions');
self::assertEquals(\count($buttons), $node->count(), 'Invalid amount of page actions');
}
/**
@@ -239,9 +239,9 @@ abstract class ControllerBaseTest extends WebTestCase
$validationErrors = $submittedForm->filter('li.text-danger');
self::assertEquals(
count($fieldNames),
count($validationErrors),
sprintf('Expected %s validation errors, found %s', count($fieldNames), count($validationErrors))
\count($fieldNames),
\count($validationErrors),
sprintf('Expected %s validation errors, found %s', \count($fieldNames), \count($validationErrors))
);
foreach ($fieldNames as $name) {
@@ -251,7 +251,7 @@ abstract class ControllerBaseTest extends WebTestCase
self::assertNotNull($list, 'Form field has no validation message: ' . $name);
$validation = $list->filter('li.text-danger');
if (count($validation) < 1) {
if (\count($validation) < 1) {
// decorated form fields with icon have a different html structure, see kimai-theme.html.twig
/** @var \DOMElement $listMsg */
$listMsg = $field->parents()->getNode(1);

24
tests/Controller/CustomerControllerTest.php
View File

@@ -55,7 +55,7 @@ class CustomerControllerTest extends ControllerBaseTest
$customer->setMetaField((new CustomerMeta())->setName('location')->setValue('homeoffice'));
$customer->setMetaField((new CustomerMeta())->setName('feature')->setValue('timetracking'));
});
$this->importFixture($client, $fixture);
$this->importFixture($fixture);
$this->assertAccessIsGranted($client, '/admin/customer/');
@@ -209,7 +209,7 @@ class CustomerControllerTest extends ControllerBaseTest
$fixture = new ProjectFixtures();
$fixture->setAmount(9); // to trigger a second page (every third activity is hidden)
$fixture->setCustomers([$customer]);
$this->importFixture($client, $fixture);
$this->importFixture($fixture);
$this->assertAccessIsGranted($client, '/admin/customer/1/projects/1');
@@ -289,7 +289,7 @@ class CustomerControllerTest extends ControllerBaseTest
$fixture = new TeamFixtures();
$fixture->setAmount(2);
$fixture->setAddCustomer(false);
$this->importFixture($client, $fixture);
$this->importFixture($fixture);
$this->assertAccessIsGranted($client, '/admin/customer/1/permissions');
$form = $client->getCrawler()->filter('form[name=customer_team_permission_form]')->form();
@@ -316,7 +316,7 @@ class CustomerControllerTest extends ControllerBaseTest
$fixture = new CustomerFixtures();
$fixture->setAmount(1);
$this->importFixture($client, $fixture);
$this->importFixture($fixture);
$this->request($client, '/admin/customer/2/edit');
$this->assertTrue($client->getResponse()->isSuccessful());
@@ -341,12 +341,12 @@ class CustomerControllerTest extends ControllerBaseTest
$em = $this->getEntityManager();
$fixture = new TimesheetFixtures();
$fixture->setUser($this->getUserByRole($em, User::ROLE_USER));
$fixture->setUser($this->getUserByRole(User::ROLE_USER));
$fixture->setAmount(10);
$this->importFixture($client, $fixture);
$this->importFixture($fixture);
$timesheets = $em->getRepository(Timesheet::class)->findAll();
$this->assertEquals(10, count($timesheets));
$this->assertEquals(10, \count($timesheets));
/** @var Timesheet $entry */
foreach ($timesheets as $entry) {
@@ -380,15 +380,15 @@ class CustomerControllerTest extends ControllerBaseTest
$em = $this->getEntityManager();
$fixture = new TimesheetFixtures();
$fixture->setUser($this->getUserByRole($em, User::ROLE_USER));
$fixture->setUser($this->getUserByRole(User::ROLE_USER));
$fixture->setAmount(10);
$this->importFixture($client, $fixture);
$this->importFixture($fixture);
$fixture = new CustomerFixtures();
$fixture->setAmount(1)->setIsVisible(true);
$this->importFixture($client, $fixture);
$this->importFixture($fixture);
$timesheets = $em->getRepository(Timesheet::class)->findAll();
$this->assertEquals(10, count($timesheets));
$this->assertEquals(10, \count($timesheets));
/** @var Timesheet $entry */
foreach ($timesheets as $entry) {
@@ -412,7 +412,7 @@ class CustomerControllerTest extends ControllerBaseTest
$this->assertHasFlashSuccess($client);
$timesheets = $em->getRepository(Timesheet::class)->findAll();
$this->assertEquals(10, count($timesheets));
$this->assertEquals(10, \count($timesheets));
/** @var Timesheet $entry */
foreach ($timesheets as $entry) {

2
tests/Controller/DoctorControllerTest.php
View File

@@ -32,6 +32,6 @@ class DoctorControllerTest extends ControllerBaseTest
$this->assertAccessIsGranted($client, '/doctor');
$result = $client->getCrawler()->filter('.content .box-header');
$this->assertEquals(7, count($result));
$this->assertEquals(7, \count($result));
}
}

28
tests/Controller/ExportControllerTest.php
View File

@@ -45,8 +45,8 @@ class ExportControllerTest extends ControllerBaseTest
$client = $this->getClientForAuthenticatedUser(User::ROLE_TEAMLEAD);
$em = $this->getEntityManager();
$teamlead = $this->getUserByRole($em, User::ROLE_TEAMLEAD);
$user = $this->getUserByRole($em, User::ROLE_USER);
$teamlead = $this->getUserByRole(User::ROLE_TEAMLEAD);
$user = $this->getUserByRole(User::ROLE_USER);
/** @var Team $team */
$team = new Team();
$team->setName('fooo');
@@ -57,7 +57,7 @@ class ExportControllerTest extends ControllerBaseTest
$em->persist($teamlead);
$em->flush();
$user = $this->getUserByRole($em, User::ROLE_USER);
$user = $this->getUserByRole(User::ROLE_USER);
$begin = new \DateTime('first day of this month');
$fixture = new TimesheetFixtures();
@@ -70,9 +70,9 @@ class ExportControllerTest extends ControllerBaseTest
$em->persist($team);
})
;
$this->importFixture($client, $fixture);
$this->importFixture($fixture);
$teamlead = $this->getUserByRole($em, User::ROLE_TEAMLEAD);
$teamlead = $this->getUserByRole(User::ROLE_TEAMLEAD);
$fixture = new TimesheetFixtures();
$fixture
@@ -80,7 +80,7 @@ class ExportControllerTest extends ControllerBaseTest
->setAmount(2)
->setStartDate($begin)
;
$this->importFixture($client, $fixture);
$this->importFixture($fixture);
$em->flush();
$this->request($client, '/export/?preview=');
@@ -94,7 +94,7 @@ class ExportControllerTest extends ControllerBaseTest
// assert export type buttons are available
$expected = ['csv', 'default.html.twig', 'default-budget.pdf.twig', 'default-internal.pdf.twig', 'default.pdf.twig', 'xlsx'];
$node = $client->getCrawler()->filter('#export-buttons .startExportBtn');
$this->assertEquals(count($expected), $node->count());
$this->assertEquals(\count($expected), $node->count());
/** @var \DOMElement $button */
foreach ($node->getIterator() as $button) {
$type = $button->getAttribute('data-type');
@@ -108,7 +108,7 @@ class ExportControllerTest extends ControllerBaseTest
$em = $this->getEntityManager();
$begin = new \DateTime('first day of this month');
$user = $this->getUserByRole($em, User::ROLE_USER);
$user = $this->getUserByRole(User::ROLE_USER);
// these should be ignored, becuase teamlead and user do NOT share a team!
$fixture = new TimesheetFixtures();
@@ -117,7 +117,7 @@ class ExportControllerTest extends ControllerBaseTest
->setAmount(20)
->setStartDate($begin)
;
$this->importFixture($client, $fixture);
$this->importFixture($fixture);
$this->request($client, '/export/?preview=');
$this->assertTrue($client->getResponse()->isSuccessful());
@@ -125,7 +125,7 @@ class ExportControllerTest extends ControllerBaseTest
// make sure all existing records are displayed
$this->assertHasNoEntriesWithFilter($client);
$teamlead = $this->getUserByRole($em, User::ROLE_TEAMLEAD);
$teamlead = $this->getUserByRole(User::ROLE_TEAMLEAD);
$fixture = new TimesheetFixtures();
$fixture
@@ -133,7 +133,7 @@ class ExportControllerTest extends ControllerBaseTest
->setAmount(2)
->setStartDate($begin)
;
$this->importFixture($client, $fixture);
$this->importFixture($fixture);
$this->request($client, '/export/?preview=');
$this->assertTrue($client->getResponse()->isSuccessful());
@@ -146,7 +146,7 @@ class ExportControllerTest extends ControllerBaseTest
// assert export type buttons are available
$expected = ['csv', 'default.html.twig', 'default-budget.pdf.twig', 'default-internal.pdf.twig', 'default.pdf.twig', 'xlsx'];
$node = $client->getCrawler()->filter('#export-buttons .startExportBtn');
$this->assertEquals(count($expected), $node->count());
$this->assertEquals(\count($expected), $node->count());
/** @var \DOMElement $button */
foreach ($node->getIterator() as $button) {
$type = $button->getAttribute('data-type');
@@ -196,11 +196,11 @@ class ExportControllerTest extends ControllerBaseTest
$begin = new \DateTime('first day of this month');
$fixture = new TimesheetFixtures();
$fixture
->setUser($this->getUserByRole($em, User::ROLE_USER))
->setUser($this->getUserByRole(User::ROLE_USER))
->setAmount(20)
->setStartDate($begin)
;
$this->importFixture($client, $fixture);
$this->importFixture($fixture);
$this->request($client, '/export/');
$this->assertTrue($client->getResponse()->isSuccessful());

2
tests/Controller/HomepageControllerTest.php
View File

@@ -36,7 +36,7 @@ class HomepageControllerTest extends ControllerBaseTest
$client = $this->getClientForAuthenticatedUser(User::ROLE_USER);
$em = $this->getEntityManager();
$user = $this->getUserByRole($em, User::ROLE_USER);
$user = $this->getUserByRole(User::ROLE_USER);
$pref = (new UserPreference())
->setName('login.initial_view')

30
tests/Controller/InvoiceControllerTest.php
View File

@@ -70,7 +70,7 @@ class InvoiceControllerTest extends ControllerBaseTest
$client = $this->getClientForAuthenticatedUser(User::ROLE_TEAMLEAD);
$fixture = new InvoiceFixtures();
$this->importFixture($client, $fixture);
$this->importFixture($fixture);
$this->request($client, '/invoice/?preview=');
$this->assertTrue($client->getResponse()->isSuccessful());
@@ -83,7 +83,7 @@ class InvoiceControllerTest extends ControllerBaseTest
$client = $this->getClientForAuthenticatedUser(User::ROLE_ADMIN);
$fixture = new InvoiceFixtures();
$this->importFixture($client, $fixture);
$this->importFixture($fixture);
$this->request($client, '/invoice/template');
@@ -120,7 +120,7 @@ class InvoiceControllerTest extends ControllerBaseTest
$em = $this->getEntityManager();
$fixture = new InvoiceFixtures();
$this->importFixture($client, $fixture);
$this->importFixture($fixture);
/** @var InvoiceTemplate $template */
$template = $em->getRepository(InvoiceTemplate::class)->find(1);
@@ -148,17 +148,17 @@ class InvoiceControllerTest extends ControllerBaseTest
$em = $this->getEntityManager();
$fixture = new InvoiceFixtures();
$this->importFixture($client, $fixture);
$this->importFixture($fixture);
$begin = new \DateTime('first day of this month');
$end = new \DateTime('last day of this month');
$fixture = new TimesheetFixtures();
$fixture
->setUser($this->getUserByRole($em, User::ROLE_TEAMLEAD))
->setUser($this->getUserByRole(User::ROLE_TEAMLEAD))
->setAmount(20)
->setStartDate($begin)
;
$this->importFixture($client, $fixture);
$this->importFixture($fixture);
$this->request($client, '/invoice/');
$this->assertTrue($client->getResponse()->isSuccessful());
@@ -214,17 +214,17 @@ class InvoiceControllerTest extends ControllerBaseTest
$em = $this->getEntityManager();
$fixture = new InvoiceFixtures();
$this->importFixture($client, $fixture);
$this->importFixture($fixture);
$begin = new \DateTime('first day of this month');
$end = new \DateTime('last day of this month');
$fixture = new TimesheetFixtures();
$fixture
->setUser($this->getUserByRole($em, User::ROLE_TEAMLEAD))
->setUser($this->getUserByRole(User::ROLE_TEAMLEAD))
->setAmount(20)
->setStartDate($begin)
;
$this->importFixture($client, $fixture);
$this->importFixture($fixture);
$this->request($client, '/invoice/');
$this->assertTrue($client->getResponse()->isSuccessful());
@@ -273,17 +273,17 @@ class InvoiceControllerTest extends ControllerBaseTest
$em = $this->getEntityManager();
$fixture = new InvoiceFixtures();
$this->importFixture($client, $fixture);
$this->importFixture($fixture);
$begin = new \DateTime('first day of this month');
$end = new \DateTime('last day of this month');
$fixture = new TimesheetFixtures();
$fixture
->setUser($this->getUserByRole($em, User::ROLE_ADMIN))
->setUser($this->getUserByRole(User::ROLE_ADMIN))
->setAmount(20)
->setStartDate($begin)
;
$this->importFixture($client, $fixture);
$this->importFixture($fixture);
$this->request($client, '/invoice/');
$this->assertTrue($client->getResponse()->isSuccessful());
@@ -357,7 +357,7 @@ class InvoiceControllerTest extends ControllerBaseTest
$client = $this->getClientForAuthenticatedUser(User::ROLE_ADMIN);
$fixture = new InvoiceFixtures();
$this->importFixture($client, $fixture);
$this->importFixture($fixture);
$this->request($client, '/invoice/template/1/edit?page=1');
$form = $client->getCrawler()->filter('form[name=invoice_template_form]')->form();
@@ -384,7 +384,7 @@ class InvoiceControllerTest extends ControllerBaseTest
$em = $this->getEntityManager();
$fixture = new InvoiceFixtures();
$this->importFixture($client, $fixture);
$this->importFixture($fixture);
$this->request($client, '/invoice/template/1/delete');
$this->assertIsRedirect($client, '/invoice/template');
@@ -402,7 +402,7 @@ class InvoiceControllerTest extends ControllerBaseTest
$em = $this->getEntityManager();
$fixture = new InvoiceFixtures();
$this->importFixture($client, $fixture);
$this->importFixture($fixture);
$this->request($client, '/invoice/document_upload');
$this->assertTrue($client->getResponse()->isSuccessful());

4
tests/Controller/LayoutControllerTest.php
View File

@@ -22,7 +22,7 @@ class LayoutControllerTest extends ControllerBaseTest
$client = $this->getClientForAuthenticatedUser(User::ROLE_USER);
$em = $this->getEntityManager();
$user = $this->getUserByRole($em, User::ROLE_USER);
$user = $this->getUserByRole(User::ROLE_USER);
$this->request($client, '/dashboard/');
$this->assertTrue($client->getResponse()->isSuccessful());
@@ -78,7 +78,7 @@ class LayoutControllerTest extends ControllerBaseTest
$client = $this->getClientForAuthenticatedUser(User::ROLE_USER);
$em = $this->getEntityManager();
$user = $this->getUserByRole($em, User::ROLE_USER);
$user = $this->getUserByRole(User::ROLE_USER);
$this->request($client, '/layou/active_entries');
$this->assertTrue($client->getResponse()->isSuccessful());

6
tests/Controller/PermissionControllerTest.php
View File

@@ -160,7 +160,7 @@ class PermissionControllerTest extends ControllerBaseTest
$em = $this->getEntityManager();
$rolePermissions = $em->getRepository(RolePermission::class)->findAll();
$this->assertEquals(0, count($rolePermissions));
$this->assertEquals(0, \count($rolePermissions));
// create the permission
$this->request($client, '/admin/permissions/roles/1/view_user/1');
@@ -168,7 +168,7 @@ class PermissionControllerTest extends ControllerBaseTest
$client->followRedirect();
$rolePermissions = $em->getRepository(RolePermission::class)->findAll();
$this->assertEquals(1, count($rolePermissions));
$this->assertEquals(1, \count($rolePermissions));
$permission = $rolePermissions[0];
self::assertInstanceOf(RolePermission::class, $permission);
self::assertEquals('view_user', $permission->getPermission());
@@ -185,7 +185,7 @@ class PermissionControllerTest extends ControllerBaseTest
$client->followRedirect();
$rolePermissions = $em->getRepository(RolePermission::class)->findAll();
$this->assertEquals(1, count($rolePermissions));
$this->assertEquals(1, \count($rolePermissions));
$permission = $rolePermissions[0];
self::assertInstanceOf(RolePermission::class, $permission);
self::assertEquals('view_user', $permission->getPermission());

32
tests/Controller/ProfileControllerTest.php
View File

@@ -53,9 +53,9 @@ class ProfileControllerTest extends ControllerBaseTest
foreach ($dates as $start) {
$fixture = new TimesheetFixtures();
$fixture->setAmount(10);
$fixture->setUser($this->getUserByRole($em, User::ROLE_USER));
$fixture->setUser($this->getUserByRole(User::ROLE_USER));
$fixture->setStartDate($start);
$this->importFixture($client, $fixture);
$this->importFixture($fixture);
}
$this->request($client, '/profile/' . UserFixtures::USERNAME_USER);
@@ -111,7 +111,7 @@ class ProfileControllerTest extends ControllerBaseTest
$this->assertTrue($client->getResponse()->isSuccessful());
$tabs = $client->getCrawler()->filter('div.nav-tabs-custom ul.nav-tabs li');
$this->assertEquals(count($expectedTabs), $tabs->count());
$this->assertEquals(\count($expectedTabs), $tabs->count());
$foundTabs = [];
/** @var \DOMElement $tab */
@@ -135,7 +135,7 @@ class ProfileControllerTest extends ControllerBaseTest
$em = $this->getEntityManager();
/** @var User $user */
$user = $this->getUserByRole($em, User::ROLE_USER);
$user = $this->getUserByRole(User::ROLE_USER);
$this->assertEquals(UserFixtures::USERNAME_USER, $user->getUsername());
$this->assertEquals('John Doe', $user->getAlias());
@@ -161,7 +161,7 @@ class ProfileControllerTest extends ControllerBaseTest
$this->assertHasFlashSuccess($client);
$em = $this->getEntityManager();
$user = $this->getUserByRole($em, User::ROLE_USER);
$user = $this->getUserByRole(User::ROLE_USER);
$this->assertEquals(UserFixtures::USERNAME_USER, $user->getUsername());
$this->assertEquals('Johnny', $user->getAlias());
@@ -194,7 +194,7 @@ class ProfileControllerTest extends ControllerBaseTest
$this->assertHasFlashSuccess($client);
$em = $this->getEntityManager();
$user = $this->getUserByRole($em, User::ROLE_USER);
$user = $this->getUserByRole(User::ROLE_USER);
$this->assertEquals(UserFixtures::USERNAME_USER, $user->getUsername());
$this->assertEquals('Johnny', $user->getAlias());
@@ -211,7 +211,7 @@ class ProfileControllerTest extends ControllerBaseTest
$em = $this->getEntityManager();
/** @var User $user */
$user = $this->getUserByRole($em, User::ROLE_USER);
$user = $this->getUserByRole(User::ROLE_USER);
/** @var EncoderFactoryInterface $passwordEncoder */
$passwordEncoder = static::$kernel->getContainer()->get('test.PasswordEncoder');
@@ -237,7 +237,7 @@ class ProfileControllerTest extends ControllerBaseTest
$this->assertHasFlashSuccess($client);
$em = $this->getEntityManager();
$user = $this->getUserByRole($em, User::ROLE_USER);
$user = $this->getUserByRole(User::ROLE_USER);
$this->assertFalse($passwordEncoder->getEncoder($user)->isPasswordValid($user->getPassword(), UserFixtures::DEFAULT_PASSWORD, $user->getSalt()));
$this->assertTrue($passwordEncoder->getEncoder($user)->isPasswordValid($user->getPassword(), 'test1234', $user->getSalt()));
@@ -250,7 +250,7 @@ class ProfileControllerTest extends ControllerBaseTest
$em = $this->getEntityManager();
/** @var User $user */
$user = $this->getUserByRole($em, User::ROLE_USER);
$user = $this->getUserByRole(User::ROLE_USER);
/** @var EncoderFactoryInterface $passwordEncoder */
$passwordEncoder = static::$kernel->getContainer()->get('test.PasswordEncoder');
@@ -275,7 +275,7 @@ class ProfileControllerTest extends ControllerBaseTest
$this->assertHasFlashSuccess($client);
$em = $this->getEntityManager();
$user = $this->getUserByRole($em, User::ROLE_USER);
$user = $this->getUserByRole(User::ROLE_USER);
$this->assertFalse($passwordEncoder->getEncoder($user)->isPasswordValid($user->getApiToken(), UserFixtures::DEFAULT_API_TOKEN, $user->getSalt()));
$this->assertTrue($passwordEncoder->getEncoder($user)->isPasswordValid($user->getApiToken(), 'test123', $user->getSalt()));
@@ -295,7 +295,7 @@ class ProfileControllerTest extends ControllerBaseTest
$em = $this->getEntityManager();
/** @var User $user */
$user = $this->getUserByRole($em, User::ROLE_USER);
$user = $this->getUserByRole(User::ROLE_USER);
$this->assertEquals(['ROLE_USER'], $user->getRoles());
@@ -314,7 +314,7 @@ class ProfileControllerTest extends ControllerBaseTest
$this->assertHasFlashSuccess($client);
$em = $this->getEntityManager();
$user = $this->getUserByRole($em, User::ROLE_USER);
$user = $this->getUserByRole(User::ROLE_USER);
$this->assertEquals(['ROLE_TEAMLEAD', 'ROLE_SUPER_ADMIN', 'ROLE_USER'], $user->getRoles());
}
@@ -335,19 +335,19 @@ class ProfileControllerTest extends ControllerBaseTest
$em = $this->getEntityManager();
/** @var User $user */
$user = $this->getUserByRole($em, User::ROLE_USER);
$user = $this->getUserByRole(User::ROLE_USER);
$fixture = new TeamFixtures();
$fixture->setAmount(3);
$fixture->setAddCustomer(true);
$fixture->setAddUser(false);
$fixture->addUserToIgnore($user);
$this->importFixture($client, $fixture);
$this->importFixture($fixture);
$this->request($client, '/profile/' . UserFixtures::USERNAME_USER . '/teams');
/** @var User $user */
$user = $this->getUserByRole($em, User::ROLE_USER);
$user = $this->getUserByRole(User::ROLE_USER);
$this->assertEquals([], $user->getTeams()->toArray());
$form = $client->getCrawler()->filter('form[name=user_teams]')->form();
@@ -364,7 +364,7 @@ class ProfileControllerTest extends ControllerBaseTest
$this->assertHasFlashSuccess($client);
$em = $this->getEntityManager();
$user = $this->getUserByRole($em, User::ROLE_USER);
$user = $this->getUserByRole(User::ROLE_USER);
$this->assertEquals(1, $user->getTeams()->count());
}

34
tests/Controller/ProjectControllerTest.php
View File

@@ -62,7 +62,7 @@ class ProjectControllerTest extends ControllerBaseTest
$project->setMetaField((new ProjectMeta())->setName('location')->setValue('homeoffice'));
$project->setMetaField((new ProjectMeta())->setName('feature')->setValue('timetracking'));
});
$this->importFixture($client, $fixture);
$this->importFixture($fixture);
$this->assertAccessIsGranted($client, '/admin/project/');
@@ -91,14 +91,14 @@ class ProjectControllerTest extends ControllerBaseTest
$fixture = new TimesheetFixtures();
$fixture->setAmount(10);
$fixture->setProjects([$project]);
$fixture->setUser($this->getUserByRole($em, User::ROLE_ADMIN));
$this->importFixture($client, $fixture);
$fixture->setUser($this->getUserByRole(User::ROLE_ADMIN));
$this->importFixture($fixture);
$project = $em->getRepository(Project::class)->find(1);
$fixture = new ActivityFixtures();
$fixture->setAmount(6); // to trigger a second page
$fixture->setProjects([$project]);
$this->importFixture($client, $fixture);
$this->importFixture($fixture);
$this->assertAccessIsGranted($client, '/admin/project/1/details');
self::assertHasProgressbar($client);
@@ -154,7 +154,7 @@ class ProjectControllerTest extends ControllerBaseTest
$project->setEnd(new \DateTime());
$em->persist($project);
$team = new Team();
$team->setTeamLead($this->getUserByRole($em, User::ROLE_ADMIN));
$team->setTeamLead($this->getUserByRole(User::ROLE_ADMIN));
$team->addProject($project);
$team->setName('project 1');
$em->persist($team);
@@ -275,7 +275,7 @@ class ProjectControllerTest extends ControllerBaseTest
$fixture = new ActivityFixtures();
$fixture->setAmount(9); // to trigger a second page (every third activity is hidden)
$fixture->setProjects([$project]);
$this->importFixture($client, $fixture);
$this->importFixture($fixture);
$this->assertAccessIsGranted($client, '/admin/project/1/activities/1');
@@ -321,7 +321,7 @@ class ProjectControllerTest extends ControllerBaseTest
$fixture = new CustomerFixtures();
$fixture->setAmount(10);
$this->importFixture($client, $fixture);
$this->importFixture($fixture);
$this->assertAccessIsGranted($client, '/admin/project/create');
$form = $client->getCrawler()->filter('form[name=project_edit_form]')->form();
@@ -377,7 +377,7 @@ class ProjectControllerTest extends ControllerBaseTest
$fixture = new TeamFixtures();
$fixture->setAmount(2);
$fixture->setAddCustomer(false);
$this->importFixture($client, $fixture);
$this->importFixture($fixture);
$this->assertAccessIsGranted($client, '/admin/project/1/permissions');
$form = $client->getCrawler()->filter('form[name=project_team_permission_form]')->form();
@@ -404,7 +404,7 @@ class ProjectControllerTest extends ControllerBaseTest
$fixture = new ProjectFixtures();
$fixture->setAmount(1);
$this->importFixture($client, $fixture);
$this->importFixture($fixture);
$this->request($client, '/admin/project/2/edit');
$this->assertTrue($client->getResponse()->isSuccessful());
@@ -429,12 +429,12 @@ class ProjectControllerTest extends ControllerBaseTest
$em = $this->getEntityManager();
$fixture = new TimesheetFixtures();
$fixture->setUser($this->getUserByRole($em, User::ROLE_USER));
$fixture->setUser($this->getUserByRole(User::ROLE_USER));
$fixture->setAmount(10);
$this->importFixture($client, $fixture);
$this->importFixture($fixture);
$timesheets = $em->getRepository(Timesheet::class)->findAll();
$this->assertEquals(10, count($timesheets));
$this->assertEquals(10, \count($timesheets));
/** @var Timesheet $entry */
foreach ($timesheets as $entry) {
@@ -468,15 +468,15 @@ class ProjectControllerTest extends ControllerBaseTest
$em = $this->getEntityManager();
$fixture = new TimesheetFixtures();
$fixture->setUser($this->getUserByRole($em, User::ROLE_USER));
$fixture->setUser($this->getUserByRole(User::ROLE_USER));
$fixture->setAmount(10);
$this->importFixture($client, $fixture);
$this->importFixture($fixture);
$fixture = new ProjectFixtures();
$fixture->setAmount(1)->setIsVisible(true);
$this->importFixture($client, $fixture);
$this->importFixture($fixture);
$timesheets = $em->getRepository(Timesheet::class)->findAll();
$this->assertEquals(10, count($timesheets));
$this->assertEquals(10, \count($timesheets));
/** @var Timesheet $entry */
foreach ($timesheets as $entry) {
@@ -500,7 +500,7 @@ class ProjectControllerTest extends ControllerBaseTest
$this->assertHasFlashSuccess($client);
$timesheets = $em->getRepository(Timesheet::class)->findAll();
$this->assertEquals(10, count($timesheets));
$this->assertEquals(10, \count($timesheets));
/** @var Timesheet $entry */
foreach ($timesheets as $entry) {

12
tests/Controller/SystemConfigurationControllerTest.php
View File

@@ -35,14 +35,14 @@ class SystemConfigurationControllerTest extends ControllerBaseTest
$expectedForms = $this->getTestDataForms();
$result = $client->getCrawler()->filter('section.content div.box.box-primary');
$this->assertEquals(count($expectedForms), count($result));
$this->assertEquals(\count($expectedForms), \count($result));
$result = $client->getCrawler()->filter('section.content div.box.box-primary form');
$this->assertEquals(count($expectedForms), count($result));
$this->assertEquals(\count($expectedForms), \count($result));
foreach ($expectedForms as $formConfig) {
$result = $client->getCrawler()->filter($formConfig[0]);
$this->assertEquals(1, count($result));
$this->assertEquals(1, \count($result));
$form = $result->form();
$this->assertStringEndsWith($formConfig[1], $form->getUri());
$this->assertEquals('POST', $form->getMethod());
@@ -57,13 +57,13 @@ class SystemConfigurationControllerTest extends ControllerBaseTest
$expectedForms = $this->getTestDataForms();
$result = $client->getCrawler()->filter('section.content div.box.box-primary');
$this->assertEquals(1, count($result));
$this->assertEquals(1, \count($result));
$result = $client->getCrawler()->filter('section.content div.box.box-primary form');
$this->assertEquals(1, count($result));
$this->assertEquals(1, \count($result));
$result = $client->getCrawler()->filter('form[name=system_configuration_form_timesheet]');
$this->assertEquals(1, count($result));
$this->assertEquals(1, \count($result));
$form = $result->form();
$this->assertEquals('POST', $form->getMethod());
}

2
tests/Controller/TagControllerTest.php
View File

@@ -26,7 +26,7 @@ class TagControllerTest extends ControllerBaseTest
$fixture = new TagFixtures();
$fixture->setTagArray($tagList);
$this->importFixture($client, $fixture);
$this->importFixture($fixture);
}
public function testIsSecure()

20
tests/Controller/TeamControllerTest.php
View File

@@ -37,7 +37,7 @@ class TeamControllerTest extends ControllerBaseTest
$em = $this->getEntityManager();
$fixture = new TeamFixtures();
$fixture->setAmount(5);
$this->importFixture($em, $fixture);
$this->importFixture($fixture);
$this->assertAccessIsGranted($client, '/admin/teams/');
$this->assertPageActions($client, [
@@ -58,7 +58,7 @@ class TeamControllerTest extends ControllerBaseTest
$fixture->setCallback(function (Team $team) {
$team->setName($team->getName() . '- fantastic team with foooo bar magic');
});
$this->importFixture($em, $fixture);
$this->importFixture($fixture);
$this->assertAccessIsGranted($client, '/admin/teams/');
@@ -109,7 +109,7 @@ class TeamControllerTest extends ControllerBaseTest
$em = $this->getEntityManager();
$fixture = new TeamFixtures();
$fixture->setAmount(2);
$this->importFixture($em, $fixture);
$this->importFixture($fixture);
$this->assertAccessIsGranted($client, '/admin/teams/1/edit');
$form = $client->getCrawler()->filter('form[name=team_edit_form]')->form();
@@ -132,7 +132,7 @@ class TeamControllerTest extends ControllerBaseTest
$em = $this->getEntityManager();
$fixture = new TeamFixtures();
$fixture->setAmount(2);
$this->importFixture($em, $fixture);
$this->importFixture($fixture);
$this->assertAccessIsGranted($client, '/admin/teams/1/edit_member');
$form = $client->getCrawler()->filter('form[name=team_edit_form]')->form();
@@ -158,10 +158,10 @@ class TeamControllerTest extends ControllerBaseTest
$fixture = new TeamFixtures();
$fixture->setAmount(2);
$fixture->setAddCustomer(false);
$this->importFixture($em, $fixture);
$this->importFixture($fixture);
$team = $em->getRepository(Team::class)->find(1);
self::assertEquals(0, count($team->getCustomers()));
self::assertEquals(0, \count($team->getCustomers()));
$this->assertAccessIsGranted($client, '/admin/teams/1/edit');
$form = $client->getCrawler()->filter('form[name=team_customer_form]')->form();
@@ -174,7 +174,7 @@ class TeamControllerTest extends ControllerBaseTest
$this->assertIsRedirect($client, $this->createUrl('/admin/teams/1/edit'));
$team = $em->getRepository(Team::class)->find(1);
self::assertEquals(1, count($team->getCustomers()));
self::assertEquals(1, \count($team->getCustomers()));
}
public function testEditProjectAccessAction()
@@ -187,10 +187,10 @@ class TeamControllerTest extends ControllerBaseTest
$fixture = new TeamFixtures();
$fixture->setAmount(2);
$fixture->setAddCustomer(false);
$this->importFixture($em, $fixture);
$this->importFixture($fixture);
$team = $em->getRepository(Team::class)->find(1);
self::assertEquals(0, count($team->getProjects()));
self::assertEquals(0, \count($team->getProjects()));
$this->assertAccessIsGranted($client, '/admin/teams/1/edit');
$form = $client->getCrawler()->filter('form[name=team_project_form]')->form();
@@ -203,6 +203,6 @@ class TeamControllerTest extends ControllerBaseTest
$this->assertIsRedirect($client, $this->createUrl('/admin/teams/1/edit'));
$team = $em->getRepository(Team::class)->find(1);
self::assertEquals(1, count($team->getProjects()));
self::assertEquals(1, \count($team->getProjects()));
}
}

30
tests/Controller/TimesheetControllerTest.php
View File

@@ -55,9 +55,9 @@ class TimesheetControllerTest extends ControllerBaseTest
$fixture = new TimesheetFixtures();
$fixture->setAmount(5);
$fixture->setAmountRunning(2);
$fixture->setUser($this->getUserByRole($em, User::ROLE_USER));
$fixture->setUser($this->getUserByRole(User::ROLE_USER));
$fixture->setStartDate($start);
$this->importFixture($em, $fixture);
$this->importFixture($fixture);
$this->request($client, '/timesheet/');
$this->assertTrue($client->getResponse()->isSuccessful());
@@ -91,20 +91,20 @@ class TimesheetControllerTest extends ControllerBaseTest
$em = $this->getEntityManager();
$fixture = new TimesheetFixtures();
$fixture->setAmount(5);
$fixture->setUser($this->getUserByRole($em, User::ROLE_USER));
$fixture->setUser($this->getUserByRole(User::ROLE_USER));
$fixture->setStartDate($start);
$fixture->setCallback(function (Timesheet $timesheet) {
$timesheet->setDescription('I am a foobar with tralalalala some more content');
$timesheet->setMetaField((new TimesheetMeta())->setName('location')->setValue('homeoffice'));
$timesheet->setMetaField((new TimesheetMeta())->setName('feature')->setValue('timetracking'));
});
$this->importFixture($em, $fixture);
$this->importFixture($fixture);
$fixture = new TimesheetFixtures();
$fixture->setAmount(5);
$fixture->setAmountRunning(5);
$fixture->setUser($this->getUserByRole($em, User::ROLE_USER));
$fixture->setUser($this->getUserByRole(User::ROLE_USER));
$fixture->setStartDate($start);
$this->importFixture($em, $fixture);
$this->importFixture($fixture);
$this->request($client, '/timesheet/');
$this->assertTrue($client->getResponse()->isSuccessful());
@@ -128,9 +128,9 @@ class TimesheetControllerTest extends ControllerBaseTest
$em = $this->getEntityManager();
$fixture = new TimesheetFixtures();
$fixture->setAmount(5);
$fixture->setUser($this->getUserByRole($em, User::ROLE_USER));
$fixture->setUser($this->getUserByRole(User::ROLE_USER));
$fixture->setStartDate(new \DateTime('-10 days'));
$this->importFixture($em, $fixture);
$this->importFixture($fixture);
$this->request($client, '/timesheet/');
$this->assertTrue($client->getResponse()->isSuccessful());
@@ -154,7 +154,7 @@ class TimesheetControllerTest extends ControllerBaseTest
$this->assertEquals('invoice_print', $body->getAttribute('class'));
$result = $node->filter('section.invoice table.table tbody tr');
$this->assertEquals(5, count($result));
$this->assertEquals(5, \count($result));
}
public function testCreateAction()
@@ -293,9 +293,9 @@ class TimesheetControllerTest extends ControllerBaseTest
$em = $this->getEntityManager();
$fixture = new TimesheetFixtures();
$fixture->setAmount(10);
$fixture->setUser($this->getUserByRole($em, User::ROLE_USER));
$fixture->setUser($this->getUserByRole(User::ROLE_USER));
$fixture->setStartDate('2017-05-01');
$this->importFixture($em, $fixture);
$this->importFixture($fixture);
$this->request($client, '/timesheet/1/edit');
@@ -332,11 +332,11 @@ class TimesheetControllerTest extends ControllerBaseTest
$client = $this->getClientForAuthenticatedUser(User::ROLE_USER);
$em = $this->getEntityManager();
$user = $this->getUserByRole($em, User::ROLE_USER);
$user = $this->getUserByRole(User::ROLE_USER);
$fixture = new TimesheetFixtures();
$fixture->setAmount(10);
$fixture->setUser($user);
$this->importFixture($em, $fixture);
$this->importFixture($fixture);
$this->assertAccessIsGranted($client, '/timesheet/');
@@ -371,11 +371,11 @@ class TimesheetControllerTest extends ControllerBaseTest
$client = $this->getClientForAuthenticatedUser(User::ROLE_SUPER_ADMIN);
$em = $this->getEntityManager();
$user = $this->getUserByRole($em, User::ROLE_SUPER_ADMIN);
$user = $this->getUserByRole(User::ROLE_SUPER_ADMIN);
$fixture = new TimesheetFixtures();
$fixture->setAmount(10);
$fixture->setUser($user);
$this->importFixture($em, $fixture);
$this->importFixture($fixture);
$this->assertAccessIsGranted($client, '/timesheet/');

38
tests/Controller/TimesheetTeamControllerTest.php
View File

@@ -59,13 +59,13 @@ class TimesheetTeamControllerTest extends ControllerBaseTest
$start = new \DateTime('first day of this month');
$em = $this->getEntityManager();
$user = $this->getUserByRole($em, User::ROLE_USER);
$user = $this->getUserByRole(User::ROLE_USER);
$fixture = new TimesheetFixtures();
$fixture->setAmount(10);
$fixture->setAmountRunning(3);
$fixture->setUser($user);
$fixture->setStartDate($start);
$this->importFixture($em, $fixture);
$this->importFixture($fixture);
$this->request($client, '/team/timesheet/');
$this->assertTrue($client->getResponse()->isSuccessful());
@@ -98,20 +98,20 @@ class TimesheetTeamControllerTest extends ControllerBaseTest
$em = $this->getEntityManager();
$fixture = new TimesheetFixtures();
$fixture->setAmount(5);
$fixture->setUser($this->getUserByRole($em, User::ROLE_USER));
$fixture->setUser($this->getUserByRole(User::ROLE_USER));
$fixture->setStartDate($start);
$fixture->setCallback(function (Timesheet $timesheet) {
$timesheet->setDescription('I am a foobar with tralalalala some more content');
$timesheet->setMetaField((new TimesheetMeta())->setName('location')->setValue('homeoffice'));
$timesheet->setMetaField((new TimesheetMeta())->setName('feature')->setValue('timetracking'));
});
$this->importFixture($em, $fixture);
$this->importFixture($fixture);
$fixture = new TimesheetFixtures();
$fixture->setAmount(5);
$fixture->setAmountRunning(5);
$fixture->setUser($this->getUserByRole($em, User::ROLE_USER));
$fixture->setUser($this->getUserByRole(User::ROLE_USER));
$fixture->setStartDate($start);
$this->importFixture($em, $fixture);
$this->importFixture($fixture);
$this->request($client, '/team/timesheet/');
$this->assertTrue($client->getResponse()->isSuccessful());
@@ -135,14 +135,14 @@ class TimesheetTeamControllerTest extends ControllerBaseTest
$em = $this->getEntityManager();
$fixture = new TimesheetFixtures();
$fixture->setAmount(7);
$fixture->setUser($this->getUserByRole($em, User::ROLE_USER));
$fixture->setUser($this->getUserByRole(User::ROLE_USER));
$fixture->setStartDate(new \DateTime('-10 days'));
$this->importFixture($em, $fixture);
$this->importFixture($fixture);
$fixture = new TimesheetFixtures();
$fixture->setAmount(3);
$fixture->setUser($this->getUserByRole($em, User::ROLE_TEAMLEAD));
$fixture->setUser($this->getUserByRole(User::ROLE_TEAMLEAD));
$fixture->setStartDate(new \DateTime('-10 days'));
$this->importFixture($em, $fixture);
$this->importFixture($fixture);
$this->request($client, '/team/timesheet/');
$this->assertTrue($client->getResponse()->isSuccessful());
@@ -166,7 +166,7 @@ class TimesheetTeamControllerTest extends ControllerBaseTest
$this->assertEquals('invoice_print', $body->getAttribute('class'));
$result = $node->filter('section.invoice table.table tbody tr');
$this->assertEquals(10, count($result));
$this->assertEquals(10, \count($result));
}
public function testCreateAction()
@@ -205,13 +205,13 @@ class TimesheetTeamControllerTest extends ControllerBaseTest
$client = $this->getClientForAuthenticatedUser(User::ROLE_ADMIN);
$em = $this->getEntityManager();
$user = $this->getUserByRole($em, User::ROLE_USER);
$teamlead = $this->getUserByRole($em, User::ROLE_TEAMLEAD);
$user = $this->getUserByRole(User::ROLE_USER);
$teamlead = $this->getUserByRole(User::ROLE_TEAMLEAD);
$fixture = new TimesheetFixtures();
$fixture->setAmount(10);
$fixture->setUser($user);
$fixture->setStartDate('2017-05-01');
$this->importFixture($em, $fixture);
$this->importFixture($fixture);
$this->request($client, '/team/timesheet/1/edit');
@@ -250,11 +250,11 @@ class TimesheetTeamControllerTest extends ControllerBaseTest
$client = $this->getClientForAuthenticatedUser(User::ROLE_TEAMLEAD);
$em = $this->getEntityManager();
$user = $this->getUserByRole($em, User::ROLE_TEAMLEAD);
$user = $this->getUserByRole(User::ROLE_TEAMLEAD);
$fixture = new TimesheetFixtures();
$fixture->setAmount(10);
$fixture->setUser($user);
$this->importFixture($em, $fixture);
$this->importFixture($fixture);
$this->assertAccessIsGranted($client, '/team/timesheet/');
@@ -289,11 +289,11 @@ class TimesheetTeamControllerTest extends ControllerBaseTest
$client = $this->getClientForAuthenticatedUser(User::ROLE_SUPER_ADMIN);
$em = $this->getEntityManager();
$user = $this->getUserByRole($em, User::ROLE_TEAMLEAD);
$user = $this->getUserByRole(User::ROLE_TEAMLEAD);
$fixture = new TimesheetFixtures();
$fixture->setAmount(10);
$fixture->setUser($user);
$this->importFixture($em, $fixture);
$this->importFixture($fixture);
$this->assertAccessIsGranted($client, '/team/timesheet/');
@@ -320,7 +320,7 @@ class TimesheetTeamControllerTest extends ControllerBaseTest
]);
$this->assertTrue($client->getResponse()->isSuccessful());
$newUser = $this->getUserByRole($em, User::ROLE_USER);
$newUser = $this->getUserByRole(User::ROLE_USER);
$form = $client->getCrawler()->filter('form[name=timesheet_multi_update]')->form();
$client->submit($form, [
'timesheet_multi_update' => [

8
tests/Controller/UserControllerTest.php
View File

@@ -87,7 +87,7 @@ class UserControllerTest extends ControllerBaseTest
$expectedTabs = ['#settings', '#password', '#api-token', '#teams', '#roles'];
$tabs = $client->getCrawler()->filter('div.nav-tabs-custom ul.nav-tabs li');
$this->assertEquals(count($expectedTabs), $tabs->count());
$this->assertEquals(\count($expectedTabs), $tabs->count());
$foundTabs = [];
/** @var \DOMElement $tab */
foreach ($tabs->filter('a') as $tab) {
@@ -146,15 +146,15 @@ class UserControllerTest extends ControllerBaseTest
$client = $this->getClientForAuthenticatedUser(User::ROLE_SUPER_ADMIN);
$em = $this->getEntityManager();
$user = $this->getUserByRole($em, User::ROLE_USER);
$user = $this->getUserByRole(User::ROLE_USER);
$fixture = new TimesheetFixtures();
$fixture->setUser($user);
$fixture->setAmount(10);
$this->importFixture($client, $fixture);
$this->importFixture($fixture);
$timesheets = $em->getRepository(Timesheet::class)->findAll();
$this->assertEquals(10, count($timesheets));
$this->assertEquals(10, \count($timesheets));
$this->request($client, '/admin/user/' . $user->getId() . '/delete');
$this->assertTrue($client->getResponse()->isSuccessful());

2
tests/DataFixtures/ActivityFixtures.php
View File

@@ -123,7 +123,7 @@ final class ActivityFixtures extends Fixture
;
if (null !== $this->callback) {
call_user_func($this->callback, $activity);
\call_user_func($this->callback, $activity);
}
$manager->persist($activity);
}

2
tests/DataFixtures/CustomerFixtures.php
View File

@@ -89,7 +89,7 @@ final class CustomerFixtures extends Fixture
;
if (null !== $this->callback) {
call_user_func($this->callback, $customer);
\call_user_func($this->callback, $customer);
}
$manager->persist($customer);
}

2
tests/DataFixtures/ProjectFixtures.php
View File

@@ -106,7 +106,7 @@ final class ProjectFixtures extends Fixture
;
if (null !== $this->callback) {
call_user_func($this->callback, $project);
\call_user_func($this->callback, $project);
}
$manager->persist($project);
}

2
tests/DataFixtures/TagFixtures.php
View File

@@ -68,7 +68,7 @@ final class TagFixtures extends Fixture
$tag = $this->createTagEntry($tagName);
if (null !== $this->callback) {
call_user_func($this->callback, $tag);
\call_user_func($this->callback, $tag);
}
$manager->persist($tag);
}

6
tests/DataFixtures/TeamFixtures.php
View File

@@ -101,7 +101,7 @@ final class TeamFixtures extends Fixture
$lead = null;
while (null === $lead) {
$tmp = $user[array_rand($user)];
if (!in_array($tmp, $this->skipUser)) {
if (!\in_array($tmp, $this->skipUser)) {
$lead = $tmp;
}
}
@@ -116,7 +116,7 @@ final class TeamFixtures extends Fixture
$userToAdd = null;
while (null === $userToAdd) {
$tmp = $user[array_rand($user)];
if (!in_array($tmp, $this->skipUser)) {
if (!\in_array($tmp, $this->skipUser)) {
$userToAdd = $tmp;
}
}
@@ -128,7 +128,7 @@ final class TeamFixtures extends Fixture
}
if (null !== $this->callback) {
call_user_func($this->callback, $team);
\call_user_func($this->callback, $team);
}
$manager->persist($team);
}

8
tests/DataFixtures/TimesheetFixtures.php
View File

@@ -241,7 +241,7 @@ final class TimesheetFixtures extends Fixture
);
if (null !== $this->callback) {
call_user_func($this->callback, $timesheet);
\call_user_func($this->callback, $timesheet);
}
$manager->persist($timesheet);
}
@@ -267,7 +267,7 @@ final class TimesheetFixtures extends Fixture
);
if (null !== $this->callback) {
call_user_func($this->callback, $timesheet);
\call_user_func($this->callback, $timesheet);
}
$manager->persist($timesheet);
}
@@ -279,7 +279,7 @@ final class TimesheetFixtures extends Fixture
{
if (true === $this->useTags) {
$tagObject = new Tag();
$tagObject->setName($this->tags[($cnt % count($this->tags))]);
$tagObject->setName($this->tags[($cnt % \count($this->tags))]);
return [$tagObject];
}
@@ -355,7 +355,7 @@ final class TimesheetFixtures extends Fixture
->setRate($rate)
->setBegin($start);
if (count($tagArray) > 0) {
if (\count($tagArray) > 0) {
foreach ($tagArray as $item) {
$entry->addTag($item);
}

2
tests/Doctrine/SqliteSessionInitSubscriberTest.php
View File

@@ -26,7 +26,7 @@ class SqliteSessionInitSubscriberTest extends TestCase
{
$sut = new SqliteSessionInitSubscriber();
$events = $sut->getSubscribedEvents();
$this->assertTrue(in_array(Events::postConnect, $events));
$this->assertTrue(\in_array(Events::postConnect, $events));
}
public function testPostConnectWithSqlite()

2
tests/Doctrine/TimesheetSubscriberTest.php
View File

@@ -22,6 +22,6 @@ class TimesheetSubscriberTest extends TestCase
{
$sut = new TimesheetSubscriber([]);
$events = $sut->getSubscribedEvents();
$this->assertTrue(in_array(Events::onFlush, $events));
$this->assertTrue(\in_array(Events::onFlush, $events));
}
}

8
tests/Entity/EntityValidationTestTrait.php
View File

@@ -27,11 +27,11 @@ trait EntityValidationTestTrait
$violations = $validator->validate($entity);
if (!is_array($fieldNames)) {
if (!\is_array($fieldNames)) {
$fieldNames = [$fieldNames];
}
$expected = count($fieldNames);
$expected = \count($fieldNames);
$actual = $violations->count();
$violatedFields = [];
@@ -39,11 +39,11 @@ trait EntityValidationTestTrait
foreach ($violations as $validation) {
$violatedFields[$validation->getPropertyPath()] = $validation->getPropertyPath();
}
$countViolations = count($violatedFields);
$countViolations = \count($violatedFields);
foreach ($fieldNames as $id => $propertyPath) {
$foundField = false;
if (in_array($propertyPath, $violatedFields)) {
if (\in_array($propertyPath, $violatedFields)) {
$foundField = true;
unset($violatedFields[$propertyPath]);
}

8
tests/Entity/UserTest.php
View File

@@ -184,13 +184,13 @@ class UserTest extends TestCase
{
$sut = new User();
$sut->setAlias('xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx');
self::assertEquals(60, strlen($sut->getAlias()));
self::assertEquals(60, \strlen($sut->getAlias()));
$sut->setAlias('xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxAAAAA');
self::assertEquals(60, strlen($sut->getAlias()));
self::assertEquals(60, \strlen($sut->getAlias()));
$sut->setTitle('xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx');
self::assertEquals(50, strlen($sut->getTitle()));
self::assertEquals(50, \strlen($sut->getTitle()));
$sut->setTitle('xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxAAAAAA');
self::assertEquals(50, strlen($sut->getTitle()));
self::assertEquals(50, \strlen($sut->getTitle()));
}
public function testPreferencesCollectionIsCreatedOnBrokenUser()

10
tests/EventSubscriber/DashboardSubscriberTest.php
View File

@@ -37,9 +37,9 @@ class DashboardSubscriberTest extends TestCase
$sut = $this->getSubscriber(false, 13, 28, 37, 5);
$event = new DashboardEvent(new User());
$this->assertEquals(0, count($event->getSections()));
$this->assertEquals(0, \count($event->getSections()));
$sut->onDashboardEvent($event);
$this->assertEquals(0, count($event->getSections()));
$this->assertEquals(0, \count($event->getSections()));
}
public function testWithAdminUser()
@@ -47,14 +47,14 @@ class DashboardSubscriberTest extends TestCase
$sut = $this->getSubscriber(true, 13, 28, 37, 5);
$event = new DashboardEvent(new User());
$this->assertEquals(0, count($event->getSections()));
$this->assertEquals(0, \count($event->getSections()));
$sut->onDashboardEvent($event);
$sections = $event->getSections();
$widgets = $sections[0]->getWidgets();
$this->assertEquals(1, count($sections));
$this->assertEquals(4, count($widgets));
$this->assertEquals(1, \count($sections));
$this->assertEquals(4, \count($widgets));
$this->assertEquals('stats.userTotal', $widgets[0]->getTitle());
$this->assertEquals(13, $widgets[0]->getData());

4
tests/Export/Renderer/CsvRendererTest.php
View File

@@ -101,9 +101,9 @@ class CsvRendererTest extends AbstractRendererTest
20 => 'activity-bar',
];
self::assertEquals(7, count($all));
self::assertEquals(7, \count($all));
self::assertEquals($expected, $all[5]);
self::assertEquals(count($expected), count($all[0]));
self::assertEquals(\count($expected), \count($all[0]));
self::assertEquals('foo', $all[4][12]);
}
}

4
tests/Export/ServiceExportTest.php
View File

@@ -40,7 +40,7 @@ class ServiceExportTest extends TestCase
$renderer = new HtmlRenderer($this->createMock(Environment::class), new EventDispatcher(), $this->createMock(ProjectRepository::class));
$sut->addRenderer($renderer);
self::assertEquals(1, count($sut->getRenderer()));
self::assertEquals(1, \count($sut->getRenderer()));
self::assertSame($renderer, $sut->getRendererById('html'));
}
@@ -51,7 +51,7 @@ class ServiceExportTest extends TestCase
$exporter = new HtmlExporter($this->createMock(Environment::class), new EventDispatcher());
$sut->addTimesheetExporter($exporter);
self::assertEquals(1, count($sut->getTimesheetExporter()));
self::assertEquals(1, \count($sut->getTimesheetExporter()));
self::assertSame($exporter, $sut->getTimesheetExporterById('print'));
}
}

4
tests/Export/Timesheet/CsvRendererTest.php
View File

@@ -98,9 +98,9 @@ class CsvRendererTest extends AbstractRendererTest
20 => 'activity-bar',
];
self::assertEquals(7, count($all));
self::assertEquals(7, \count($all));
self::assertEquals($expected, $all[5]);
self::assertEquals(count($expected), count($all[0]));
self::assertEquals(\count($expected), \count($all[0]));
self::assertEquals('foo', $all[4][12]);
}
}

4
tests/Invoice/Calculator/AbstractCalculatorTest.php
View File

@@ -34,7 +34,7 @@ abstract class AbstractCalculatorTest extends TestCase
$this->assertEquals(0, $sut->getVat());
$this->assertEquals(0, $sut->getSubtotal());
$this->assertEquals(0, $sut->getTimeWorked());
$this->assertEquals(0, count($sut->getEntries()));
$this->assertEquals(0, \count($sut->getEntries()));
$this->assertEquals(0, $sut->getTax());
}
@@ -95,7 +95,7 @@ abstract class AbstractCalculatorTest extends TestCase
$model->setQuery($query);
$sut->setModel($model);
$this->assertEquals(1, count($sut->getEntries()));
$this->assertEquals(1, \count($sut->getEntries()));
/** @var Timesheet $result */
$result = $sut->getEntries()[0];

2
tests/Invoice/Calculator/ActivityInvoiceCalculatorTest.php
View File

@@ -149,7 +149,7 @@ class ActivityInvoiceCalculatorTest extends AbstractCalculatorTest
$this->assertEquals('EUR', $model->getCurrency());
$this->assertEquals(2521.12, $sut->getSubtotal());
$this->assertEquals(6600, $sut->getTimeWorked());
$this->assertEquals(5, count($sut->getEntries()));
$this->assertEquals(5, \count($sut->getEntries()));
$entries = $sut->getEntries();
$this->assertEquals(404.38, $entries[0]->getRate());

2
tests/Invoice/Calculator/DateInvoiceCalculatorTest.php
View File

@@ -122,7 +122,7 @@ class DateInvoiceCalculatorTest extends AbstractCalculatorTest
$this->assertEquals('EUR', $model->getCurrency());
$this->assertEquals(2521.12, $sut->getSubtotal());
$this->assertEquals(6600, $sut->getTimeWorked());
$this->assertEquals(3, count($sut->getEntries()));
$this->assertEquals(3, \count($sut->getEntries()));
$entries = $sut->getEntries();
self::assertCount(3, $entries);

2
tests/Invoice/Calculator/ProjectInvoiceCalculatorTest.php
View File

@@ -122,7 +122,7 @@ class ProjectInvoiceCalculatorTest extends AbstractCalculatorTest
$this->assertEquals('EUR', $model->getCurrency());
$this->assertEquals(2521.12, $sut->getSubtotal());
$this->assertEquals(6600, $sut->getTimeWorked());
$this->assertEquals(3, count($sut->getEntries()));
$this->assertEquals(3, \count($sut->getEntries()));
$entries = $sut->getEntries();
self::assertCount(3, $entries);

6
tests/Invoice/Calculator/ShortInvoiceCalculatorTest.php
View File

@@ -102,7 +102,7 @@ class ShortInvoiceCalculatorTest extends AbstractCalculatorTest
$this->assertEquals('EUR', $model->getCurrency());
$this->assertEquals(472.5, $sut->getSubtotal());
$this->assertEquals(5800, $sut->getTimeWorked());
$this->assertEquals(1, count($sut->getEntries()));
$this->assertEquals(1, \count($sut->getEntries()));
/** @var InvoiceItem $result */
$result = $sut->getEntries()[0];
@@ -183,7 +183,7 @@ class ShortInvoiceCalculatorTest extends AbstractCalculatorTest
$this->assertEquals('EUR', $model->getCurrency());
$this->assertEquals(488.38, $sut->getSubtotal());
$this->assertEquals(5800, $sut->getTimeWorked());
$this->assertEquals(1, count($sut->getEntries()));
$this->assertEquals(1, \count($sut->getEntries()));
/** @var InvoiceItem $result */
$result = $sut->getEntries()[0];
@@ -262,7 +262,7 @@ class ShortInvoiceCalculatorTest extends AbstractCalculatorTest
$this->assertEquals('EUR', $model->getCurrency());
$this->assertEquals(488.38, $sut->getSubtotal());
$this->assertEquals(5400, $sut->getTimeWorked());
$this->assertEquals(1, count($sut->getEntries()));
$this->assertEquals(1, \count($sut->getEntries()));
/** @var InvoiceItem $result */
$result = $sut->getEntries()[0];

2
tests/Invoice/Calculator/UserInvoiceCalculatorTest.php
View File

@@ -120,7 +120,7 @@ class UserInvoiceCalculatorTest extends AbstractCalculatorTest
$this->assertEquals('EUR', $model->getCurrency());
$this->assertEquals(2521.12, $sut->getSubtotal());
$this->assertEquals(6600, $sut->getTimeWorked());
$this->assertEquals(3, count($sut->getEntries()));
$this->assertEquals(3, \count($sut->getEntries()));
$entries = $sut->getEntries();
$this->assertEquals(404.38, $entries[0]->getRate());

2
tests/Invoice/Hydrator/InvoiceItemDefaultHydratorTest.php
View File

@@ -91,6 +91,6 @@ class InvoiceItemDefaultHydratorTest extends TestCase
sort($givenKeys);
$this->assertEquals($expectedKeys, $givenKeys);
$this->assertEquals(count($keys), count($givenKeys));
$this->assertEquals(\count($keys), \count($givenKeys));
}
}

3
tests/Invoice/NumberGenerator/ConfigurableNumberGeneratorTest.php
View File

@@ -68,8 +68,10 @@ class ConfigurableNumberGeneratorTest extends TestCase
['{cd}', '2', $invoiceDate],
// number formatting (not testing the lower case versions, as the tests might break depending on the date)
['{date,10}', '0000' . $invoiceDate->format('ymd'), $invoiceDate],
['{date,a}', $invoiceDate->format('ymd'), $invoiceDate], // invalid formatter length
['{Y,6}', '00' . $invoiceDate->format('Y'), $invoiceDate],
['{M,3}', '0' . $invoiceDate->format('m'), $invoiceDate],
['{M,#}', $invoiceDate->format('m'), $invoiceDate], // invalid formatter length
['{D,3}', '0' . $invoiceDate->format('d'), $invoiceDate],
['{c,2}', '02', $invoiceDate],
['{cy,2}', '02', $invoiceDate],
@@ -81,6 +83,7 @@ class ConfigurableNumberGeneratorTest extends TestCase
['{Y}-{cy}/{m}', $invoiceDate->format('Y') . '-2/' . $invoiceDate->format('n'), $invoiceDate],
['{Y}-{cy}/{m}', $invoiceDate->format('Y') . '-2/' . $invoiceDate->format('n'), $invoiceDate],
['{Y,5}/{cy,5}', '0' . $invoiceDate->format('Y') . '/00002', $invoiceDate],
['{Y,!}/{cy,o}', $invoiceDate->format('Y') . '/2', $invoiceDate], // invalid formatter length
];
}

6
tests/Invoice/Renderer/DebugRendererTest.php
View File

@@ -58,9 +58,9 @@ class DebugRendererTest extends TestCase
$response = $sut->render($document, $model);
$data = json_decode($response->getContent(), true);
$this->assertModelStructure($data['model'], count($model->getQuery()->getProjects()), count($model->getQuery()->getActivities()));
$this->assertModelStructure($data['model'], \count($model->getQuery()->getProjects()), \count($model->getQuery()->getActivities()));
$rows = $data['entries'];
$this->assertEquals($expectedRows, count($rows));
$this->assertEquals($expectedRows, \count($rows));
$i = 0;
foreach ($rows as $row) {
@@ -246,6 +246,6 @@ class DebugRendererTest extends TestCase
sort($givenKeys);
$this->assertEquals($expectedKeys, $givenKeys);
$this->assertEquals(count($keys), count($givenKeys));
$this->assertEquals(\count($keys), \count($givenKeys));
}
}

2
tests/Invoice/Renderer/TextRendererTest.php
View File

@@ -74,6 +74,6 @@ class TextRendererTest extends KernelTestCase
self::assertStringContainsString(sprintf("%s:\n %s", $key, explode("\n", $value)[0]), $content);
}
}
self::assertEquals(count($model->getCalculator()->getEntries()), substr_count($content, PHP_EOL . '---' . PHP_EOL));
self::assertEquals(\count($model->getCalculator()->getEntries()), substr_count($content, PHP_EOL . '---' . PHP_EOL));
}
}

2
tests/Invoice/Renderer/XmlRendererTest.php
View File

@@ -78,6 +78,6 @@ class XmlRendererTest extends KernelTestCase
}
self::assertEquals((string) $expected[$name], (string) $element);
}
self::assertEquals(count($model->getCalculator()->getEntries()), count($xml->items->item));
self::assertEquals(\count($model->getCalculator()->getEntries()), \count($xml->items->item));
}
}

6
tests/Invoice/ServiceInvoiceTest.php
View File

@@ -88,12 +88,12 @@ class ServiceInvoiceTest extends TestCase
)
);
$this->assertEquals(1, count($sut->getCalculator()));
$this->assertEquals(1, \count($sut->getCalculator()));
$this->assertInstanceOf(DefaultCalculator::class, $sut->getCalculatorByName('default'));
$this->assertEquals(1, count($sut->getNumberGenerator()));
$this->assertEquals(1, \count($sut->getNumberGenerator()));
$this->assertInstanceOf(DateNumberGenerator::class, $sut->getNumberGeneratorByName('date'));
$this->assertEquals(1, count($sut->getRenderer()));
$this->assertEquals(1, \count($sut->getRenderer()));
}
}

19
tests/KernelTestTrait.php
View File

@@ -14,10 +14,8 @@ use App\Entity\User;
use Doctrine\Bundle\FixturesBundle\Fixture;
use Doctrine\Common\DataFixtures\Executor\ORMExecutor;
use Doctrine\Common\DataFixtures\Loader;
use Doctrine\ORM\EntityManager;
use Doctrine\ORM\EntityManagerInterface;
use Symfony\Bundle\FrameworkBundle\Test\KernelTestCase;
use Symfony\Component\HttpKernel\HttpKernelBrowser;
/**
* A trait to be used in all tests that extend the KernelTestCase.
@@ -33,19 +31,9 @@ trait KernelTestTrait
return $this::$container->get('doctrine.orm.entity_manager');
}
/**
* @param HttpKernelBrowser|EntityManager|KernelTestCase $client
* @param Fixture $fixture
*/
protected function importFixture($client, Fixture $fixture)
protected function importFixture(Fixture $fixture)
{
if ($client instanceof EntityManager) {
$em = $client;
} elseif ($this instanceof KernelTestCase) {
$em = $this::$container->get('doctrine.orm.entity_manager');
} else {
throw new \InvalidArgumentException('Need an EntityManager to import fixtures');
}
$em = $this::$container->get('doctrine.orm.entity_manager');
$loader = new Loader();
$loader->addFixture($fixture);
@@ -60,11 +48,10 @@ trait KernelTestTrait
}
/**
* @param EntityManager $em
* @param string $role
* @return User|null
*/
protected function getUserByRole(EntityManager $em, string $role = User::ROLE_USER)
protected function getUserByRole(string $role = User::ROLE_USER)
{
$name = null;

4
tests/Model/Statistic/YearTest.php
View File

@@ -34,11 +34,11 @@ class YearTest extends TestCase
$sut->setMonth(new Month('01'));
$sut->setMonth(new Month('02'));
$sut->setMonth(new Month('03'));
$this->assertEquals(3, count($sut->getMonths()));
$this->assertEquals(3, \count($sut->getMonths()));
$sut->setMonth(new Month('01'));
$this->assertEquals(3, count($sut->getMonths()));
$this->assertEquals(3, \count($sut->getMonths()));
$this->assertInstanceOf(Month::class, $sut->getMonth(1));
$this->assertInstanceOf(Month::class, $sut->getMonth(2));

2
tests/Plugin/PluginManagerTest.php
View File

@@ -50,7 +50,7 @@ class PluginManagerTest extends TestCase
$sut->addPlugin(new TestPlugin());
// make sure a plugin with the same name is not added twice, the first one wins!
$this->assertEquals(2, count($sut->getPlugins()));
$this->assertEquals(2, \count($sut->getPlugins()));
$foo = $sut->getPlugin('foo');
$this->assertInstanceOf(Plugin::class, $foo);

4
tests/Repository/InvoiceDocumentRepositoryTest.php
View File

@@ -44,10 +44,10 @@ class InvoiceDocumentRepositoryTest extends TestCase
{
$sut = new InvoiceDocumentRepository(self::$defaultDirectories);
$all = $sut->findAll();
$this->assertEquals(count(self::$defaultDocuments), count($all));
$this->assertEquals(\count(self::$defaultDocuments), \count($all));
foreach ($all as $document) {
$this->assertTrue(in_array($document->getName(), self::$defaultDocuments));
$this->assertTrue(\in_array($document->getName(), self::$defaultDocuments));
}
foreach (self::$defaultDocuments as $filename) {

4
tests/Repository/Query/BaseFormTypeQueryTest.php
View File

@@ -44,11 +44,11 @@ abstract class BaseFormTypeQueryTest extends TestCase
self::assertEmpty($sut->getTeams());
self::assertInstanceOf(BaseFormTypeQuery::class, $sut->addTeam(new Team()));
self::assertEquals(1, count($sut->getTeams()));
self::assertEquals(1, \count($sut->getTeams()));
$team = new Team();
self::assertInstanceOf(BaseFormTypeQuery::class, $sut->addTeam($team));
self::assertEquals(1, count($sut->getTeams()));
self::assertEquals(1, \count($sut->getTeams()));
self::assertSame($team, $sut->getTeams()[0]);
}

4
tests/Repository/Query/BaseQueryTest.php
View File

@@ -105,7 +105,7 @@ class BaseQueryTest extends TestCase
self::assertEmpty($sut->getTeams());
self::assertInstanceOf(BaseQuery::class, $sut->addTeam(new Team()));
self::assertEquals(1, count($sut->getTeams()));
self::assertEquals(1, \count($sut->getTeams()));
$sut->setTeams(null);
self::assertEmpty($sut->getTeams());
@@ -114,7 +114,7 @@ class BaseQueryTest extends TestCase
$team = new Team();
self::assertInstanceOf(BaseQuery::class, $sut->setTeams([$team]));
self::assertEquals(1, count($sut->getTeams()));
self::assertEquals(1, \count($sut->getTeams()));
self::assertSame($team, $sut->getTeams()[0]);
}

10
tests/Repository/TagRepositoryTest.php
View File

@@ -25,7 +25,7 @@ class TagRepositoryTest extends AbstractRepositoryTest
$em = $this->getEntityManager();
$data = new TagFixtures();
$data->setTagArray(['Test', 'Travel', '#2018-001', '#2018-002', '#2018-003', '#2018-004', '#2018-005', 'Administration', 'Support', 'PR', '#2018-012']);
$this->importFixture($em, $data);
$this->importFixture($data);
}
public function testFindIds()
@@ -37,7 +37,7 @@ class TagRepositoryTest extends AbstractRepositoryTest
$result = $repository->findIdsByTagNameList('2018,Test');
$this->assertIsArray($result);
$this->assertNotEmpty($result);
$this->assertEquals(7, count($result));
$this->assertEquals(7, \count($result));
$this->assertEquals(1, $result[0]);
$this->assertEquals(3, $result[1]);
$this->assertEquals(4, $result[2]);
@@ -56,7 +56,7 @@ class TagRepositoryTest extends AbstractRepositoryTest
$result = $repository->findIdsByTagNameList('Simply');
$this->assertIsArray($result);
$this->assertEmpty($result);
$this->assertEquals(0, count($result));
$this->assertEquals(0, \count($result));
}
public function testFindAllTagNames()
@@ -68,7 +68,7 @@ class TagRepositoryTest extends AbstractRepositoryTest
$result = $repository->findAllTagNames('2018');
$this->assertIsArray($result);
$this->assertNotEmpty($result);
$this->assertEquals(6, count($result));
$this->assertEquals(6, \count($result));
$this->assertEquals('#2018-001', $result[0]);
$this->assertEquals('#2018-002', $result[1]);
$this->assertEquals('#2018-003', $result[2]);
@@ -86,6 +86,6 @@ class TagRepositoryTest extends AbstractRepositoryTest
$result = $repository->findAllTagNames('Nothing');
$this->assertIsArray($result);
$this->assertEmpty($result);
$this->assertEquals(0, count($result));
$this->assertEquals(0, \count($result));
}
}

18
tests/Repository/TimesheetRepositoryTest.php
View File

@@ -46,7 +46,7 @@ class TimesheetRepositoryTest extends AbstractRepositoryTest
public function testStoppedEntriesCannotBeStoppedAgain()
{
$em = $this->getEntityManager();
$user = $this->getUserByRole($em, User::ROLE_USER);
$user = $this->getUserByRole(User::ROLE_USER);
/** @var TimesheetRepository $repository */
$repository = $em->getRepository(Timesheet::class);
@@ -54,7 +54,7 @@ class TimesheetRepositoryTest extends AbstractRepositoryTest
$fixtures->setUser($user);
$fixtures->setAmount(1);
$this->importFixture($em, $fixtures);
$this->importFixture($fixtures);
$query = new TimesheetQuery();
$query->setUser($user);
@@ -75,14 +75,14 @@ class TimesheetRepositoryTest extends AbstractRepositoryTest
public function testStopRecording()
{
$em = $this->getEntityManager();
$user = $this->getUserByRole($em, User::ROLE_USER);
$user = $this->getUserByRole(User::ROLE_USER);
/** @var TimesheetRepository $repository */
$repository = $em->getRepository(Timesheet::class);
$fixtures = new TimesheetFixtures();
$fixtures->setUser($user);
$fixtures->setAmountRunning(1);
$this->importFixture($em, $fixtures);
$fixture = new TimesheetFixtures();
$fixture->setUser($user);
$fixture->setAmountRunning(1);
$this->importFixture($fixture);
$timesheet = $repository->find(1);
$this->assertInstanceOf(Timesheet::class, $timesheet);
@@ -103,7 +103,7 @@ class TimesheetRepositoryTest extends AbstractRepositoryTest
$projectRepository = $em->getRepository(Project::class);
$project = $projectRepository->find(1);
$user = $this->getUserByRole($em, User::ROLE_USER);
$user = $this->getUserByRole(User::ROLE_USER);
/** @var TimesheetRepository $repository */
$repository = $em->getRepository(Timesheet::class);
$timesheet = new Timesheet();
@@ -130,7 +130,7 @@ class TimesheetRepositoryTest extends AbstractRepositoryTest
$projectRepository = $em->getRepository(Project::class);
$project = $projectRepository->find(1);
$user = $this->getUserByRole($em, User::ROLE_USER);
$user = $this->getUserByRole(User::ROLE_USER);
/** @var TimesheetRepository $repository */
$repository = $em->getRepository(Timesheet::class);
$tagOne = new Tag();

2
tests/Saml/Logout/SamlLogoutHandlerTest.php
View File

@@ -43,7 +43,7 @@ class SamlLogoutHandlerTest extends TestCase
$auth->expects($this->once())->method('processSLO')->willThrowException(new Error('blub'));
$auth->expects($this->once())->method('getSLOurl')->willReturn('/logout');
$auth->expects($this->once())->method('logout')->willReturnCallback(function () {
$args = func_get_args();
$args = \func_get_args();
self::assertEquals(null, $args[0]);
self::assertEquals([], $args[1]);
self::assertEquals('tony', $args[2]);

2
tests/Saml/Security/SamlAuthenticationSuccessHandlerTest.php
View File

@@ -95,7 +95,7 @@ class SamlAuthenticationSuccessHandlerTest extends TestCase
$options = $reflection->getProperty('options');
$options->setAccessible(true);
$arr = $options->getValue($handler);
if (!is_array($arr) || !isset($arr[$name])) {
if (!\is_array($arr) || !isset($arr[$name])) {
return $default;
}

2
tests/Twig/AvatarExtensionTest.php
View File

@@ -41,7 +41,7 @@ class AvatarExtensionTest extends TestCase
$functions = ['avatar'];
$sut = $this->getSut(0);
$twigFunctions = $sut->getFunctions();
self::assertCount(count($functions), $twigFunctions);
self::assertCount(\count($functions), $twigFunctions);
$i = 0;
/** @var TwigFunction $filter */
foreach ($twigFunctions as $filter) {

2
tests/Twig/ConfigExtensionTest.php
View File

@@ -33,7 +33,7 @@ class ConfigExtensionTest extends TestCase
$functions = ['theme_config'];
$sut = $this->getSut([], []);
$twigFunctions = $sut->getFunctions();
self::assertCount(count($functions), $twigFunctions);
self::assertCount(\count($functions), $twigFunctions);
$i = 0;
/** @var TwigFunction $filter */
foreach ($twigFunctions as $filter) {

2
tests/Twig/DatatableExtensionsTest.php
View File

@@ -35,7 +35,7 @@ class DatatableExtensionsTest extends TestCase
$functions = ['is_visible_column', 'is_datatable_configured'];
$sut = $this->getSut('de');
$twigFunctions = $sut->getFunctions();
$this->assertCount(count($functions), $twigFunctions);
$this->assertCount(\count($functions), $twigFunctions);
$i = 0;
/** @var TwigFunction $function */
foreach ($twigFunctions as $function) {

4
tests/Twig/DateExtensionsTest.php
View File

@@ -45,7 +45,7 @@ class DateExtensionsTest extends TestCase
$filters = ['month_name', 'date_short', 'date_time', 'date_full', 'date_format', 'time', 'hour24'];
$sut = $this->getSut('de', []);
$twigFilters = $sut->getFilters();
$this->assertCount(count($filters), $twigFilters);
$this->assertCount(\count($filters), $twigFilters);
$i = 0;
foreach ($twigFilters as $filter) {
$this->assertInstanceOf(TwigFilter::class, $filter);
@@ -58,7 +58,7 @@ class DateExtensionsTest extends TestCase
$functions = ['get_format_duration'];
$sut = $this->getSut('de', []);
$twigFunctions = $sut->getFunctions();
$this->assertCount(count($functions), $twigFunctions);
$this->assertCount(\count($functions), $twigFunctions);
$i = 0;
/** @var TwigFunction $filter */
foreach ($twigFunctions as $filter) {

2
tests/Twig/EncoreExtensionTest.php
View File

@@ -42,7 +42,7 @@ class EncoreExtensionTest extends TestCase
$functions = ['encore_entry_css_source'];
$sut = $this->getSut();
$twigFunctions = $sut->getFunctions();
self::assertCount(count($functions), $twigFunctions);
self::assertCount(\count($functions), $twigFunctions);
$i = 0;
/** @var TwigFunction $filter */
foreach ($twigFunctions as $filter) {

4
tests/Twig/ExtensionsTest.php
View File

@@ -53,7 +53,7 @@ class ExtensionsTest extends TestCase
$filters = ['duration', 'duration_decimal', 'money', 'currency', 'country', 'language', 'amount', 'docu_link', 'multiline_indent'];
$sut = $this->getSut($this->localeDe);
$twigFilters = $sut->getFilters();
$this->assertCount(count($filters), $twigFilters);
$this->assertCount(\count($filters), $twigFilters);
$i = 0;
/** @var TwigFilter $filter */
foreach ($twigFilters as $filter) {
@@ -67,7 +67,7 @@ class ExtensionsTest extends TestCase
$functions = ['locales', 'class_name'];
$sut = $this->getSut($this->localeDe);
$twigFunctions = $sut->getFunctions();
$this->assertCount(count($functions), $twigFunctions);
$this->assertCount(\count($functions), $twigFunctions);
$i = 0;
/** @var TwigFunction $filter */
foreach ($twigFunctions as $filter) {

2
tests/Twig/IconExtensionTest.php
View File

@@ -23,7 +23,7 @@ class IconExtensionTest extends TestCase
$filters = ['icon'];
$sut = new IconExtension();
$twigFilters = $sut->getFilters();
$this->assertCount(count($filters), $twigFilters);
$this->assertCount(\count($filters), $twigFilters);
$i = 0;
/** @var TwigFilter $filter */
foreach ($twigFilters as $filter) {

2
tests/Twig/PaginationExtensionTest.php
View File

@@ -50,7 +50,7 @@ class PaginationExtensionTest extends TestCase
$functions = ['pagerfanta', 'pagination'];
$sut = $this->getSut();
$twigFunctions = $sut->getFunctions();
self::assertCount(count($functions), $twigFunctions);
self::assertCount(\count($functions), $twigFunctions);
$i = 0;
/** @var TwigFunction $filter */
foreach ($twigFunctions as $filter) {

2
tests/Twig/TitleExtensionTest.php
View File

@@ -43,7 +43,7 @@ class TitleExtensionTest extends TestCase
$functions = ['get_title'];
$sut = $this->getSut();
$twigFunctions = $sut->getFunctions();
$this->assertCount(count($functions), $twigFunctions);
$this->assertCount(\count($functions), $twigFunctions);
$i = 0;
/** @var TwigFunction $function */
foreach ($twigFunctions as $function) {

2
tests/Twig/WidgetExtensionTest.php
View File

@@ -43,7 +43,7 @@ class WidgetExtensionTest extends TestCase
$functions = ['render_widget'];
$sut = $this->getSut();
$twigFunctions = $sut->getFunctions();
$this->assertCount(count($functions), $twigFunctions);
$this->assertCount(\count($functions), $twigFunctions);
$i = 0;
/** @var TwigFunction $function */
foreach ($twigFunctions as $function) {

2
tests/Validator/Constraints/DateTimeFormatValidatorTest.php
View File

@@ -76,7 +76,7 @@ class DateTimeFormatValidatorTest extends ConstraintValidatorTestCase
$this->validator->validate($input, $constraint);
$expectedFormat = is_string($input) ? '"' . $input . '"' : $input;
$expectedFormat = \is_string($input) ? '"' . $input . '"' : $input;
$this->buildViolation('The given value is not a valid datetime format.')
->setCode(DateTimeFormat::INVALID_FORMAT)

2
tests/Validator/Constraints/DurationValidatorTest.php
View File

@@ -92,7 +92,7 @@ class DurationValidatorTest extends ConstraintValidatorTestCase
$this->validator->validate($input, $constraint);
$expectedFormat = is_string($input) ? '"' . $input . '"' : $input;
$expectedFormat = \is_string($input) ? '"' . $input . '"' : $input;
$this->buildViolation('myMessage')
->setParameter('{{ value }}', $expectedFormat)

2
tests/Validator/Constraints/RoleValidatorTest.php
View File

@@ -92,7 +92,7 @@ class RoleValidatorTest extends ConstraintValidatorTestCase
$this->validator->validate($role, $constraint);
$expectedFormat = is_string($role) ? '"' . $role . '"' : $role;
$expectedFormat = \is_string($role) ? '"' . $role . '"' : $role;
$this->buildViolation('myMessage')
->setParameter('{{ value }}', $expectedFormat)

2
tests/Widget/Renderer/SimpleWidgetRendererTest.php
View File

@@ -41,7 +41,7 @@ class SimpleWidgetRendererTest extends TestCase
$sut = new SimpleWidgetRenderer($twig);
$data = uniqid(get_class($widget));
$data = uniqid(\get_class($widget));
$widget->setData($data);
$result = $sut->render($widget, ['color' => $color]);
$result = json_decode($result, true);