jjsm01/kimai2
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

Code improvements (#1649)

Browse Source 
* use global namespace for faster lookups
* phpstan level 5
This commit is contained in:
Kevin Papst
2020-04-19 14:37:14 +02:00
committed by GitHub
parent 7b25e9acaf
commit 0f3fa8fdbe
183 changed files with 604 additions and 574 deletions
Download Patch File Download Diff File Expand all files Collapse all files

28
tests/Controller/ExportControllerTest.php
View File

@@ -45,8 +45,8 @@ class ExportControllerTest extends ControllerBaseTest
$client = $this->getClientForAuthenticatedUser(User::ROLE_TEAMLEAD);
$em = $this->getEntityManager();
$teamlead = $this->getUserByRole($em, User::ROLE_TEAMLEAD);
$user = $this->getUserByRole($em, User::ROLE_USER);
$teamlead = $this->getUserByRole(User::ROLE_TEAMLEAD);
$user = $this->getUserByRole(User::ROLE_USER);
/** @var Team $team */
$team = new Team();
$team->setName('fooo');
@@ -57,7 +57,7 @@ class ExportControllerTest extends ControllerBaseTest
$em->persist($teamlead);
$em->flush();
$user = $this->getUserByRole($em, User::ROLE_USER);
$user = $this->getUserByRole(User::ROLE_USER);
$begin = new \DateTime('first day of this month');
$fixture = new TimesheetFixtures();
@@ -70,9 +70,9 @@ class ExportControllerTest extends ControllerBaseTest
$em->persist($team);
})
;
$this->importFixture($client, $fixture);
$this->importFixture($fixture);
$teamlead = $this->getUserByRole($em, User::ROLE_TEAMLEAD);
$teamlead = $this->getUserByRole(User::ROLE_TEAMLEAD);
$fixture = new TimesheetFixtures();
$fixture
@@ -80,7 +80,7 @@ class ExportControllerTest extends ControllerBaseTest
->setAmount(2)
->setStartDate($begin)
;
$this->importFixture($client, $fixture);
$this->importFixture($fixture);
$em->flush();
$this->request($client, '/export/?preview=');
@@ -94,7 +94,7 @@ class ExportControllerTest extends ControllerBaseTest
// assert export type buttons are available
$expected = ['csv', 'default.html.twig', 'default-budget.pdf.twig', 'default-internal.pdf.twig', 'default.pdf.twig', 'xlsx'];
$node = $client->getCrawler()->filter('#export-buttons .startExportBtn');
$this->assertEquals(count($expected), $node->count());
$this->assertEquals(\count($expected), $node->count());
/** @var \DOMElement $button */
foreach ($node->getIterator() as $button) {
$type = $button->getAttribute('data-type');
@@ -108,7 +108,7 @@ class ExportControllerTest extends ControllerBaseTest
$em = $this->getEntityManager();
$begin = new \DateTime('first day of this month');
$user = $this->getUserByRole($em, User::ROLE_USER);
$user = $this->getUserByRole(User::ROLE_USER);
// these should be ignored, becuase teamlead and user do NOT share a team!
$fixture = new TimesheetFixtures();
@@ -117,7 +117,7 @@ class ExportControllerTest extends ControllerBaseTest
->setAmount(20)
->setStartDate($begin)
;
$this->importFixture($client, $fixture);
$this->importFixture($fixture);
$this->request($client, '/export/?preview=');
$this->assertTrue($client->getResponse()->isSuccessful());
@@ -125,7 +125,7 @@ class ExportControllerTest extends ControllerBaseTest
// make sure all existing records are displayed
$this->assertHasNoEntriesWithFilter($client);
$teamlead = $this->getUserByRole($em, User::ROLE_TEAMLEAD);
$teamlead = $this->getUserByRole(User::ROLE_TEAMLEAD);
$fixture = new TimesheetFixtures();
$fixture
@@ -133,7 +133,7 @@ class ExportControllerTest extends ControllerBaseTest
->setAmount(2)
->setStartDate($begin)
;
$this->importFixture($client, $fixture);
$this->importFixture($fixture);
$this->request($client, '/export/?preview=');
$this->assertTrue($client->getResponse()->isSuccessful());
@@ -146,7 +146,7 @@ class ExportControllerTest extends ControllerBaseTest
// assert export type buttons are available
$expected = ['csv', 'default.html.twig', 'default-budget.pdf.twig', 'default-internal.pdf.twig', 'default.pdf.twig', 'xlsx'];
$node = $client->getCrawler()->filter('#export-buttons .startExportBtn');
$this->assertEquals(count($expected), $node->count());
$this->assertEquals(\count($expected), $node->count());
/** @var \DOMElement $button */
foreach ($node->getIterator() as $button) {
$type = $button->getAttribute('data-type');
@@ -196,11 +196,11 @@ class ExportControllerTest extends ControllerBaseTest
$begin = new \DateTime('first day of this month');
$fixture = new TimesheetFixtures();
$fixture
->setUser($this->getUserByRole($em, User::ROLE_USER))
->setUser($this->getUserByRole(User::ROLE_USER))
->setAmount(20)
->setStartDate($begin)
;
$this->importFixture($client, $fixture);
$this->importFixture($fixture);
$this->request($client, '/export/');
$this->assertTrue($client->getResponse()->isSuccessful());