Code improvements (#1649)

* use global namespace for faster lookups
* phpstan level 5
This commit is contained in:
Kevin Papst
2020-04-19 14:37:14 +02:00
committed by GitHub
parent 7b25e9acaf
commit 0f3fa8fdbe
183 changed files with 604 additions and 574 deletions

View File

@@ -35,14 +35,14 @@ class SystemConfigurationControllerTest extends ControllerBaseTest
$expectedForms = $this->getTestDataForms();
$result = $client->getCrawler()->filter('section.content div.box.box-primary');
$this->assertEquals(count($expectedForms), count($result));
$this->assertEquals(\count($expectedForms), \count($result));
$result = $client->getCrawler()->filter('section.content div.box.box-primary form');
$this->assertEquals(count($expectedForms), count($result));
$this->assertEquals(\count($expectedForms), \count($result));
foreach ($expectedForms as $formConfig) {
$result = $client->getCrawler()->filter($formConfig[0]);
$this->assertEquals(1, count($result));
$this->assertEquals(1, \count($result));
$form = $result->form();
$this->assertStringEndsWith($formConfig[1], $form->getUri());
$this->assertEquals('POST', $form->getMethod());
@@ -57,13 +57,13 @@ class SystemConfigurationControllerTest extends ControllerBaseTest
$expectedForms = $this->getTestDataForms();
$result = $client->getCrawler()->filter('section.content div.box.box-primary');
$this->assertEquals(1, count($result));
$this->assertEquals(1, \count($result));
$result = $client->getCrawler()->filter('section.content div.box.box-primary form');
$this->assertEquals(1, count($result));
$this->assertEquals(1, \count($result));
$result = $client->getCrawler()->filter('form[name=system_configuration_form_timesheet]');
$this->assertEquals(1, count($result));
$this->assertEquals(1, \count($result));
$form = $result->form();
$this->assertEquals('POST', $form->getMethod());
}