jjsm01/kimai2
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

Code improvements (#1649)

Browse Source 
* use global namespace for faster lookups
* phpstan level 5
This commit is contained in:
Kevin Papst
2020-04-19 14:37:14 +02:00
committed by GitHub
parent 7b25e9acaf
commit 0f3fa8fdbe
183 changed files with 604 additions and 574 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
tests/Entity/EntityValidationTestTrait.php
View File

@@ -27,11 +27,11 @@ trait EntityValidationTestTrait
$violations = $validator->validate($entity);
if (!is_array($fieldNames)) {
if (!\is_array($fieldNames)) {
$fieldNames = [$fieldNames];
}
$expected = count($fieldNames);
$expected = \count($fieldNames);
$actual = $violations->count();
$violatedFields = [];
@@ -39,11 +39,11 @@ trait EntityValidationTestTrait
foreach ($violations as $validation) {
$violatedFields[$validation->getPropertyPath()] = $validation->getPropertyPath();
}
$countViolations = count($violatedFields);
$countViolations = \count($violatedFields);
foreach ($fieldNames as $id => $propertyPath) {
$foundField = false;
if (in_array($propertyPath, $violatedFields)) {
if (\in_array($propertyPath, $violatedFields)) {
$foundField = true;
unset($violatedFields[$propertyPath]);
}