Code improvements (#1649)

* use global namespace for faster lookups
* phpstan level 5
This commit is contained in:
Kevin Papst
2020-04-19 14:37:14 +02:00
committed by GitHub
parent 7b25e9acaf
commit 0f3fa8fdbe
183 changed files with 604 additions and 574 deletions

View File

@@ -101,9 +101,9 @@ class CsvRendererTest extends AbstractRendererTest
20 => 'activity-bar',
];
self::assertEquals(7, count($all));
self::assertEquals(7, \count($all));
self::assertEquals($expected, $all[5]);
self::assertEquals(count($expected), count($all[0]));
self::assertEquals(\count($expected), \count($all[0]));
self::assertEquals('foo', $all[4][12]);
}
}

View File

@@ -40,7 +40,7 @@ class ServiceExportTest extends TestCase
$renderer = new HtmlRenderer($this->createMock(Environment::class), new EventDispatcher(), $this->createMock(ProjectRepository::class));
$sut->addRenderer($renderer);
self::assertEquals(1, count($sut->getRenderer()));
self::assertEquals(1, \count($sut->getRenderer()));
self::assertSame($renderer, $sut->getRendererById('html'));
}
@@ -51,7 +51,7 @@ class ServiceExportTest extends TestCase
$exporter = new HtmlExporter($this->createMock(Environment::class), new EventDispatcher());
$sut->addTimesheetExporter($exporter);
self::assertEquals(1, count($sut->getTimesheetExporter()));
self::assertEquals(1, \count($sut->getTimesheetExporter()));
self::assertSame($exporter, $sut->getTimesheetExporterById('print'));
}
}

View File

@@ -98,9 +98,9 @@ class CsvRendererTest extends AbstractRendererTest
20 => 'activity-bar',
];
self::assertEquals(7, count($all));
self::assertEquals(7, \count($all));
self::assertEquals($expected, $all[5]);
self::assertEquals(count($expected), count($all[0]));
self::assertEquals(\count($expected), \count($all[0]));
self::assertEquals('foo', $all[4][12]);
}
}