jjsm01/kimai2
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

Code improvements (#1649)

Browse Source 
* use global namespace for faster lookups
* phpstan level 5
This commit is contained in:
Kevin Papst
2020-04-19 14:37:14 +02:00
committed by GitHub
parent 7b25e9acaf
commit 0f3fa8fdbe
183 changed files with 604 additions and 574 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
tests/Invoice/Renderer/DebugRendererTest.php
View File

@@ -58,9 +58,9 @@ class DebugRendererTest extends TestCase
$response = $sut->render($document, $model);
$data = json_decode($response->getContent(), true);
$this->assertModelStructure($data['model'], count($model->getQuery()->getProjects()), count($model->getQuery()->getActivities()));
$this->assertModelStructure($data['model'], \count($model->getQuery()->getProjects()), \count($model->getQuery()->getActivities()));
$rows = $data['entries'];
$this->assertEquals($expectedRows, count($rows));
$this->assertEquals($expectedRows, \count($rows));
$i = 0;
foreach ($rows as $row) {
@@ -246,6 +246,6 @@ class DebugRendererTest extends TestCase
sort($givenKeys);
$this->assertEquals($expectedKeys, $givenKeys);
$this->assertEquals(count($keys), count($givenKeys));
$this->assertEquals(\count($keys), \count($givenKeys));
}
}

2
tests/Invoice/Renderer/TextRendererTest.php
View File

@@ -74,6 +74,6 @@ class TextRendererTest extends KernelTestCase
self::assertStringContainsString(sprintf("%s:\n %s", $key, explode("\n", $value)[0]), $content);
}
}
self::assertEquals(count($model->getCalculator()->getEntries()), substr_count($content, PHP_EOL . '---' . PHP_EOL));
self::assertEquals(\count($model->getCalculator()->getEntries()), substr_count($content, PHP_EOL . '---' . PHP_EOL));
}
}

2
tests/Invoice/Renderer/XmlRendererTest.php
View File

@@ -78,6 +78,6 @@ class XmlRendererTest extends KernelTestCase
}
self::assertEquals((string) $expected[$name], (string) $element);
}
self::assertEquals(count($model->getCalculator()->getEntries()), count($xml->items->item));
self::assertEquals(\count($model->getCalculator()->getEntries()), \count($xml->items->item));
}
}