jjsm01/kimai2
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

Code improvements (#1649)

Browse Source 
* use global namespace for faster lookups
* phpstan level 5
This commit is contained in:
Kevin Papst
2020-04-19 14:37:14 +02:00
committed by GitHub
parent 7b25e9acaf
commit 0f3fa8fdbe
183 changed files with 604 additions and 574 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
tests/Repository/InvoiceDocumentRepositoryTest.php
View File

@@ -44,10 +44,10 @@ class InvoiceDocumentRepositoryTest extends TestCase
{
$sut = new InvoiceDocumentRepository(self::$defaultDirectories);
$all = $sut->findAll();
$this->assertEquals(count(self::$defaultDocuments), count($all));
$this->assertEquals(\count(self::$defaultDocuments), \count($all));
foreach ($all as $document) {
$this->assertTrue(in_array($document->getName(), self::$defaultDocuments));
$this->assertTrue(\in_array($document->getName(), self::$defaultDocuments));
}
foreach (self::$defaultDocuments as $filename) {

4
tests/Repository/Query/BaseFormTypeQueryTest.php
View File

@@ -44,11 +44,11 @@ abstract class BaseFormTypeQueryTest extends TestCase
self::assertEmpty($sut->getTeams());
self::assertInstanceOf(BaseFormTypeQuery::class, $sut->addTeam(new Team()));
self::assertEquals(1, count($sut->getTeams()));
self::assertEquals(1, \count($sut->getTeams()));
$team = new Team();
self::assertInstanceOf(BaseFormTypeQuery::class, $sut->addTeam($team));
self::assertEquals(1, count($sut->getTeams()));
self::assertEquals(1, \count($sut->getTeams()));
self::assertSame($team, $sut->getTeams()[0]);
}

4
tests/Repository/Query/BaseQueryTest.php
View File

@@ -105,7 +105,7 @@ class BaseQueryTest extends TestCase
self::assertEmpty($sut->getTeams());
self::assertInstanceOf(BaseQuery::class, $sut->addTeam(new Team()));
self::assertEquals(1, count($sut->getTeams()));
self::assertEquals(1, \count($sut->getTeams()));
$sut->setTeams(null);
self::assertEmpty($sut->getTeams());
@@ -114,7 +114,7 @@ class BaseQueryTest extends TestCase
$team = new Team();
self::assertInstanceOf(BaseQuery::class, $sut->setTeams([$team]));
self::assertEquals(1, count($sut->getTeams()));
self::assertEquals(1, \count($sut->getTeams()));
self::assertSame($team, $sut->getTeams()[0]);
}

10
tests/Repository/TagRepositoryTest.php
View File

@@ -25,7 +25,7 @@ class TagRepositoryTest extends AbstractRepositoryTest
$em = $this->getEntityManager();
$data = new TagFixtures();
$data->setTagArray(['Test', 'Travel', '#2018-001', '#2018-002', '#2018-003', '#2018-004', '#2018-005', 'Administration', 'Support', 'PR', '#2018-012']);
$this->importFixture($em, $data);
$this->importFixture($data);
}
public function testFindIds()
@@ -37,7 +37,7 @@ class TagRepositoryTest extends AbstractRepositoryTest
$result = $repository->findIdsByTagNameList('2018,Test');
$this->assertIsArray($result);
$this->assertNotEmpty($result);
$this->assertEquals(7, count($result));
$this->assertEquals(7, \count($result));
$this->assertEquals(1, $result[0]);
$this->assertEquals(3, $result[1]);
$this->assertEquals(4, $result[2]);
@@ -56,7 +56,7 @@ class TagRepositoryTest extends AbstractRepositoryTest
$result = $repository->findIdsByTagNameList('Simply');
$this->assertIsArray($result);
$this->assertEmpty($result);
$this->assertEquals(0, count($result));
$this->assertEquals(0, \count($result));
}
public function testFindAllTagNames()
@@ -68,7 +68,7 @@ class TagRepositoryTest extends AbstractRepositoryTest
$result = $repository->findAllTagNames('2018');
$this->assertIsArray($result);
$this->assertNotEmpty($result);
$this->assertEquals(6, count($result));
$this->assertEquals(6, \count($result));
$this->assertEquals('#2018-001', $result[0]);
$this->assertEquals('#2018-002', $result[1]);
$this->assertEquals('#2018-003', $result[2]);
@@ -86,6 +86,6 @@ class TagRepositoryTest extends AbstractRepositoryTest
$result = $repository->findAllTagNames('Nothing');
$this->assertIsArray($result);
$this->assertEmpty($result);
$this->assertEquals(0, count($result));
$this->assertEquals(0, \count($result));
}
}

18
tests/Repository/TimesheetRepositoryTest.php
View File

@@ -46,7 +46,7 @@ class TimesheetRepositoryTest extends AbstractRepositoryTest
public function testStoppedEntriesCannotBeStoppedAgain()
{
$em = $this->getEntityManager();
$user = $this->getUserByRole($em, User::ROLE_USER);
$user = $this->getUserByRole(User::ROLE_USER);
/** @var TimesheetRepository $repository */
$repository = $em->getRepository(Timesheet::class);
@@ -54,7 +54,7 @@ class TimesheetRepositoryTest extends AbstractRepositoryTest
$fixtures->setUser($user);
$fixtures->setAmount(1);
$this->importFixture($em, $fixtures);
$this->importFixture($fixtures);
$query = new TimesheetQuery();
$query->setUser($user);
@@ -75,14 +75,14 @@ class TimesheetRepositoryTest extends AbstractRepositoryTest
public function testStopRecording()
{
$em = $this->getEntityManager();
$user = $this->getUserByRole($em, User::ROLE_USER);
$user = $this->getUserByRole(User::ROLE_USER);
/** @var TimesheetRepository $repository */
$repository = $em->getRepository(Timesheet::class);
$fixtures = new TimesheetFixtures();
$fixtures->setUser($user);
$fixtures->setAmountRunning(1);
$this->importFixture($em, $fixtures);
$fixture = new TimesheetFixtures();
$fixture->setUser($user);
$fixture->setAmountRunning(1);
$this->importFixture($fixture);
$timesheet = $repository->find(1);
$this->assertInstanceOf(Timesheet::class, $timesheet);
@@ -103,7 +103,7 @@ class TimesheetRepositoryTest extends AbstractRepositoryTest
$projectRepository = $em->getRepository(Project::class);
$project = $projectRepository->find(1);
$user = $this->getUserByRole($em, User::ROLE_USER);
$user = $this->getUserByRole(User::ROLE_USER);
/** @var TimesheetRepository $repository */
$repository = $em->getRepository(Timesheet::class);
$timesheet = new Timesheet();
@@ -130,7 +130,7 @@ class TimesheetRepositoryTest extends AbstractRepositoryTest
$projectRepository = $em->getRepository(Project::class);
$project = $projectRepository->find(1);
$user = $this->getUserByRole($em, User::ROLE_USER);
$user = $this->getUserByRole(User::ROLE_USER);
/** @var TimesheetRepository $repository */
$repository = $em->getRepository(Timesheet::class);
$tagOne = new Tag();