jjsm01/kimai2
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

make sure to generate valid filenames (#2238)

Browse Source
This commit is contained in:
Kevin Papst
2021-01-08 14:50:23 +01:00
committed by GitHub
parent a5fdf81df5
commit 244169d6d5
7 changed files with 80 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
tests/Command/InvoiceCreateCommandTest.php
View File

@@ -186,7 +186,7 @@ class InvoiceCreateCommandTest extends KernelTestCase
$this->assertStringContainsString('| ID | Customer | Total | Filename |', $output);
$this->assertStringContainsString('+----+----------+-------+-------------------------------------------------------------------------+', $output);
$this->assertStringContainsString('| 1 | Test | 0 EUR | /', $output);
$this->assertStringContainsString('/tests/_data/invoices/2020-001-test.html |', $output);
$this->assertStringContainsString('/tests/_data/invoices/' . ((new \DateTime())->format('Y')) . '-001-Test.html |', $output);
}
protected function prepareFixtures(\DateTime $start)

10
tests/Invoice/InvoiceFilenameTest.php
View File

@@ -46,11 +46,11 @@ class InvoiceFilenameTest extends TestCase
self::assertEquals($datePrefix . '-foo', $sut->getFilename());
self::assertEquals($datePrefix . '-foo', (string) $sut);
$customer->setCompany('barß / laölala # ldksjf 123');
$customer->setCompany('barß / laölala # ldksjf 123 MyAwesome GmbH');
$sut = new InvoiceFilename($model);
self::assertEquals($datePrefix . '-barss_laolala_ldksjf123', $sut->getFilename());
self::assertEquals($datePrefix . '-barss_laolala_ldksjf123', (string) $sut);
self::assertEquals($datePrefix . '-barss_laolala_ldksjf_123_MyAwesome_GmbH', $sut->getFilename());
self::assertEquals($datePrefix . '-barss_laolala_ldksjf_123_MyAwesome_GmbH', (string) $sut);
$customer->setCompany('까깨꺄꺠꺼께껴꼐꼬꽈sssss');
$sut = new InvoiceFilename($model);
@@ -58,7 +58,7 @@ class InvoiceFilenameTest extends TestCase
$customer->setCompany('\"#+ß.!$%&/()=?\\n=/*-+´_<>@' . "\n");
$sut = new InvoiceFilename($model);
self::assertEquals($datePrefix . '-ss_n', $sut->getFilename());
self::assertEquals($datePrefix . '-ss_n_-', $sut->getFilename());
$project = new Project();
$project->setName('Demo ProjecT1');
@@ -69,6 +69,6 @@ class InvoiceFilenameTest extends TestCase
$customer->setCompany('\"#+ß.!$%&/()=?\\n=/*-+´_<>@' . "\n");
$sut = new InvoiceFilename($model);
self::assertEquals($datePrefix . '-ss_n-demo_projec_t1', $sut->getFilename());
self::assertEquals($datePrefix . '-ss_n_--Demo_ProjecT1', $sut->getFilename());
}
}

42
tests/Utils/FileHelperTest.php Normal file
View File

@@ -0,0 +1,42 @@
<?php
/*
* This file is part of the Kimai time-tracking app.
*
* For the full copyright and license information, please view the LICENSE
* file that was distributed with this source code.
*/
namespace App\Tests\Utils;
use App\Utils\FileHelper;
use PHPUnit\Framework\TestCase;
/**
* @covers \App\Utils\FileHelper
*/
class FileHelperTest extends TestCase
{
public function getFileTestData()
{
return [
['Barss_laolala_ld_ksjf_123_MyAwesome_GmbH', 'Barß / laölala # ld_ksjf 123 MyAwesome GmbH'],
['namaste', 'नमस्ते'],
['sa_yonara', 'さ!よなら'],
['sp_asibo_spa_sibo_spas_--_ibo', ' сп.асибо/спа сибо#/!спас -- ибо!!'],
['kkakkaekkyakkyaekkeokke_kkyeokkyekkokkwasssss', '까깨꺄꺠꺼께_껴꼐꼬꽈sssss'],
['ss_n_-', '\"#+ß.!$%&/()=?\\n=/*-+´_<>@' . "\n"],
['Demo_ProjecT1', 'Demo ProjecT1'],
['kimai-export', 'kimai-export'],
['D_e_m_o_Pr_oj_e_c_T1', 'D"e&m%o# Pr\'oj\\e/c?T1'],
];
}
/**
* @dataProvider getFileTestData
*/
public function testEnsureMaxLength(string $expected, string $original)
{
self::assertEquals($expected, FileHelper::convertToAsciiFilename($original));
}
}