random improvements (#5382)
* remove permission check, as own timesheets should always be visible * new methods to create datetime * allow access to user roles in javascript * support class for dropdown actions * allow to edit internal rate * support human readable duration in export via user configuration * allow to order timesheet listing by user, exported and billable field * bump codecov action
This commit is contained in:
@@ -106,11 +106,11 @@ abstract class TimesheetAbstractController extends AbstractController
|
||||
}
|
||||
|
||||
if ($canSeeUsername) {
|
||||
$table->addColumn('username', ['class' => 'd-none d-md-table-cell', 'orderBy' => false]);
|
||||
$table->addColumn('username', ['class' => 'd-none d-md-table-cell', 'orderBy' => 'user']);
|
||||
}
|
||||
|
||||
$table->addColumn('billable', ['class' => 'text-center d-none w-min', 'orderBy' => false]);
|
||||
$table->addColumn('exported', ['class' => 'text-center d-none w-min', 'orderBy' => false]);
|
||||
$table->addColumn('billable', ['class' => 'text-center d-none w-min']);
|
||||
$table->addColumn('exported', ['class' => 'text-center d-none w-min']);
|
||||
$table->addColumn('actions', ['class' => 'actions']);
|
||||
|
||||
$page = $this->createPageSetup();
|
||||
|
||||
@@ -45,6 +45,7 @@ final class TimesheetTeamController extends TimesheetAbstractController
|
||||
public function indexAction(int $page, Request $request): Response
|
||||
{
|
||||
$query = $this->createDefaultQuery();
|
||||
$query->addAllowedOrderColumns('user');
|
||||
$query->setPage($page);
|
||||
|
||||
return $this->index($query, $request, 'admin_timesheet', 'admin_timesheet_paginated', TimesheetMetaDisplayEvent::TEAM_TIMESHEET);
|
||||
|
||||
Reference in New Issue
Block a user