random improvements (#5382)

* remove permission check, as own timesheets should always be visible
* new methods to create datetime
* allow access to user roles in javascript
* support class for dropdown actions
* allow to edit internal rate
* support human readable duration in export via user configuration
* allow to order timesheet listing by user, exported and billable field
* bump codecov action

src/Export/Base/SpreadsheetRenderer.php

@@ -11,6 +11,7 @@ namespace App\Export\Base;
 
 use App\Entity\ExportableItem;
 use App\Entity\MetaTableTypeInterface;
+use App\Entity\User;
 use App\Event\ActivityMetaDisplayEvent;
 use App\Event\CustomerMetaDisplayEvent;
 use App\Event\MetaDisplayEventInterface;
@@ -22,6 +23,7 @@ use App\Export\Package\CellFormatter\BooleanFormatter;
 use App\Export\Package\CellFormatter\CellFormatterInterface;
 use App\Export\Package\CellFormatter\DateFormatter;
 use App\Export\Package\CellFormatter\DefaultFormatter;
+use App\Export\Package\CellFormatter\DurationDecimalFormatter;
 use App\Export\Package\CellFormatter\DurationFormatter;
 use App\Export\Package\CellFormatter\RateFormatter;
 use App\Export\Package\CellFormatter\TextFormatter;
@@ -130,6 +132,7 @@ final class SpreadsheetRenderer
             'date' => new DateFormatter(),
             'time' => new TimeFormatter(),
             'duration' => new DurationFormatter(),
+            'duration_decimal' => new DurationDecimalFormatter(),
             default => new DefaultFormatter()
         };
     }
@@ -141,12 +144,17 @@ final class SpreadsheetRenderer
     {
         $showRates = $this->isRenderRate($query);
 
+        $durationFormatter = 'duration';
+        if (($user = $this->voter->getUser()) instanceof User) {
+            $durationFormatter = $user->isExportDecimal() ? 'duration_decimal' : 'duration';
+        }
+
         $columns = [];
 
         $columns[] = (new Column('date', $this->getFormatter('date')))->withExtractor(fn (ExportableItem $exportableItem) => $exportableItem->getBegin());
         $columns[] = (new Column('begin', $this->getFormatter('time')))->withExtractor(fn (ExportableItem $exportableItem) => $exportableItem->getBegin())->withColumnWidth(ColumnWidth::SMALL);
         $columns[] = (new Column('end', $this->getFormatter('time')))->withExtractor(fn (ExportableItem $exportableItem) => $exportableItem->getEnd())->withColumnWidth(ColumnWidth::SMALL);
-        $columns[] = (new Column('duration', $this->getFormatter('duration')))->withExtractor(fn (ExportableItem $exportableItem) => $exportableItem->getDuration())->withColumnWidth(ColumnWidth::SMALL);
+        $columns[] = (new Column('duration', $this->getFormatter($durationFormatter)))->withExtractor(fn (ExportableItem $exportableItem) => $exportableItem->getDuration())->withColumnWidth(ColumnWidth::SMALL);
 
         if ($showRates) {
             $columns[] = (new Column('currency', $this->getFormatter('default')))->withExtractor(fn (ExportableItem $exportableItem) => $exportableItem->getProject()?->getCustomer()?->getCurrency())->withColumnWidth(ColumnWidth::SMALL);

src/Export/Package/CellFormatter/DurationDecimalFormatter.php

@@ -0,0 +1,31 @@
+<?php
+
+/*
+ * This file is part of the Kimai time-tracking app.
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
+namespace App\Export\Package\CellFormatter;
+
+use App\Utils\Duration;
+
+final class DurationDecimalFormatter implements CellFormatterInterface
+{
+    private Duration $duration;
+
+    public function __construct()
+    {
+        $this->duration = new Duration();
+    }
+
+    public function formatValue(mixed $value): mixed
+    {
+        if (is_numeric($value)) {
+            return $this->duration->formatDecimal((int) $value);
+        }
+
+        return 0.0;
+    }
+}

src/Export/Package/CellFormatter/DurationFormatter.php

@@ -9,14 +9,23 @@
 
 namespace App\Export\Package\CellFormatter;
 
+use App\Utils\Duration;
+
 final class DurationFormatter implements CellFormatterInterface
 {
+    private Duration $duration;
+
+    public function __construct()
+    {
+        $this->duration = new Duration();
+    }
+
     public function formatValue(mixed $value): mixed
     {
         if (is_numeric($value)) {
-            return (float) number_format($value / 3600, 2, '.', '');
+            return $this->duration->format((int) $value);
         }
 
-        return 0.0;
+        return $this->duration->format(0);
     }
 }