Drop SQLite support (#2405)

tests/DataFixtures/TimesheetFixtures.php

@@ -16,14 +16,13 @@ use App\Entity\Timesheet;
 use App\Entity\User;
 use App\Entity\UserPreference;
 use App\Timesheet\Util;
-use Doctrine\Bundle\FixturesBundle\Fixture;
 use Doctrine\Persistence\ObjectManager;
 use Faker\Factory;
 
 /**
  * Defines the sample data to load in during controller tests.
  */
-final class TimesheetFixtures extends Fixture
+final class TimesheetFixtures implements TestFixture
 {
     /**
      * @var User
@@ -205,10 +204,13 @@ final class TimesheetFixtures extends Fixture
     }
 
     /**
-     * {@inheritdoc}
+     * @param ObjectManager $manager
+     * @return Timesheet[]
      */
-    public function load(ObjectManager $manager)
+    public function load(ObjectManager $manager): array
     {
+        $created = [];
+
         $activities = $this->activities;
         if (empty($activities)) {
             $activities = $this->getAllActivities($manager);
@@ -222,6 +224,12 @@ final class TimesheetFixtures extends Fixture
         $faker = Factory::create();
         $user = $this->user;
 
+        $tags = $this->getTagObjectList();
+        foreach ($tags as $tag) {
+            $manager->persist($tag);
+        }
+        $manager->flush();
+
         for ($i = 0; $i < $this->amount; $i++) {
             $description = $faker->text;
             if ($this->allowEmptyDescriptions) {
@@ -239,8 +247,6 @@ final class TimesheetFixtures extends Fixture
                 $project = $projects[array_rand($projects)];
             }
 
-            $tags = $this->getTagObjectList($i);
-
             $timesheet = $this->createTimesheetEntry(
                 $user,
                 $activity,
@@ -254,6 +260,7 @@ final class TimesheetFixtures extends Fixture
                 \call_user_func($this->callback, $timesheet);
             }
             $manager->persist($timesheet);
+            $created[] = $timesheet;
         }
 
         for ($i = 0; $i < $this->running; $i++) {
@@ -264,8 +271,6 @@ final class TimesheetFixtures extends Fixture
                 $project = $projects[array_rand($projects)];
             }
 
-            $tags = $this->getTagObjectList($i);
-
             $timesheet = $this->createTimesheetEntry(
                 $user,
                 $activity,
@@ -280,24 +285,32 @@ final class TimesheetFixtures extends Fixture
                 \call_user_func($this->callback, $timesheet);
             }
             $manager->persist($timesheet);
+            $created[] = $timesheet;
         }
 
         $manager->flush();
+
+        return $created;
     }
 
-    protected function getTagObjectList(int $cnt): array
+    private function getTagObjectList(): array
     {
         if (true === $this->useTags) {
-            $tagObject = new Tag();
-            $tagObject->setName($this->tags[($cnt % \count($this->tags))]);
+            $all = [];
+            foreach ($this->tags as $tagName) {
+                $tagObject = new Tag();
+                $tagObject->setName($tagName);
 
-            return [$tagObject];
+                $all[] = $tagObject;
+            }
+
+            return $all;
         }
 
         return [];
     }
 
-    protected function getDateTime(int $i): \DateTime
+    private function getDateTime(int $i): \DateTime
     {
         $start = \DateTime::createFromFormat('Y-m-d', $this->startDate);
         $start->modify("+ $i days");
@@ -310,7 +323,7 @@ final class TimesheetFixtures extends Fixture
      * @param ObjectManager $manager
      * @return array<int|string, Activity>
      */
-    protected function getAllActivities(ObjectManager $manager): array
+    private function getAllActivities(ObjectManager $manager): array
     {
         $all = [];
         /** @var Activity[] $entries */
@@ -326,7 +339,7 @@ final class TimesheetFixtures extends Fixture
      * @param ObjectManager $manager
      * @return array<int|string, Project>
      */
-    protected function getAllProjects(ObjectManager $manager): array
+    private function getAllProjects(ObjectManager $manager): array
     {
         $all = [];
         /** @var Project[] $entries */