Release 2.58 (#5952)

* bump version
* fix formatting locale reset after embedded controller sub-requests (#5944)
* fix GHSA-c6w6-57jj-62vh
* fix GHSA-m492-gv72-xvxj
* fix GHSA-jr9p-4h4j-6c58
* make sure to only use JS logic to call API endpoints
* fixes GHSA-r8vr-m544-qh4h
* make sure to only use JS logic to call API endpoints
* fix GHSA-rw46-qg69-vg6h
* fix GHSA-pj8j-p4g4-4vw8 - prevent kimai from rendering images via markdown
* fix GHSA-pj8j-p4g4-4vw8 - use a safe network client to prevent SSRF via images
* fix GHSA-xv4r-4885-gwpg
* fix GHSA-pgcc-vfmc-7cw5 - move GET routes to API with POST method to prevent CSRF
* fix tooltip survives page reload
* updated wizard images
* split wizard and password reset subscriber into two classes
* relax upper php limit
* added zizmor workflow scans and apply findings
* user permissions <name>_other_profile  now respect teams
* move all linting steps to new job
* updated docker image version names
* use .env.local for storing APP_SECRET
* improve build order and use given tag as ref for checkout, not default main branch
* improved APP_SECRET handling, see entrypoint.sh
* use local code for building the image for more flexibility, added dockerignore

config/packages/security.yaml

@@ -72,7 +72,9 @@ security:
 
             login_link:
                 check_route: link_login_check
-                signature_properties: ['id']
+                # 'password' binds the HMAC signature to the password hash, so a
+                # link becomes invalid as soon as the user changes the password
+                signature_properties: ['id', 'password']
                 lifetime: 900
                 max_uses: 3
 

config/services.yaml

@@ -58,9 +58,23 @@ services:
         arguments:
             $settings: '%kimai.config%'
 
+    # HTTP client used by mPDF to fetch remote resources (e.g. logos referenced
+    # from custom Twig invoice templates). Decorated with NoPrivateNetworkHttpClient
+    # so requests to private/loopback/link-local targets are blocked at the
+    # network layer — defense in depth for SSRF.
+    # @see https://github.com/kimai/kimai/security/advisories/GHSA-pj8j-p4g4-4vw8
+    Symfony\Component\HttpClient\NoPrivateNetworkHttpClient:
+        arguments:
+            - '@http_client'
+
+    App\Pdf\SafeRemoteContentClient:
+        arguments:
+            - '@Symfony\Component\HttpClient\NoPrivateNetworkHttpClient'
+
     App\Pdf\MPdfConverter:
         arguments:
             $cacheDirectory: '%kernel.cache_dir%'
+            $httpClient: '@App\Pdf\SafeRemoteContentClient'
 
     App\Utils\FileHelper:
         arguments: