Release 2.58 (#5952)
* bump version * fix formatting locale reset after embedded controller sub-requests (#5944) * fix GHSA-c6w6-57jj-62vh * fix GHSA-m492-gv72-xvxj * fix GHSA-jr9p-4h4j-6c58 * make sure to only use JS logic to call API endpoints * fixes GHSA-r8vr-m544-qh4h * make sure to only use JS logic to call API endpoints * fix GHSA-rw46-qg69-vg6h * fix GHSA-pj8j-p4g4-4vw8 - prevent kimai from rendering images via markdown * fix GHSA-pj8j-p4g4-4vw8 - use a safe network client to prevent SSRF via images * fix GHSA-xv4r-4885-gwpg * fix GHSA-pgcc-vfmc-7cw5 - move GET routes to API with POST method to prevent CSRF * fix tooltip survives page reload * updated wizard images * split wizard and password reset subscriber into two classes * relax upper php limit * added zizmor workflow scans and apply findings * user permissions <name>_other_profile now respect teams * move all linting steps to new job * updated docker image version names * use .env.local for storing APP_SECRET * improve build order and use given tag as ref for checkout, not default main branch * improved APP_SECRET handling, see entrypoint.sh * use local code for building the image for more flexibility, added dockerignore
This commit is contained in:
@@ -28,7 +28,7 @@ class ParsedownExtensionTest extends TestCase
|
||||
| Another entry | € 111 |
|
||||
| | |
|
||||
| Total | A lot |');
|
||||
self::assertStringStartsWith('<table class="table">', $html);
|
||||
self::assertStringStartsWith('<table class="table table-striped table-vcenter">', $html);
|
||||
}
|
||||
|
||||
public function testHeaderIsNotConverted(): void
|
||||
@@ -39,4 +39,23 @@ class ParsedownExtensionTest extends TestCase
|
||||
');
|
||||
self::assertEquals('<p># Foo</p>', $html);
|
||||
}
|
||||
|
||||
/**
|
||||
* Markdown image syntax must never emit an `<img>` tag, otherwise mPDF
|
||||
* (server-side) or the browser (UI) would auto-fetch the remote URL.
|
||||
*
|
||||
* @see https://github.com/kimai/kimai/security/advisories/GHSA-pj8j-p4g4-4vw8
|
||||
*/
|
||||
public function testMarkdownImageIsRewrittenAsLink(): void
|
||||
{
|
||||
$sut = new ParsedownExtension();
|
||||
$sut->setSafeMode(true);
|
||||
$sut->setMarkupEscaped(true);
|
||||
|
||||
$html = $sut->text('');
|
||||
|
||||
self::assertStringNotContainsString('<img', $html);
|
||||
self::assertStringContainsString('href="http://attacker.example/p.png"', $html);
|
||||
self::assertStringContainsString('>probe</a>', $html);
|
||||
}
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user