jjsm01/kimai2
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

Release 2.58 (#5952)

Browse Source 
* bump version
* fix formatting locale reset after embedded controller sub-requests (#5944)
* fix GHSA-c6w6-57jj-62vh
* fix GHSA-m492-gv72-xvxj
* fix GHSA-jr9p-4h4j-6c58
* make sure to only use JS logic to call API endpoints
* fixes GHSA-r8vr-m544-qh4h
* make sure to only use JS logic to call API endpoints
* fix GHSA-rw46-qg69-vg6h
* fix GHSA-pj8j-p4g4-4vw8 - prevent kimai from rendering images via markdown
* fix GHSA-pj8j-p4g4-4vw8 - use a safe network client to prevent SSRF via images
* fix GHSA-xv4r-4885-gwpg
* fix GHSA-pgcc-vfmc-7cw5 - move GET routes to API with POST method to prevent CSRF
* fix tooltip survives page reload
* updated wizard images
* split wizard and password reset subscriber into two classes
* relax upper php limit
* added zizmor workflow scans and apply findings
* user permissions <name>_other_profile  now respect teams
* move all linting steps to new job
* updated docker image version names
* use .env.local for storing APP_SECRET
* improve build order and use given tag as ref for checkout, not default main branch
* improved APP_SECRET handling, see entrypoint.sh
* use local code for building the image for more flexibility, added dockerignore
This commit is contained in:
Kevin Papst
2026-05-25 15:39:47 +02:00
committed by GitHub
parent 8d245ae223
commit 31a8f887a5
85 changed files with 2737 additions and 472 deletions
Download Patch File Download Diff File Expand all files Collapse all files

70
tests/Utils/ParsedownTest.php
View File

@@ -50,4 +50,74 @@ class ParsedownTest extends TestCase
<h1 id="foo-1">Foo</h1>
<h1 id="foo-2">Foo</h1>', $html);
}
/**
* Markdown image syntax must never emit an `<img>` tag, otherwise mPDF
* (server-side) or the browser (UI) would auto-fetch the remote URL.
*
* @see https://github.com/kimai/kimai/security/advisories/GHSA-pj8j-p4g4-4vw8
*/
public function testMarkdownImageIsRewrittenAsLink(): void
{
$sut = new Parsedown();
$sut->setSafeMode(true);
$sut->setMarkupEscaped(true);
$html = $sut->text('![probe](http://attacker.example/p.png)');
self::assertStringNotContainsString('<img', $html);
self::assertStringContainsString('href="http://attacker.example/p.png"', $html);
self::assertStringContainsString('>probe</a>', $html);
self::assertStringContainsString('target="_blank"', $html);
self::assertStringContainsString('rel="noopener noreferrer"', $html);
}
public function testMarkdownImageWithoutAltUsesUrlAsLabel(): void
{
$sut = new Parsedown();
$sut->setSafeMode(true);
$sut->setMarkupEscaped(true);
$html = $sut->text('![](http://attacker.example/p.png)');
self::assertStringNotContainsString('<img', $html);
self::assertStringContainsString('>http://attacker.example/p.png</a>', $html);
}
public function testReferenceStyleImageIsRewrittenAsLink(): void
{
$sut = new Parsedown();
$sut->setSafeMode(true);
$sut->setMarkupEscaped(true);
$html = $sut->text("![probe][ref]\n\n[ref]: http://attacker.example/p.png");
self::assertStringNotContainsString('<img', $html);
self::assertStringContainsString('href="http://attacker.example/p.png"', $html);
self::assertStringContainsString('>probe</a>', $html);
}
public function testRawHtmlImageIsEscaped(): void
{
$sut = new Parsedown();
$sut->setSafeMode(true);
$sut->setMarkupEscaped(true);
$html = $sut->text('<img src="http://attacker.example/p.png">');
self::assertStringNotContainsString('<img', $html);
self::assertStringContainsString('&lt;img', $html);
}
public function testJavascriptUrlInImageIsNeutralised(): void
{
$sut = new Parsedown();
$sut->setSafeMode(true);
$sut->setMarkupEscaped(true);
$html = $sut->text('![x](javascript:alert(1))');
self::assertStringNotContainsString('<img', $html);
self::assertStringNotContainsString('href="javascript:', $html);
}
}