reduce field size to 150 chars to prevent index out of length (#1031)

This commit is contained in:
Kevin Papst
2019-08-16 16:57:09 +02:00
committed by GitHub
parent b6d9bb0d2a
commit 388c3ec188
9 changed files with 131 additions and 14 deletions

View File

@@ -50,15 +50,27 @@ final class Version20190706224219 extends AbstractMigration
$timesheet->addIndex(['start_time', 'end_time', 'user'], 'IDX_4F60C6B1502DF587415614018D93D649');
$activity = $schema->getTable('kimai2_activities');
$name = $activity->getColumn('name');
if ($name->getLength() !== 150) {
$name->setLength(150);
}
$activity->addIndex(['visible', 'project_id'], 'IDX_8811FE1C7AB0E859166D1F9C');
$activity->addIndex(['visible', 'project_id', 'name'], 'IDX_8811FE1C7AB0E859166D1F9C5E237E06');
$activity->addIndex(['visible', 'name'], 'IDX_8811FE1C7AB0E8595E237E06');
$project = $schema->getTable('kimai2_projects');
$name = $project->getColumn('name');
if ($name->getLength() !== 150) {
$name->setLength(150);
}
$project->addIndex(['customer_id', 'visible', 'name'], 'IDX_407F12069395C3F37AB0E8595E237E06');
$project->addIndex(['customer_id', 'visible', 'id'], 'IDX_407F12069395C3F37AB0E859BF396750');
$customer = $schema->getTable('kimai2_customers');
$name = $customer->getColumn('name');
if ($name->getLength() !== 150) {
$name->setLength(150);
}
$customer->addIndex(['visible'], 'IDX_5A9760447AB0E859');
}
@@ -68,13 +80,16 @@ final class Version20190706224219 extends AbstractMigration
$activity->dropIndex('IDX_8811FE1C7AB0E859166D1F9C');
$activity->dropIndex('IDX_8811FE1C7AB0E859166D1F9C5E237E06');
$activity->dropIndex('IDX_8811FE1C7AB0E8595E237E06');
$activity->getColumn('name')->setLength(255);
$customer = $schema->getTable('kimai2_customers');
$customer->dropIndex('IDX_5A9760447AB0E859');
$customer->getColumn('name')->setLength(255);
$project = $schema->getTable('kimai2_projects');
$project->dropIndex('IDX_407F12069395C3F37AB0E8595E237E06');
$project->dropIndex('IDX_407F12069395C3F37AB0E859BF396750');
$project->getColumn('name')->setLength(255);
$timesheet = $schema->getTable('kimai2_timesheet');
$timesheet->dropIndex('IDX_4F60C6B18D93D649502DF587');

View File

@@ -0,0 +1,78 @@
<?php
declare(strict_types=1);
/*
* This file is part of the Kimai time-tracking app.
*
* For the full copyright and license information, please view the LICENSE
* file that was distributed with this source code.
*/
namespace DoctrineMigrations;
use App\Doctrine\AbstractMigration;
use Doctrine\DBAL\Schema\Schema;
/**
* Changing column sizes to prevent index length errors.
*
* @version 1.2
*/
final class Version20190813162649 extends AbstractMigration
{
public function getDescription(): string
{
return 'Changing column sizes to prevent index length errors';
}
protected function isSupportingForeignKeys(): bool
{
return false;
}
public function isTransactional(): bool
{
if ($this->isPlatformSqlite()) {
// does fail if we use transactions, as tables are re-created and foreign keys would fail
return false;
}
return true;
}
public function up(Schema $schema): void
{
$activity = $schema->getTable('kimai2_activities');
$name = $activity->getColumn('name');
if ($name->getLength() !== 150) {
$name->setLength(150);
}
$project = $schema->getTable('kimai2_projects');
$name = $project->getColumn('name');
if ($name->getLength() !== 150) {
$name->setLength(150);
}
$customer = $schema->getTable('kimai2_customers');
$name = $customer->getColumn('name');
if ($name->getLength() !== 150) {
$name->setLength(150);
}
$customer->getColumn('timezone')->setLength(64);
}
public function down(Schema $schema): void
{
$activity = $schema->getTable('kimai2_activities');
$activity->getColumn('name')->setLength(255);
$project = $schema->getTable('kimai2_projects');
$project->getColumn('name')->setLength(255);
$customer = $schema->getTable('kimai2_customers');
$customer->getColumn('name')->setLength(255);
$customer->getColumn('timezone')->setLength(255);
}
}