phpstan level 3, fixed deprecations, code cleanup (#811)

2019-05-28 12:24:21 +02:00
parent d9dca96a32
commit 393abe9e62
69 changed files with 381 additions and 189 deletions
--- a/src/Invoice/Renderer/OdsRenderer.php
+++ b/src/Invoice/Renderer/OdsRenderer.php
@@ -33,12 +33,16 @@ class OdsRenderer extends AbstractSpreadsheetRenderer implements RendererInterfa

    /**
     * @param Spreadsheet $spreadsheet
-     * @return bool|string
-     * @throws \PhpOffice\PhpSpreadsheet\Writer\Exception
+     * @return string
+     * @throws \Exception
     */
    protected function saveSpreadsheet(Spreadsheet $spreadsheet)
    {
        $filename = tempnam(sys_get_temp_dir(), 'kimai-invoice-ods');
+        if (false === $filename) {
+            throw new \Exception('Could not open temporary file');
+        }
+
        $writer = IOFactory::createWriter($spreadsheet, 'Ods');
        $writer->save($filename);