jjsm01/kimai2
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

move supported languages logic to service (#2701)

Browse Source
This commit is contained in:
Kevin Papst
2021-08-07 01:11:42 +02:00
committed by GitHub
parent cefd747e91
commit 3a7dba437c
7 changed files with 130 additions and 74 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
tests/EventSubscriber/RedirectToLocaleSubscriberTest.php
View File

@@ -10,6 +10,7 @@
namespace App\Tests\EventSubscriber;
use App\EventSubscriber\RedirectToLocaleSubscriber;
use App\Utils\LanguageService;
use PHPUnit\Framework\TestCase;
use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\HttpKernel\Event\RequestEvent;
@@ -24,7 +25,7 @@ class RedirectToLocaleSubscriberTest extends TestCase
public function testConstruct()
{
$urlGenerator = $this->createMock(UrlGeneratorInterface::class);
$sut = new RedirectToLocaleSubscriber($urlGenerator, 'de|en', 'en');
$sut = new RedirectToLocaleSubscriber($urlGenerator, new LanguageService('de|en'));
self::assertEquals([KernelEvents::REQUEST => ['onKernelRequest']], RedirectToLocaleSubscriber::getSubscribedEvents());
@@ -37,13 +38,4 @@ class RedirectToLocaleSubscriberTest extends TestCase
$sut->onKernelRequest($event);
}
public function testConstructWithUnknownDefaultLocale()
{
$this->expectException(\UnexpectedValueException::class);
$this->expectExceptionMessage('The default locale ("en") must be one of "de|it".');
$urlGenerator = $this->createMock(UrlGeneratorInterface::class);
$sut = new RedirectToLocaleSubscriber($urlGenerator, 'de|it', 'en');
}
}

51
tests/Utils/LanguageServiceTest.php Normal file
View File

@@ -0,0 +1,51 @@
<?php
/*
* This file is part of the Kimai time-tracking app.
*
* For the full copyright and license information, please view the LICENSE
* file that was distributed with this source code.
*/
namespace App\Tests\Utils;
use App\Utils\LanguageService;
use PHPUnit\Framework\TestCase;
/**
* @covers \App\Utils\LanguageService
*/
class LanguageServiceTest extends TestCase
{
public function testDefaults()
{
$sut = new LanguageService('en');
self::assertFalse($sut->isKnownLanguage('de'));
self::assertTrue($sut->isKnownLanguage('en'));
self::assertFalse($sut->isKnownLanguage('xx'));
self::assertEquals('en', $sut->getDefaultLanguage());
self::assertEquals(['en'], $sut->getAllLanguages());
}
public function testOneLanguage()
{
$sut = new LanguageService('de');
self::assertTrue($sut->isKnownLanguage('de'));
self::assertFalse($sut->isKnownLanguage('en'));
self::assertFalse($sut->isKnownLanguage('xx'));
self::assertEquals('en', $sut->getDefaultLanguage());
self::assertEquals(['de'], $sut->getAllLanguages());
}
public function testMultipleLanguages()
{
$sut = new LanguageService('de|it|fr|de_CH|ru|hu|en|zh_CN');
self::assertTrue($sut->isKnownLanguage('de'));
self::assertTrue($sut->isKnownLanguage('en'));
self::assertTrue($sut->isKnownLanguage('en'));
self::assertFalse($sut->isKnownLanguage('xx'));
self::assertEquals('en', $sut->getDefaultLanguage());
// casing is important for locales!
self::assertEquals(['de', 'it', 'fr', 'de_CH', 'ru', 'hu', 'en', 'zh_CN'], $sut->getAllLanguages());
}
}