Release 1.30 (#3651)

* exclude all 403 and 404 from logs
* bump version
* cleanup tag handling
* prevent mandatory user preferences turning null

tests/API/TimesheetControllerTest.php

@@ -312,7 +312,6 @@ class TimesheetControllerTest extends APIControllerBaseTest
         $timesheet = new Timesheet();
         $timesheet
             ->setHourlyRate(137.21)
-            ->setInternalRate(64.96)
             ->setBegin($startDate)
             ->setEnd($endDate)
             ->setExported(true)
@@ -348,11 +347,11 @@ class TimesheetControllerTest extends APIControllerBaseTest
             'metaFields' => [],
             'hourlyRate' => 137.21,
             'rate' => 1772.2958,
-            'internalRate' => 0.0,
+            'internalRate' => 1772.2958,
         ];
 
         foreach ($expected as $key => $value) {
-            self::assertEquals($value, $result[$key]);
+            self::assertEquals($value, $result[$key], sprintf('Field %s has invalid value', $key));
         }
     }
 

tests/Entity/TagTest.php

@@ -10,7 +10,6 @@
 namespace App\Tests\Entity;
 
 use App\Entity\Tag;
-use App\Entity\Timesheet;
 use PHPUnit\Framework\TestCase;
 
 /**
@@ -40,20 +39,4 @@ class TagTest extends TestCase
         $sut->setColor('#fffccc');
         $this->assertEquals('#fffccc', $sut->getColor());
     }
-
-    public function testWithTimesheet()
-    {
-        $sut = new Tag();
-        $timesheet = new Timesheet();
-
-        $this->assertEmpty($timesheet->getTags());
-
-        $sut->setName('bar');
-        $sut->addTimesheet($timesheet);
-
-        $this->assertSame($sut, $timesheet->getTags()[0]);
-
-        $sut->removeTimesheet($timesheet);
-        $this->assertEmpty($timesheet->getTags());
-    }
 }