performance improvements (#2329)

* remove work from constructor * refactor twig extensions * upgrade theme * replace sub-request with direct template rendering
2021-02-20 23:52:01 +01:00
parent 9eb25c412e
commit 607d09aefb
40 changed files with 992 additions and 1092 deletions
--- a/tests/Twig/Runtime/WidgetExtensionTest.php
+++ b/tests/Twig/Runtime/WidgetExtensionTest.php
@@ -0,0 +1,91 @@
+<?php
+
+/*
+ * This file is part of the Kimai time-tracking app.
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
+namespace App\Tests\Twig\Runtime;
+
+use App\Twig\Runtime\WidgetExtension;
+use App\Widget\Type\More;
+use App\Widget\WidgetInterface;
+use App\Widget\WidgetRendererInterface;
+use App\Widget\WidgetService;
+use PHPUnit\Framework\TestCase;
+
+/**
+ * @covers \App\Twig\Runtime\WidgetExtension
+ */
+class WidgetExtensionTest extends TestCase
+{
+    protected function getSut($hasWidget = null, $getWidget = null, $renderer = null): WidgetExtension
+    {
+        $service = $this->createMock(WidgetService::class);
+        if (null !== $hasWidget) {
+            $service->expects($this->once())->method('hasWidget')->willReturn($hasWidget);
+        }
+        if (null !== $getWidget) {
+            $service->expects($this->once())->method('getWidget')->willReturn($getWidget);
+        }
+        if (null !== $renderer) {
+            $service->expects($this->once())->method('findRenderer')->willReturn($renderer);
+        }
+
+        return new WidgetExtension($service);
+    }
+
+    public function testRenderWidgetForInvalidValue()
+    {
+        $this->expectException(\InvalidArgumentException::class);
+        $this->expectExceptionMessage('Widget must either implement WidgetInterface or be a string');
+
+        $sut = $this->getSut();
+        /* @phpstan-ignore-next-line */
+        $sut->renderWidget(true);
+    }
+
+    public function testRenderWidgetForUnknownWidget()
+    {
+        $this->expectException(\InvalidArgumentException::class);
+        $this->expectExceptionMessage('Unknown widget "test" requested');
+
+        $sut = $this->getSut(false);
+        $sut->renderWidget('test');
+    }
+
+    public function testRenderWidgetByString()
+    {
+        $widget = new More();
+        $sut = $this->getSut(true, $widget, new TestRenderer());
+        $options = ['foo' => 'bar', 'dataType' => 'blub'];
+        $result = $sut->renderWidget('test', $options);
+        $data = json_decode($result, true);
+        $this->assertEquals($options, $data);
+    }
+
+    public function testRenderWidgetObject()
+    {
+        $widget = new More();
+        $sut = $this->getSut(null, null, new TestRenderer());
+        $options = ['foo' => 'bar', 'dataType' => 'blub'];
+        $result = $sut->renderWidget($widget, $options);
+        $data = json_decode($result, true);
+        $this->assertEquals($options, $data);
+    }
+}
+
+class TestRenderer implements WidgetRendererInterface
+{
+    public function supports(WidgetInterface $widget): bool
+    {
+        return true;
+    }
+
+    public function render(WidgetInterface $widget, array $options = []): string
+    {
+        return json_encode($widget->getOptions($options));
+    }
+}