From 625ac2f1d72adf5ce321c198fd45309509945607 Mon Sep 17 00:00:00 2001 From: Kevin Papst Date: Thu, 4 Jul 2019 16:59:57 +0200 Subject: [PATCH] fix default calendar config (#918) --- src/DependencyInjection/Configuration.php | 2 +- tests/Controller/SystemConfigurationControllerTest.php | 2 +- tests/DependencyInjection/AppExtensionTest.php | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/DependencyInjection/Configuration.php b/src/DependencyInjection/Configuration.php index 66451ab9..72f2b5b2 100644 --- a/src/DependencyInjection/Configuration.php +++ b/src/DependencyInjection/Configuration.php @@ -265,7 +265,7 @@ class Configuration implements ConfigurationInterface ->addDefaultsIfNotSet() ->children() ->scalarNode('begin')->defaultValue('00:00')->end() - ->scalarNode('end')->defaultValue('24:00')->end() + ->scalarNode('end')->defaultValue('23:59')->end() ->end() ->end() ->arrayNode('google') diff --git a/tests/Controller/SystemConfigurationControllerTest.php b/tests/Controller/SystemConfigurationControllerTest.php index fac231fb..a3d163c2 100644 --- a/tests/Controller/SystemConfigurationControllerTest.php +++ b/tests/Controller/SystemConfigurationControllerTest.php @@ -232,7 +232,7 @@ class SystemConfigurationControllerTest extends ControllerBaseTest $this->assertEquals('08:00', $configService->find('calendar.businessHours.begin')); $this->assertEquals('20:00', $configService->find('calendar.businessHours.end')); $this->assertEquals('00:00', $configService->find('calendar.visibleHours.begin')); - $this->assertEquals('24:00', $configService->find('calendar.visibleHours.end')); + $this->assertEquals('23:59', $configService->find('calendar.visibleHours.end')); $form = $client->getCrawler()->filter('form[name=system_configuration_form_calendar]')->form(); $client->submit($form, [ diff --git a/tests/DependencyInjection/AppExtensionTest.php b/tests/DependencyInjection/AppExtensionTest.php index 24b0801d..6be21c7a 100644 --- a/tests/DependencyInjection/AppExtensionTest.php +++ b/tests/DependencyInjection/AppExtensionTest.php @@ -70,7 +70,7 @@ class AppExtensionTest extends TestCase ], 'visibleHours' => [ 'begin' => '00:00', - 'end' => '24:00', + 'end' => '23:59', ], 'google' => [ 'api_key' => null,