jjsm01/kimai2
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

improve equality detection of same user

Browse Source
This commit is contained in:
Kevin Papst
2024-06-15 11:40:28 +02:00
parent 8578bbe033
commit 72350b76c0
2 changed files with 13 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/Entity/User.php
View File

@@ -1026,7 +1026,11 @@ class User implements UserInterface, EquatableInterface, ThemeUserInterface, Pas
public function isEqualTo(UserInterface $user): bool public function isEqualTo(UserInterface $user): bool
{ {
if (!$user instanceof self) { if (!$user instanceof User) {
return false;
}
if ($this->id !== $user->getId()) {
return false; return false;
} }

8
tests/Entity/UserTest.php
View File

@@ -511,6 +511,14 @@ class UserTest extends TestCase
$sut2->setUserIdentifier('12345678'); $sut2->setUserIdentifier('12345678');
self::assertTrue($sut->isEqualTo($sut2)); self::assertTrue($sut->isEqualTo($sut2));
self::assertTrue($sut2->isEqualTo($sut)); self::assertTrue($sut2->isEqualTo($sut));
self::assertFalse($sut->isEnabled());
$sut->setEnabled(true);
self::assertFalse($sut->isEqualTo($sut2));
self::assertFalse($sut2->isEqualTo($sut));
$sut2->setEnabled(true);
self::assertTrue($sut->isEqualTo($sut2));
self::assertTrue($sut2->isEqualTo($sut));
} }
public function testSerialize(): void public function testSerialize(): void