support creating new roles (#1050)

tests/Mocks/Security/RoleServiceFactory.php

@@ -0,0 +1,31 @@
+<?php
+
+/*
+ * This file is part of the Kimai time-tracking app.
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
+namespace App\Tests\Mocks\Security;
+
+use App\Entity\User;
+use App\Security\RoleService;
+use App\Tests\Mocks\AbstractMockFactory;
+
+class RoleServiceFactory extends AbstractMockFactory
+{
+    public function create($roles = null): RoleService
+    {
+        if (null === $roles) {
+            $roles = [
+                User::ROLE_USER => [],
+                User::ROLE_TEAMLEAD => [User::ROLE_USER],
+                User::ROLE_ADMIN => [User::ROLE_TEAMLEAD],
+                User::ROLE_SUPER_ADMIN => [User::ROLE_ADMIN],
+            ];
+        }
+
+        return new RoleService($roles);
+    }
+}

tests/Validator/Constraints/RoleValidatorTest.php

@@ -10,6 +10,7 @@
 namespace App\Tests\Validator\Constraints;
 
 use App\Entity\User;
+use App\Tests\Mocks\Security\RoleServiceFactory;
 use App\Validator\Constraints\Role;
 use App\Validator\Constraints\RoleValidator;
 use Symfony\Component\Validator\Constraints\NotBlank;
@@ -22,7 +23,10 @@ class RoleValidatorTest extends ConstraintValidatorTestCase
 {
     protected function createValidator()
     {
-        return new RoleValidator();
+        $factory = new RoleServiceFactory($this);
+        $roleService = $factory->create();
+
+        return new RoleValidator($roleService);
     }
 
     public function getValidRoles()

tests/Voter/AbstractVoterTest.php

@@ -12,6 +12,7 @@ namespace App\Tests\Voter;
 use App\Entity\User;
 use App\Security\AclDecisionManager;
 use App\Security\RolePermissionManager;
+use App\Tests\Mocks\Security\RoleServiceFactory;
 use App\Voter\AbstractVoter;
 use PHPUnit\Framework\TestCase;
 
@@ -95,6 +96,9 @@ abstract class AbstractVoterTest extends TestCase
             ];
         }
 
-        return new RolePermissionManager($permissions);
+        $factory = new RoleServiceFactory($this);
+        $roleService = $factory->create();
+
+        return new RolePermissionManager($roleService, $permissions);
     }
 }