Refactor authentication system (#2602)

Make auth configuration available via UI, remove FOSUserBundle and SAML-Bundle dependency
2021-06-10 15:34:13 +02:00
parent 286b63e2c8
commit 7f20cb045c
155 changed files with 5590 additions and 1802 deletions
--- a/tests/Controller/Security/SecurityControllerTest.php
+++ b/tests/Controller/Security/SecurityControllerTest.php
@@ -0,0 +1,120 @@
+<?php
+
+/*
+ * This file is part of the Kimai time-tracking app.
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
+namespace App\Tests\Controller\Security;
+
+use App\Controller\Security\SecurityController;
+use App\Tests\Controller\ControllerBaseTest;
+use Symfony\Component\Security\Csrf\CsrfTokenManagerInterface;
+
+/**
+ * This test makes sure the login and registration work as expected.
+ * The logic is located in the FOSUserBundle and already tested, but we use a different layout.
+ *
+ * @group integration
+ */
+class SecurityControllerTest extends ControllerBaseTest
+{
+    public function testRootUrlIsRedirectedToLogin()
+    {
+        $client = self::createClient();
+        $client->request('GET', '/');
+
+        $this->assertIsRedirect($client, $this->createUrl('/homepage'));
+        $client->followRedirect();
+        $this->assertIsRedirect($client, $this->createUrl('/login'));
+    }
+
+    public function testLoginPageIsRendered()
+    {
+        $client = self::createClient();
+        $this->request($client, '/login');
+
+        $response = $client->getResponse();
+        $this->assertTrue($client->getResponse()->isSuccessful());
+
+        $content = $response->getContent();
+        $this->assertStringContainsString('<title>Kimai – Time Tracking</title>', $content);
+        $this->assertStringContainsString('<form action="/en/login_check" method="post">', $content);
+        $this->assertStringContainsString('<input type="text" name="_username"', $content);
+        $this->assertStringContainsString('<input name="_password" type="password"', $content);
+        $this->assertStringContainsString('<input id="remember_me" name="_remember_me" type="checkbox"', $content);
+        $this->assertStringContainsString('">Login</button>', $content);
+        $this->assertStringContainsString('<input type="hidden" name="_csrf_token" value="', $content);
+        $this->assertStringNotContainsString('<a href="/en/register/"', $content);
+        $this->assertStringNotContainsString('Register a new account', $content);
+    }
+
+    public function testLoginPositive()
+    {
+        $client = self::createClient();
+        $this->request($client, '/login');
+
+        $this->assertTrue($client->getResponse()->isSuccessful());
+
+        $form = $client->getCrawler()->filter('body form')->form();
+        $client->submit($form, [
+            '_username' => 'susan_super',
+            '_password' => 'kitten'
+        ]);
+
+        $this->assertIsRedirect($client); // redirect to root URL
+        $client->followRedirect();
+
+        $this->assertIsRedirect($client, '/homepage'); // redirect to homepage
+        $client->followRedirect();
+
+        $this->assertIsRedirect($client, '/timesheet/'); // redirect to configured start page
+        $client->followRedirect();
+
+        $this->assertTrue($client->getResponse()->isSuccessful());
+    }
+
+    public function testLoginNegative()
+    {
+        $client = self::createClient();
+        $this->request($client, '/login');
+
+        $this->assertTrue($client->getResponse()->isSuccessful());
+
+        $form = $client->getCrawler()->filter('body form')->form();
+        $client->submit($form, [
+            '_username' => 'susan_super',
+            '_password' => '1234567890'
+        ]);
+
+        $this->assertIsRedirect($client); // redirect to root URL
+        $client->followRedirect();
+
+        $this->assertTrue($client->getResponse()->isSuccessful());
+        self::assertStringContainsString('<div class="alert alert-danger">Invalid credentials.</div>', $client->getResponse()->getContent());
+    }
+
+    public function testCheckAction()
+    {
+        $this->expectException(\RuntimeException::class);
+        $this->expectExceptionMessage('You must configure the check path to be handled by the firewall using form_login in your security firewall configuration.');
+
+        $client = self::createClient(); // just to bootstrap the container
+        $csrf = $this->createMock(CsrfTokenManagerInterface::class);
+        $sut = new SecurityController($csrf);
+        $sut->checkAction();
+    }
+
+    public function testLogoutAction()
+    {
+        $this->expectException(\RuntimeException::class);
+        $this->expectExceptionMessage('You must activate the logout in your security firewall configuration.');
+
+        $client = self::createClient(); // just to bootstrap the container
+        $csrf = $this->createMock(CsrfTokenManagerInterface::class);
+        $sut = new SecurityController($csrf);
+        $sut->logoutAction();
+    }
+}