Refactor authentication system (#2602)

Make auth configuration available via UI, remove FOSUserBundle and SAML-Bundle dependency

tests/Security/DoctrineUserProviderTest.php

@@ -12,7 +12,6 @@ namespace App\Tests\Security;
 use App\Entity\User;
 use App\Repository\UserRepository;
 use App\Security\DoctrineUserProvider;
-use Hslavich\OneloginSamlBundle\Security\User\SamlUserInterface;
 use KevinPapst\AdminLTEBundle\Model\UserInterface;
 use PHPUnit\Framework\TestCase;
 use Symfony\Component\Security\Core\Exception\UnsupportedUserException;
@@ -59,8 +58,6 @@ class DoctrineUserProviderTest extends TestCase
         self::assertTrue($sut->supportsClass(User::class));
         self::assertTrue($sut->supportsClass('App\Entity\User'));
         self::assertFalse($sut->supportsClass(UserInterface::class));
-        self::assertFalse($sut->supportsClass(SamlUserInterface::class));
-        self::assertFalse($sut->supportsClass(\FOS\UserBundle\Model\User::class));
         self::assertFalse($sut->supportsClass(TestUserEntity::class));
     }
 
@@ -70,7 +67,6 @@ class DoctrineUserProviderTest extends TestCase
         $this->expectExceptionMessage('Expected an instance of App\Entity\User, but got "App\Tests\Security\TestUserEntity".');
 
         $user = new TestUserEntity();
-        $user->setUsername('foobar');
 
         $repository = $this->getMockBuilder(UserRepository::class)->disableOriginalConstructor()->getMock();
 

tests/Security/TestUserEntity.php

@@ -9,8 +9,31 @@
 
 namespace App\Tests\Security;
 
-use FOS\UserBundle\Model\User;
+use Symfony\Component\Security\Core\User\UserInterface;
 
-class TestUserEntity extends User
+class TestUserEntity implements UserInterface
 {
+    public function getRoles()
+    {
+        return [];
+    }
+
+    public function getPassword()
+    {
+        return null;
+    }
+
+    public function getSalt()
+    {
+        return null;
+    }
+
+    public function getUsername()
+    {
+        return 'foo';
+    }
+
+    public function eraseCredentials()
+    {
+    }
 }

tests/Security/TokenAuthenticatorTest.php

@@ -0,0 +1,75 @@
+<?php
+
+/*
+ * This file is part of the Kimai time-tracking app.
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
+namespace App\Tests\Security;
+
+use App\Security\TokenAuthenticator;
+use PHPUnit\Framework\TestCase;
+use Symfony\Component\HttpFoundation\Request;
+use Symfony\Component\Security\Core\Encoder\EncoderFactoryInterface;
+
+/**
+ * @covers \App\Security\TokenAuthenticator
+ */
+class TokenAuthenticatorTest extends TestCase
+{
+    public function testRememberMe()
+    {
+        $factory = $this->createMock(EncoderFactoryInterface::class);
+        $sut = new TokenAuthenticator($factory);
+
+        self::assertFalse($sut->supportsRememberMe());
+    }
+
+    public function testSupports()
+    {
+        $factory = $this->createMock(EncoderFactoryInterface::class);
+        $sut = new TokenAuthenticator($factory);
+
+        $request = new Request([], [], [], [], [], ['REQUEST_URI' => 'dfghj/api/doc/dfghj']);
+        self::assertFalse($sut->supports($request));
+
+        $request = new Request([], [], [], [], [], ['REQUEST_URI' => '/api/fooo']);
+        self::assertTrue($sut->supports($request));
+
+        $request = new Request([], [], [], [], [], ['REQUEST_URI' => '/api/fooo', 'HTTP_X-AUTH-SESSION' => true]);
+        self::assertFalse($sut->supports($request));
+    }
+
+    public function testGetPassword()
+    {
+        $factory = $this->createMock(EncoderFactoryInterface::class);
+        $sut = new TokenAuthenticator($factory);
+
+        self::assertNull($sut->getPassword('asdfgh'));
+        self::assertNull($sut->getPassword(null));
+        self::assertNull($sut->getPassword([]));
+        self::assertNull($sut->getPassword(['password' => '1234567890']));
+        self::assertNull($sut->getPassword(['token' => null]));
+        self::assertNull($sut->getPassword(['token' => 0]));
+        self::assertNull($sut->getPassword(['token' => '']));
+        self::assertNull($sut->getPassword(['token' => false]));
+        self::assertEquals('foo-bar', $sut->getPassword(['token' => 'foo-bar']));
+    }
+
+    public function testGetCredentials()
+    {
+        $factory = $this->createMock(EncoderFactoryInterface::class);
+        $sut = new TokenAuthenticator($factory);
+
+        $request = new Request([], [], [], [], [], ['REQUEST_URI' => '/api/fooo', 'HTTP_X-AUTH-SESSION' => true]);
+        self::assertEquals(['user' => null, 'token' => null], $sut->getCredentials($request));
+
+        $request = new Request([], [], [], [], [], ['REQUEST_URI' => '/api/fooo', 'HTTP_X-AUTH-USER' => 'foo']);
+        self::assertEquals(['user' => 'foo', 'token' => null], $sut->getCredentials($request));
+
+        $request = new Request([], [], [], [], [], ['REQUEST_URI' => '/api/fooo', 'HTTP_X-AUTH-USER' => 'foo', 'HTTP_X-AUTH-TOKEN' => 'bar']);
+        self::assertEquals(['user' => 'foo', 'token' => 'bar'], $sut->getCredentials($request));
+    }
+}