added configurable permission system (#424)

src/DependencyInjection/AppExtension.php

@@ -40,11 +40,43 @@ class AppExtension extends Extension implements PrependExtensionInterface
         $container->setParameter('kimai.invoice.documents', $config['invoice']['documents']);
         $container->setParameter('kimai.defaults', $config['defaults']);
 
+        $this->createPermissionParameter($config['permissions'], $container);
         $this->createThemeParameter($config['theme'], $container);
         $this->createUserParameter($config['user'], $container);
         $this->createTimesheetParameter($config['timesheet'], $container);
     }
 
+    /**
+     * Performs some pre-compilation on the configured permissions from kimai.yaml
+     * to save us from constant array lookups from during runtime.
+     *
+     * @param array $config
+     * @param ContainerBuilder $container
+     */
+    protected function createPermissionParameter(array $config, ContainerBuilder $container)
+    {
+        foreach ($config['maps'] as $role => $sets) {
+            if (!isset($config['roles'][$role])) {
+                $exception = new InvalidConfigurationException(
+                    'Configured permission set includes unknown role "' . $role . '"'
+                );
+                $exception->setPath('kimai.permissions.maps.' . $role);
+                throw $exception;
+            }
+            foreach ($sets as $set) {
+                if (!isset($config['sets'][$set])) {
+                    $exception = new InvalidConfigurationException(
+                        'Configured permission set "' . $set . '" for role "' . $role . '" is unknown'
+                    );
+                    $exception->setPath('kimai.permissions.maps.' . $role);
+                    throw $exception;
+                }
+                $config['roles'][$role] = array_unique(array_merge($config['roles'][$role], $config['sets'][$set]));
+            }
+        }
+        $container->setParameter('kimai.permissions', $config['roles']);
+    }
+
     /**
      * @param array $config
      * @param ContainerBuilder $container

src/DependencyInjection/Compiler/DoctrineCompilerPass.php

@@ -23,8 +23,6 @@ class DoctrineCompilerPass implements CompilerPassInterface
      */
     protected $allowedEngines = [
         'mysql',
-        'oracle',
-        'postgres',
         'sqlite'
     ];
 
@@ -37,15 +35,6 @@ class DoctrineCompilerPass implements CompilerPassInterface
     {
         $engine = null;
 
-        // TODO - this does return the wrong connection. it used to be mysql, even if
-        // TODO - getenv('DATABASE_URL') returned an sqlite:// connection string
-        /*
-        $dbConfig = $container->getExtensionConfig('doctrine');
-        if (isset($dbConfig[0]['dbal']['driver'])) {
-            $engine = str_replace('pdo_', '', $dbConfig[0]['dbal']['driver']);
-        }
-        */
-
         if (null === $engine) {
             $dbConfig = explode('://', getenv('DATABASE_URL'));
             $engine = $dbConfig['0'] ?: null;

src/DependencyInjection/Configuration.php

@@ -40,6 +40,7 @@ class Configuration implements ConfigurationInterface
                 ->append($this->getDashboardNode())
                 ->append($this->getWidgetsNode())
                 ->append($this->getDefaultsNode())
+                ->append($this->getPermissionsNode())
             ->end()
         ->end();
 
@@ -329,4 +330,51 @@ class Configuration implements ConfigurationInterface
 
         return $node;
     }
+
+    protected function getPermissionsNode()
+    {
+        $builder = new TreeBuilder();
+        $node = $builder->root('permissions');
+
+        $node
+            ->addDefaultsIfNotSet()
+            ->children()
+                ->arrayNode('sets')
+                    ->requiresAtLeastOneElement()
+                    ->useAttributeAsKey('key')
+                    ->performNoDeepMerging()
+                    ->arrayPrototype()
+                        ->useAttributeAsKey('key')
+                        ->isRequired()
+                        ->prototype('scalar')->end()
+                        ->defaultValue([])
+                    ->end()
+                ->end()
+                ->arrayNode('maps')
+                    ->requiresAtLeastOneElement()
+                    ->useAttributeAsKey('key')
+                    ->performNoDeepMerging()
+                    ->arrayPrototype()
+                        ->useAttributeAsKey('key')
+                        ->isRequired()
+                        ->prototype('scalar')->end()
+                        ->defaultValue([])
+                    ->end()
+                ->end()
+                ->arrayNode('roles')
+                    ->requiresAtLeastOneElement()
+                    ->useAttributeAsKey('key')
+                    ->performNoDeepMerging()
+                    ->arrayPrototype()
+                        ->useAttributeAsKey('key')
+                        ->isRequired()
+                        ->prototype('scalar')->end()
+                        ->defaultValue([])
+                    ->end()
+                ->end()
+            ->end()
+        ;
+
+        return $node;
+    }
 }