fix deleting invoice documents (#2980)

2021-11-29 15:57:39 +01:00
parent d994339de5
commit 9491f07ade
3 changed files with 9 additions and 5 deletions
--- a/src/Repository/InvoiceDocumentRepository.php
+++ b/src/Repository/InvoiceDocumentRepository.php
@@ -55,7 +55,11 @@ final class InvoiceDocumentRepository
     */
    public function remove(InvoiceDocument $invoiceDocument): void
    {
-        @unlink($invoiceDocument->getFilename());
+        if (stripos($invoiceDocument->getFilename(), $this->getUploadDirectory()) === false) {
+            throw new \InvalidArgumentException('Cannot delete built-in invoice template');
+        }
+
+        @unlink(realpath($invoiceDocument->getFilename()));
    }

    /**