Update and delete multi timesheets and tags (#1240)

2019-11-15 01:25:31 +01:00
parent b4739f8f03
commit 94c28ebbc5
49 changed files with 1836 additions and 307 deletions
--- a/src/Controller/TagController.php
+++ b/src/Controller/TagController.php
@@ -10,12 +10,15 @@
 namespace App\Controller;

 use App\Entity\Tag;
+use App\Form\MultiUpdate\MultiUpdateTable;
+use App\Form\MultiUpdate\MultiUpdateTableDTO;
 use App\Form\TagEditForm;
 use App\Form\Toolbar\TagToolbarForm;
 use App\Repository\Query\TagQuery;
 use App\Repository\TagRepository;
 use Doctrine\ORM\ORMException;
 use Sensio\Bundle\FrameworkExtraBundle\Configuration\Security;
+use Symfony\Component\Form\FormInterface;
 use Symfony\Component\HttpFoundation\Request;
 use Symfony\Component\HttpFoundation\Response;
 use Symfony\Component\Routing\Annotation\Route;
@@ -54,6 +57,7 @@ class TagController extends AbstractController
            'tags' => $tags,
            'query' => $query,
            'toolbarForm' => $form->createView(),
+            'multiUpdateForm' => $this->getMultiUpdateForm($repository)->createView(),
        ]);
    }

@@ -119,6 +123,41 @@ class TagController extends AbstractController
        ]);
    }

+    /**
+     * @Route(path="/multi-delete", name="tags_multi_delete", methods={"POST"})
+     * @Security("is_granted('delete_tag')")
+     */
+    public function multiDelete(TagRepository $repository, Request $request)
+    {
+        $form = $this->getMultiUpdateForm($repository);
+        $form->handleRequest($request);
+
+        if ($form->isSubmitted() && $form->isValid()) {
+            try {
+                /** @var MultiUpdateTableDTO $dto */
+                $dto = $form->getData();
+                $repository->multiDelete($dto->getEntities());
+                $this->flashSuccess('action.delete.success');
+            } catch (\Exception $ex) {
+                $this->flashError('action.delete.error', ['%reason%' => $ex->getMessage()]);
+            }
+        }
+
+        return $this->redirectToRoute('tags');
+    }
+
+    protected function getMultiUpdateForm(TagRepository $repository): FormInterface
+    {
+        $dto = new MultiUpdateTableDTO();
+        $dto->addDelete($this->generateUrl('tags_multi_delete'));
+
+        return $this->createForm(MultiUpdateTable::class, $dto, [
+            'action' => $this->generateUrl('tags'),
+            'repository' => $repository,
+            'method' => 'POST',
+        ]);
+    }
+
    /**
     * @param TagQuery $query
     * @return \Symfony\Component\Form\FormInterface
--- a/src/Controller/TimesheetAbstractController.php
+++ b/src/Controller/TimesheetAbstractController.php
@@ -16,6 +16,10 @@ use App\Entity\Timesheet;
 use App\Event\TimesheetMetaDefinitionEvent;
 use App\Event\TimesheetMetaDisplayEvent;
 use App\Export\ServiceExport;
+use App\Form\MultiUpdate\MultiUpdateTable;
+use App\Form\MultiUpdate\MultiUpdateTableDTO;
+use App\Form\MultiUpdate\TimesheetMultiUpdate;
+use App\Form\MultiUpdate\TimesheetMultiUpdateDTO;
 use App\Form\TimesheetEditForm;
 use App\Form\Toolbar\TimesheetToolbarForm;
 use App\Repository\ActivityRepository;
@@ -130,6 +134,7 @@ abstract class TimesheetAbstractController extends AbstractController
            'page' => $query->getPage(),
            'query' => $query,
            'toolbarForm' => $form->createView(),
+            'multiUpdateForm' => $this->getMultiUpdateActionForm()->createView(),
            'showSummary' => $this->includeSummary(),
            'showStartEndTime' => $this->canSeeStartEndTime(),
            'metaColumns' => $this->findMetaColumns($query, $location),
@@ -174,6 +179,24 @@ abstract class TimesheetAbstractController extends AbstractController
        ]);
    }

+    protected function getTags(TagRepository $tagRepository, $tagNames)
+    {
+        $tags = [];
+        if (!is_array($tagNames)) {
+            $tagNames = explode(',', $tagNames);
+        }
+        foreach ($tagNames as $tagName) {
+            $tag = $tagRepository->findTagByName($tagName);
+            if (!$tag) {
+                $tag = new Tag();
+                $tag->setName($tagName);
+            }
+            $tags[] = $tag;
+        }
+
+        return $tags;
+    }
+
    protected function create(Request $request, string $renderTemplate, ProjectRepository $projectRepository, ActivityRepository $activityRepository, TagRepository $tagRepository): Response
    {
        $entry = new Timesheet();
@@ -190,13 +213,7 @@ abstract class TimesheetAbstractController extends AbstractController
        }

        if ($request->query->get('tags')) {
-            $tagNames = explode(',', $request->query->get('tags'));
-            foreach ($tagNames as $tagName) {
-                $tag = $tagRepository->findTagByName($tagName);
-                if (!$tag) {
-                    $tag = new Tag();
-                    $tag->setName($tagName);
-                }
+            foreach ($this->getTags($tagRepository, $request->query->get('tags')) as $tag) {
                $entry->addTag($tag);
            }
        }
@@ -267,11 +284,142 @@ abstract class TimesheetAbstractController extends AbstractController
        return $exporter->render($entries, $query);
    }

+    protected function multiUpdate(Request $request, string $renderTemplate)
+    {
+        $dto = new TimesheetMultiUpdateDTO();
+
+        // initial request from the listing posts a different form
+        $form = $this->getMultiUpdateActionForm();
+        $form->handleRequest($request);
+        if ($form->isSubmitted() && $form->isValid()) {
+            $dto->setEntities($form->getData()->getEntities());
+        }
+
+        $form = $this->getMultiUpdateForm($dto);
+        $form->handleRequest($request);
+
+        // remove all, which are not allowed to be edited
+        $timesheets = [];
+        /** @var Timesheet $timesheet */
+        foreach ($dto->getEntities() as $timesheet) {
+            if (!$this->isGranted('edit', $timesheet)) {
+                continue;
+            }
+            $timesheets[] = $timesheet;
+        }
+        $dto->setEntities($timesheets);
+
+        if (count($dto->getEntities()) === 0) {
+            return $this->redirectToRoute($this->getTimesheetRoute());
+        }
+
+        if ($form->isSubmitted() && $form->isValid()) {
+            /** @var Timesheet $timesheet */
+            $execute = false;
+            foreach ($dto->getEntities() as $timesheet) {
+                if ($dto->isReplaceTags()) {
+                    foreach ($timesheet->getTags() as $tag) {
+                        $timesheet->removeTag($tag);
+                    }
+                    $execute = true;
+                }
+                foreach ($dto->getTags() as $tag) {
+                    $timesheet->addTag($tag);
+                    $execute = true;
+                }
+                if (null !== $dto->getActivity()) {
+                    $timesheet->setActivity($dto->getActivity());
+                    $execute = true;
+                }
+                if (null !== $dto->getProject()) {
+                    $timesheet->setProject($dto->getProject());
+                    $execute = true;
+                }
+                if (null !== $dto->getUser()) {
+                    $timesheet->setUser($dto->getUser());
+                    $execute = true;
+                }
+                if (null !== $dto->isExported()) {
+                    $timesheet->setExported($dto->isExported());
+                    $execute = true;
+                }
+            }
+
+            if ($execute) {
+                try {
+                    $this->repository->saveMultiple($dto->getEntities());
+                    $this->flashSuccess('action.update.success');
+
+                    return $this->redirectToRoute($this->getTimesheetRoute());
+                } catch (\Exception $ex) {
+                    $this->flashError('action.update.error', ['%reason%' => $ex->getMessage()]);
+                }
+            }
+        }
+
+        return $this->render($renderTemplate, [
+            'form' => $form->createView(),
+            'dto' => $dto,
+        ]);
+    }
+
+    protected function multiDelete(Request $request)
+    {
+        $form = $this->getMultiUpdateActionForm();
+        $form->handleRequest($request);
+
+        if ($form->isSubmitted() && $form->isValid()) {
+            $dto = $form->getData();
+            $timesheets = [];
+            /** @var Timesheet $timesheet */
+            foreach ($dto->getEntities() as $timesheet) {
+                if (!$this->isGranted('delete', $timesheet)) {
+                    continue;
+                }
+                $timesheets[] = $timesheet;
+            }
+            $dto->setEntities($timesheets);
+
+            try {
+                $this->repository->deleteMultiple($dto->getEntities());
+                $this->flashSuccess('action.delete.success');
+            } catch (\Exception $ex) {
+                $this->flashError('action.delete.error', ['%reason%' => $ex->getMessage()]);
+            }
+        }
+
+        return $this->redirectToRoute($this->getTimesheetRoute());
+    }
+
    protected function prepareQuery(TimesheetQuery $query)
    {
        $query->setUser($this->getUser());
    }

+    protected function getMultiUpdateForm(TimesheetMultiUpdateDTO $multiUpdate): FormInterface
+    {
+        return  $this->createForm(TimesheetMultiUpdate::class, $multiUpdate, [
+            'action' => $this->generateUrl($this->getMultiUpdateRoute(), []),
+            'method' => 'POST',
+            'include_exported' => $this->isGranted($this->getPermissionEditExport()),
+            'include_user' => $this->includeUserInForms(),
+        ]);
+    }
+
+    protected function getMultiUpdateActionForm(): FormInterface
+    {
+        $dto = new MultiUpdateTableDTO();
+
+        $dto->addUpdate($this->generateUrl($this->getMultiUpdateRoute()));
+        $dto->addDelete($this->generateUrl($this->getMultiDeleteRoute()));
+
+        return $this->createForm(MultiUpdateTable::class, $dto, [
+            'action' => $this->generateUrl($this->getTimesheetRoute()),
+            'repository' => $this->getRepository(),
+            'method' => 'POST',
+        ]);
+    }
+
    protected function getCreateForm(Timesheet $entry, TrackingModeInterface $mode): FormInterface
    {
        return $this->createForm($this->getCreateFormClassName(), $entry, [
@@ -325,6 +473,11 @@ abstract class TimesheetAbstractController extends AbstractController
        ]);
    }

+    protected function getPermissionEditExport(): string
+    {
+        return 'edit_export_own_timesheet';
+    }
+
    protected function getCreateFormClassName(): string
    {
        return TimesheetEditForm::class;
@@ -360,6 +513,16 @@ abstract class TimesheetAbstractController extends AbstractController
        return 'timesheet_create';
    }

+    protected function getMultiUpdateRoute(): string
+    {
+        return 'timesheet_multi_update';
+    }
+
+    protected function getMultiDeleteRoute(): string
+    {
+        return 'timesheet_multi_delete';
+    }
+
    protected function canSeeStartEndTime(): bool
    {
        return $this->getTrackingMode()->canSeeBeginAndEndTimes();
--- a/src/Controller/TimesheetController.php
+++ b/src/Controller/TimesheetController.php
@@ -65,6 +65,24 @@ class TimesheetController extends TimesheetAbstractController
        return $this->edit($entry, $request, 'timesheet/edit.html.twig');
    }

+    /**
+     * @Route(path="/multi-update", name="timesheet_multi_update", methods={"POST"})
+     * @Security("is_granted('edit_own_timesheet')")
+     */
+    public function multiUpdateAction(Request $request)
+    {
+        return $this->multiUpdate($request, 'timesheet/multi-update.html.twig');
+    }
+
+    /**
+     * @Route(path="/multi-delete", name="timesheet_multi_delete", methods={"POST"})
+     * @Security("is_granted('delete_own_timesheet')")
+     */
+    public function multiDeleteAction(Request $request)
+    {
+        return $this->multiDelete($request);
+    }
+
    /**
     * @Route(path="/create", name="timesheet_create", methods={"GET", "POST"})
     * @Security("is_granted('create_own_timesheet')")
--- a/src/Controller/TimesheetTeamController.php
+++ b/src/Controller/TimesheetTeamController.php
@@ -80,11 +80,34 @@ class TimesheetTeamController extends TimesheetAbstractController
        return $this->create($request, 'timesheet-team/edit.html.twig', $projectRepository, $activityRepository, $tagRepository);
    }

+    /**
+     * @Route(path="/multi-update", name="admin_timesheet_multi_update", methods={"POST"})
+     * @Security("is_granted('edit_other_timesheet')")
+     */
+    public function multiUpdateAction(Request $request)
+    {
+        return $this->multiUpdate($request, 'timesheet-team/multi-update.html.twig');
+    }
+
+    /**
+     * @Route(path="/multi-delete", name="admin_timesheet_multi_delete", methods={"POST"})
+     * @Security("is_granted('delete_other_timesheet')")
+     */
+    public function multiDeleteAction(Request $request)
+    {
+        return $this->multiDelete($request);
+    }
+
    protected function prepareQuery(TimesheetQuery $query)
    {
        $query->setCurrentUser($this->getUser());
    }

+    protected function getPermissionEditExport(): string
+    {
+        return 'edit_export_other_timesheet';
+    }
+
    protected function getCreateFormClassName(): string
    {
        return TimesheetAdminEditForm::class;
@@ -115,6 +138,16 @@ class TimesheetTeamController extends TimesheetAbstractController
        return 'admin_timesheet_create';
    }

+    protected function getMultiUpdateRoute(): string
+    {
+        return 'admin_timesheet_multi_update';
+    }
+
+    protected function getMultiDeleteRoute(): string
+    {
+        return 'admin_timesheet_multi_delete';
+    }
+
    protected function canSeeStartEndTime(): bool
    {
        return true;