added drag and drop for new records via calendar (#1962)

src/Validator/Constraints/TimesheetFutureTimesValidator.php

@@ -45,9 +45,11 @@ final class TimesheetFutureTimesValidator extends ConstraintValidator
             return;
         }
 
+        $now = new \DateTime('now', $timesheet->getBegin()->getTimezone());
+
         // allow configured default rounding time + 1 minute - see #1295
         $allowedDiff = ($this->configuration->getDefaultRoundingBegin() * 60) + 60;
-        if ((time() + $allowedDiff) < $timesheet->getBegin()->getTimestamp()) {
+        if (($now->getTimestamp() + $allowedDiff) < $timesheet->getBegin()->getTimestamp()) {
             $this->context->buildViolation('The begin date cannot be in the future.')
                 ->atPath('begin')
                 ->setTranslationDomain('validators')

src/Validator/Constraints/TimesheetOverlappingValidator.php

@@ -47,6 +47,14 @@ final class TimesheetOverlappingValidator extends ConstraintValidator
             throw new UnexpectedTypeException($timesheet, TimesheetEntity::class);
         }
 
+        $begin = $timesheet->getBegin();
+        $end = $timesheet->getEnd();
+
+        // this case is handled in TimesheetValidator and should not raise a second validation
+        if ($begin !== null && $end !== null && $begin > $end) {
+            return;
+        }
+
         if ($this->configuration->isAllowOverlappingRecords()) {
             return;
         }

src/Validator/Constraints/TimesheetValidator.php

@@ -72,7 +72,10 @@ final class TimesheetValidator extends ConstraintValidator
      */
     protected function validateBeginAndEnd(TimesheetEntity $timesheet, ExecutionContextInterface $context)
     {
-        if (null === $timesheet->getBegin()) {
+        $begin = $timesheet->getBegin();
+        $end = $timesheet->getEnd();
+
+        if (null === $begin) {
             $context->buildViolation('You must submit a begin date.')
                 ->atPath('begin')
                 ->setTranslationDomain('validators')
@@ -82,7 +85,7 @@ final class TimesheetValidator extends ConstraintValidator
             return;
         }
 
-        if (null !== $timesheet->getBegin() && null !== $timesheet->getEnd() && $timesheet->getEnd()->getTimestamp() < $timesheet->getBegin()->getTimestamp()) {
+        if (null !== $end && $begin > $end) {
             $context->buildViolation('End date must not be earlier then start date.')
                 ->atPath('end')
                 ->setTranslationDomain('validators')

src/Validator/ValidationException.php

@@ -0,0 +1,21 @@
+<?php
+
+/*
+ * This file is part of the Kimai time-tracking app.
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
+namespace App\Validator;
+
+class ValidationException extends \RuntimeException
+{
+    public function __construct(string $message = null)
+    {
+        if ($message === null) {
+            $message = 'Validation failed';
+        }
+        parent::__construct($message, 400);
+    }
+}

src/Validator/ValidationFailedException.php

@@ -0,0 +1,35 @@
+<?php
+
+/*
+ * This file is part of the Kimai time-tracking app.
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
+namespace App\Validator;
+
+use Symfony\Component\Validator\ConstraintViolationListInterface;
+
+class ValidationFailedException extends \RuntimeException
+{
+    /**
+     * @var ConstraintViolationListInterface
+     */
+    private $violations;
+
+    public function __construct(ConstraintViolationListInterface $violations, ?string $message = null)
+    {
+        if ($message === null) {
+            $message = 'Validation failed';
+        }
+        parent::__construct($message, 400);
+
+        $this->violations = $violations;
+    }
+
+    public function getViolations(): ConstraintViolationListInterface
+    {
+        return $this->violations;
+    }
+}