jjsm01/kimai2
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

use default_begin in duration only mode (#873)

Browse Source
This commit is contained in:
Kevin Papst
2019-06-20 01:38:28 +02:00
committed by GitHub
parent dcdbf23b6d
commit bdd05a275d
3 changed files with 30 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
tests/Timesheet/TrackingMode/AbstractTrackingModeTest.php
View File

@@ -24,6 +24,11 @@ abstract class AbstractTrackingModeTest extends TestCase
*/
abstract protected function createSut();
protected function assertDefaultBegin(Timesheet $timesheet)
{
self::assertNull($timesheet->getBegin());
}
public function testCreateDoesNotChangeAnythingOnEmptyRequest()
{
$sut = $this->createSut();
@@ -35,7 +40,7 @@ abstract class AbstractTrackingModeTest extends TestCase
$sut->create($timesheet, new Request());
self::assertNull($timesheet->getBegin());
$this->assertDefaultBegin($timesheet);
self::assertNull($timesheet->getEnd());
}
@@ -88,7 +93,7 @@ abstract class AbstractTrackingModeTest extends TestCase
$sut->create($timesheet, $request);
self::assertNull($timesheet->getBegin());
$this->assertDefaultBegin($timesheet);
self::assertNull($timesheet->getEnd());
self::assertEquals(0, $timesheet->getDuration());
}
@@ -181,7 +186,7 @@ abstract class AbstractTrackingModeTest extends TestCase
$sut->create($timesheet, $request);
self::assertNull($timesheet->getBegin());
$this->assertDefaultBegin($timesheet);
self::assertNull($timesheet->getEnd());
self::assertEquals(0, $timesheet->getDuration());
}

9
tests/Timesheet/TrackingMode/DurationOnlyModeTest.php
View File

@@ -10,6 +10,7 @@
namespace App\Tests\Timesheet\TrackingMode;
use App\Configuration\TimesheetConfiguration;
use App\Entity\Timesheet;
use App\Tests\Configuration\TestConfigLoader;
use App\Tests\Mocks\Security\UserDateTimeFactoryFactory;
use App\Timesheet\TrackingMode\DurationOnlyMode;
@@ -19,11 +20,17 @@ use App\Timesheet\TrackingMode\DurationOnlyMode;
*/
class DurationOnlyModeTest extends AbstractTrackingModeTest
{
protected function assertDefaultBegin(Timesheet $timesheet)
{
self::assertNotNull($timesheet->getBegin());
self::assertEquals('13:45:37', $timesheet->getBegin()->format('H:i:s'));
}
protected function createSut()
{
$loader = new TestConfigLoader([]);
$dateTime = (new UserDateTimeFactoryFactory($this))->create();
$configuration = new TimesheetConfiguration($loader, []);
$configuration = new TimesheetConfiguration($loader, ['default_begin' => '13:45:37']);
return new DurationOnlyMode($dateTime, $configuration);
}