cleanup for 1.10 (#1906)

This commit is contained in:
Kevin Papst
2020-08-22 19:15:54 +02:00
committed by GitHub
parent 064d083db6
commit c2c4f087e4
26 changed files with 66 additions and 13 deletions

View File

@@ -29,7 +29,12 @@ abstract class AbstractMergedCalculator extends AbstractCalculator
$this->mergeInvoiceItems($invoiceItem, $entry);
}
protected function mergeInvoiceItems(InvoiceItem $invoiceItem, InvoiceItemInterface $entry)
/**
* @param InvoiceItem $invoiceItem
* @param InvoiceItemInterface $entry
* @return void
*/
protected function mergeInvoiceItems(InvoiceItem $invoiceItem, InvoiceItemInterface $entry) /* : void */
{
$duration = $invoiceItem->getDuration();
if (null !== $entry->getDuration()) {

View File

@@ -53,7 +53,12 @@ abstract class AbstractSumInvoiceCalculator extends AbstractMergedCalculator imp
return array_values($invoiceItems);
}
protected function mergeSumInvoiceItem(InvoiceItem $invoiceItem, InvoiceItemInterface $entry)
/**
* @param InvoiceItem $invoiceItem
* @param InvoiceItemInterface $entry
* @return void
*/
protected function mergeSumInvoiceItem(InvoiceItem $invoiceItem, InvoiceItemInterface $entry) /* : void */
{
if (method_exists($this, 'mergeSumTimesheet')) {
@trigger_error('mergeSumTimesheet() is deprecated and will be removed with 2.0 - use mergeSumInvoiceItem() instead', E_USER_DEPRECATED);

View File

@@ -13,9 +13,6 @@ use App\Entity\Activity;
use App\Entity\Project;
use App\Entity\User;
/**
* @internal
*/
final class InvoiceItem
{
/**

View File

@@ -15,8 +15,9 @@ interface InvoiceItemRepositoryInterface
{
/**
* @param InvoiceItemInterface[] $invoiceItems
* @return void
*/
public function setExported(array $invoiceItems);
public function setExported(array $invoiceItems) /* : void */;
/**
* @param InvoiceQuery $query