API improvements (#1826)

src/API/Model/TimesheetConfig.php

@@ -11,53 +11,74 @@ declare(strict_types=1);
 
 namespace App\API\Model;
 
+use JMS\Serializer\Annotation as Serializer;
+
+/**
+ * @Serializer\ExclusionPolicy("none")
+ */
 final class TimesheetConfig
 {
     /**
-     * See here: https://www.kimai.org/documentation/timesheet.html#tracking-modes
+     * The time-tracking mode, see also: https://www.kimai.org/documentation/timesheet.html#tracking-modes
      *
      * @var string
+     *
+     * @Serializer\Expose()
+     * @Serializer\Groups({"Default"})
+     * @Serializer\Type(name="string")
      */
     private $trackingMode = 'default';
     /**
      * Default begin datetime in PHP format
      *
      * @var string
+     *
+     * @Serializer\Expose()
+     * @Serializer\Groups({"Default"})
+     * @Serializer\Type(name="string")
      */
     private $defaultBeginTime = 'now';
     /**
      * How many running timesheets a user is allowed to have at the same time
      *
      * @var int
+     *
+     * @Serializer\Expose()
+     * @Serializer\Groups({"Default"})
+     * @Serializer\Type(name="integer")
      */
     private $activeEntriesHardLimit = 1;
     /**
      * How many running timesheets a user is allowed before a warning is shown
      *
      * @var int
+     *
+     * @Serializer\Expose()
+     * @Serializer\Groups({"Default"})
+     * @Serializer\Type(name="integer")
      */
     private $activeEntriesSoftLimit = 1;
     /**
      * Whether entries for future times are allowed
      *
      * @var bool
+     *
+     * @Serializer\Expose()
+     * @Serializer\Groups({"Default"})
+     * @Serializer\Type(name="boolean")
      */
     private $isAllowFutureTimes = true;
     /**
      * Whether overlapping entries are allowed
      *
      * @var bool
+     *
+     * @Serializer\Expose()
+     * @Serializer\Groups({"Default"})
+     * @Serializer\Type(name="boolean")
      */
     private $isAllowOverlapping = true;
 
-    /**
-     * @return string
-     */
-    public function getTrackingMode(): string
-    {
-        return $this->trackingMode;
-    }
-
     public function setTrackingMode(string $trackingMode): TimesheetConfig
     {
         $this->trackingMode = $trackingMode;
@@ -65,11 +86,6 @@ final class TimesheetConfig
         return $this;
     }
 
-    public function getDefaultBeginTime(): string
-    {
-        return $this->defaultBeginTime;
-    }
-
     public function setDefaultBeginTime(string $defaultBeginTime): TimesheetConfig
     {
         $this->defaultBeginTime = $defaultBeginTime;
@@ -77,11 +93,6 @@ final class TimesheetConfig
         return $this;
     }
 
-    public function getActiveEntriesHardLimit(): int
-    {
-        return $this->activeEntriesHardLimit;
-    }
-
     public function setActiveEntriesHardLimit(int $activeEntriesHardLimit): TimesheetConfig
     {
         $this->activeEntriesHardLimit = $activeEntriesHardLimit;
@@ -89,11 +100,6 @@ final class TimesheetConfig
         return $this;
     }
 
-    public function getActiveEntriesSoftLimit(): int
-    {
-        return $this->activeEntriesSoftLimit;
-    }
-
     public function setActiveEntriesSoftLimit(int $activeEntriesSoftLimit): TimesheetConfig
     {
         $this->activeEntriesSoftLimit = $activeEntriesSoftLimit;
@@ -101,11 +107,6 @@ final class TimesheetConfig
         return $this;
     }
 
-    public function isAllowFutureTimes(): bool
-    {
-        return $this->isAllowFutureTimes;
-    }
-
     public function setIsAllowFutureTimes(bool $isAllowFutureTimes): TimesheetConfig
     {
         $this->isAllowFutureTimes = $isAllowFutureTimes;
@@ -113,11 +114,6 @@ final class TimesheetConfig
         return $this;
     }
 
-    public function isAllowOverlapping(): bool
-    {
-        return $this->isAllowOverlapping;
-    }
-
     public function setIsAllowOverlapping(bool $isAllowOverlapping): TimesheetConfig
     {
         $this->isAllowOverlapping = $isAllowOverlapping;