API improvements (#1826)

This commit is contained in:
Kevin Papst
2020-07-17 20:30:16 +02:00
committed by GitHub
parent 5864c7e127
commit c843dba29a
77 changed files with 1745 additions and 1189 deletions

View File

@@ -100,4 +100,67 @@ class SecurityControllerTest extends ControllerBaseTest
$this->assertStringContainsString('<p>Congrats example, your account is now activated.</p>', $content);
$this->assertStringContainsString('<a href="/en/homepage">', $content);
}
/**
* @dataProvider getValidationTestData
*/
public function testRegisterActionWithValidationProblems(array $formData, array $validationFields)
{
$client = self::createClient();
$this->assertHasValidationError($client, '/register/', 'form[name=fos_user_registration_form]', $formData, $validationFields);
}
public function getValidationTestData()
{
return [
[
// invalid fields: username, password_second, email
[
'fos_user_registration_form' => [
'username' => '',
'plainPassword' => ['first' => 'sdfsdf123'],
'email' => '',
]
],
[
'#fos_user_registration_form_username',
'#fos_user_registration_form_username',
'#fos_user_registration_form_plainPassword_first',
'#fos_user_registration_form_email',
'#fos_user_registration_form_email',
]
],
// invalid fields: username, password, email
[
[
'fos_user_registration_form' => [
'username' => 'x',
'plainPassword' => ['first' => 'sdfsdf123', 'second' => 'sdfxxxxxxx'],
'email' => 'ydfbvsdfgs',
]
],
[
'#fos_user_registration_form_username',
'#fos_user_registration_form_username',
'#fos_user_registration_form_plainPassword_first',
'#fos_user_registration_form_email',
'#fos_user_registration_form_email',
]
],
// invalid fields: password (too short)
[
[
'fos_user_registration_form' => [
'username' => 'test123',
'plainPassword' => ['first' => 'test123', 'second' => 'test123'],
'email' => 'ydfbvsdfgs@example.com',
]
],
[
'#fos_user_registration_form_plainPassword_first',
]
],
];
}
}

View File

@@ -76,7 +76,7 @@ class UserControllerTest extends ControllerBaseTest
'user_create' => [
'username' => $username,
'alias' => $username,
'plainPassword' => ['first' => 'abcdef', 'second' => 'abcdef'],
'plainPassword' => ['first' => '12345678', 'second' => '12345678'],
'email' => 'foobar@example.com',
'enabled' => 1,
]
@@ -198,7 +198,7 @@ class UserControllerTest extends ControllerBaseTest
[
'user_create' => [
'username' => '',
'plainPassword' => ['first' => 'sdfsdf'],
'plainPassword' => ['first' => 'sdfsdf123'],
'alias' => 'ycvyxcb',
'title' => '34rtwrtewrt',
'avatar' => 'asdfawer',
@@ -216,7 +216,7 @@ class UserControllerTest extends ControllerBaseTest
[
'user_create' => [
'username' => 'x',
'plainPassword' => ['first' => 'sdfsdf', 'second' => 'sdfxxx'],
'plainPassword' => ['first' => 'sdfsdf123', 'second' => 'sdfxxxxxxx'],
'alias' => 'ycvyxcb',
'title' => '34rtwrtewrt',
'avatar' => 'asdfawer',
@@ -229,6 +229,22 @@ class UserControllerTest extends ControllerBaseTest
'#user_create_email',
]
],
// invalid fields: password (too short)
[
[
'user_create' => [
'username' => 'test123',
'plainPassword' => ['first' => 'test123', 'second' => 'test123'],
'alias' => 'ycvyxcb',
'title' => '34rtwrtewrt',
'avatar' => 'asdfawer',
'email' => 'ydfbvsdfgs@example.com',
]
],
[
'#user_create_plainPassword_first',
]
],
];
}
}