jjsm01/kimai2
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

improved code styles #158 (#172)

Browse Source 
* use php-cs-fixer instead of phpcodesniffer
* updated scrutinizer config
* adjusted code yules to all files
* updated CONTRIBUTING guidelines
This commit is contained in:
Kevin Papst
2018-06-22 21:09:10 +02:00
committed by GitHub
parent 773d27bb0e
commit cd7cbeae88
142 changed files with 775 additions and 467 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
tests/Controller/ControllerBaseTest.php
View File

@@ -13,14 +13,14 @@ use App\DataFixtures\AppFixtures;
use App\Entity\User;
use Symfony\Bundle\FrameworkBundle\Client;
use Symfony\Bundle\FrameworkBundle\Test\WebTestCase;
use Symfony\Component\HttpFoundation\RedirectResponse;
/**
* ControllerBaseTest adds some useful functions for writing integration tests.
*/
abstract class ControllerBaseTest extends WebTestCase
{
const DEFAULT_LANGUAGE = 'en';
public const DEFAULT_LANGUAGE = 'en';
/**
* @param string $role
@@ -28,7 +28,7 @@ abstract class ControllerBaseTest extends WebTestCase
*/
protected function getClientForAuthenticatedUser(string $role = User::ROLE_USER)
{
switch($role) {
switch ($role) {
case User::ROLE_SUPER_ADMIN:
$client = self::createClient([], [
'PHP_AUTH_USER' => AppFixtures::USERNAME_SUPER_ADMIN,
@@ -85,14 +85,17 @@ abstract class ControllerBaseTest extends WebTestCase
{
$client->request($method, '/' . self::DEFAULT_LANGUAGE . $url);
/* @var RedirectResponse $response */
$response = $client->getResponse();
$this->assertTrue(
$client->getResponse()->isRedirect(),
sprintf('The secure URL %s is not protected.', $url . $client->getResponse()->getContent())
$response->isRedirect(),
sprintf('The secure URL %s is not protected.', $url . $response->getContent())
);
$this->assertEquals(
'http://localhost/' . self::DEFAULT_LANGUAGE . '/login',
$client->getResponse()->getTargetUrl(),
$response->getTargetUrl(),
sprintf('The secure URL %s does not redirect to the login form.', $url)
);
}
@@ -150,7 +153,7 @@ abstract class ControllerBaseTest extends WebTestCase
*/
protected function assertMainContentClass(Client $client, $classname)
{
$this->assertContains('<section class="content '.$classname.'">', $client->getResponse()->getContent());
$this->assertContains('<section class="content ' . $classname . '">', $client->getResponse()->getContent());
}
/**