added project start and end date (#1303)

* added sortable js library * activity in invoice is optional * added javascript widget for paginated boxes * fix activity dropdown for globals only * added timesheet service to reduce code duplication * use repository to query for teams in dropdowns * added project validator * validate project start and end against timesheet * include begin and end in dynamic form requests for projects * added timezone and language option to import flag, improve timesheet import speed * deactivate cross-timezone filter * add virtual fields to field order list * composer update * added param to ignore dates * position loader icon fixed - fixes #1330 * permission problem when creating a new project - fixes #1340 * remove dev dependencies webserver and thanks bundle * stop information leak (begin and end date) in duration mode - fixes #1307 * unify timesheet edit dialog for user and admins * fix security issue, own rates exposed to unauthorized users in multi-update dialog
2020-01-05 02:49:01 +01:00
parent 50383673ca
commit d6798eed1e
121 changed files with 2465 additions and 1439 deletions
--- a/src/Timesheet/TimesheetService.php
+++ b/src/Timesheet/TimesheetService.php
@@ -0,0 +1,118 @@
+<?php
+
+/*
+ * This file is part of the Kimai time-tracking app.
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
+namespace App\Timesheet;
+
+use App\Configuration\TimesheetConfiguration;
+use App\Entity\Timesheet;
+use App\Entity\User;
+use App\Event\TimesheetMetaDefinitionEvent;
+use App\Repository\TimesheetRepository;
+use Symfony\Component\EventDispatcher\EventDispatcherInterface;
+use Symfony\Component\HttpFoundation\Request;
+use Symfony\Component\HttpKernel\Exception\AccessDeniedHttpException;
+use Symfony\Component\Security\Core\Authorization\AuthorizationCheckerInterface;
+
+final class TimesheetService
+{
+    /**
+     * @var TimesheetRepository
+     */
+    private $repository;
+    /**
+     * @var TimesheetConfiguration
+     */
+    private $configuration;
+    /**
+     * @var TrackingModeService
+     */
+    private $trackingModeService;
+    /**
+     * @var EventDispatcherInterface
+     */
+    private $dispatcher;
+    /**
+     * @var AuthorizationCheckerInterface
+     */
+    private $auth;
+
+    public function __construct(
+        TimesheetConfiguration $configuration,
+        TimesheetRepository $repository,
+        TrackingModeService $service,
+        EventDispatcherInterface $dispatcher,
+        AuthorizationCheckerInterface $security
+    ) {
+        $this->configuration = $configuration;
+        $this->repository = $repository;
+        $this->trackingModeService = $service;
+        $this->dispatcher = $dispatcher;
+        $this->auth = $security;
+    }
+
+    /**
+     * Calls prepareNewTimesheet() automatically.
+     *
+     * @param User $user
+     * @param Request|null $request
+     * @return Timesheet
+     */
+    public function createNewTimesheet(User $user, ?Request $request = null): Timesheet
+    {
+        $timesheet = new Timesheet();
+        $timesheet->setUser($user);
+
+        if (null !== $request) {
+            $this->prepareNewTimesheet($timesheet, $request);
+        }
+
+        return $timesheet;
+    }
+
+    public function prepareNewTimesheet(Timesheet $timesheet, ?Request $request = null)
+    {
+        if (null !== $timesheet->getId()) {
+            throw new \InvalidArgumentException('Cannot prepare timesheet, already persisted');
+        }
+
+        $event = new TimesheetMetaDefinitionEvent($timesheet);
+        $this->dispatcher->dispatch($event);
+
+        $mode = $this->trackingModeService->getActiveMode();
+        $mode->create($timesheet, $request);
+
+        return $timesheet;
+    }
+
+    public function saveNewTimesheet(Timesheet $timesheet)
+    {
+        if (null !== $timesheet->getId()) {
+            throw new \InvalidArgumentException('Cannot create timesheet, already persisted');
+        }
+
+        if (null === $timesheet->getEnd()) {
+            if (!$this->auth->isGranted('start', $timesheet)) {
+                throw new AccessDeniedHttpException('You are not allowed to start this timesheet record');
+            }
+            $this->repository->stopActiveEntries(
+                $timesheet->getUser(),
+                $this->configuration->getActiveEntriesHardLimit()
+            );
+        }
+
+        $this->repository->save($timesheet);
+
+        return $timesheet;
+    }
+
+    public function stopTimesheet(Timesheet $timesheet)
+    {
+        return $this->repository->stopRecording($timesheet);
+    }
+}