jjsm01/kimai2
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

API begin and end fields for Admins (#5134)

Browse Source
This commit is contained in:
Kevin Papst
2024-10-25 10:47:58 +02:00
committed by GitHub
parent 31bae44f3c
commit dcc52f1a95
12 changed files with 161 additions and 47 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
tests/Timesheet/TrackingMode/DurationFixedBeginModeTest.php
View File

@@ -16,18 +16,22 @@ use App\Tests\Mocks\SystemConfigurationFactory;
use App\Timesheet\TrackingMode\DurationFixedBeginMode;
use PHPUnit\Framework\TestCase;
use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\Security\Core\Authorization\AuthorizationCheckerInterface;
/**
* @covers \App\Timesheet\TrackingMode\DurationFixedBeginMode
*/
class DurationFixedBeginModeTest extends TestCase
{
protected function createSut($default = '13:47')
private function createSut(string $default = '13:47', bool $allowApiTimes = false): DurationFixedBeginMode
{
$loader = new TestConfigLoader([]);
$configuration = SystemConfigurationFactory::create($loader, ['timesheet' => ['default_begin' => $default]]);
return new DurationFixedBeginMode($configuration);
$auth = $this->createMock(AuthorizationCheckerInterface::class);
$auth->method('isGranted')->willReturn($allowApiTimes);
return new DurationFixedBeginMode($configuration, $auth);
}
public function testDefaultValues(): void
@@ -42,6 +46,18 @@ class DurationFixedBeginModeTest extends TestCase
self::assertEquals('duration_fixed_begin', $sut->getId());
}
public function testValuesForAdmin(): void
{
$sut = $this->createSut('now', true);
self::assertFalse($sut->canEditBegin());
self::assertFalse($sut->canEditEnd());
self::assertTrue($sut->canEditDuration());
self::assertTrue($sut->canUpdateTimesWithAPI());
self::assertFalse($sut->canSeeBeginAndEndTimes());
self::assertEquals('duration_fixed_begin', $sut->getId());
}
public function testNow(): void
{
$seconds = (new \DateTime())->getTimestamp();

27
tests/Timesheet/TrackingMode/PunchInOutModeTest.php
View File

@@ -14,15 +14,24 @@ use App\Entity\User;
use App\Timesheet\TrackingMode\PunchInOutMode;
use PHPUnit\Framework\TestCase;
use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\Security\Core\Authorization\AuthorizationCheckerInterface;
/**
* @covers \App\Timesheet\TrackingMode\PunchInOutMode
*/
class PunchInOutModeTest extends TestCase
{
private function createSut(bool $allowApiTimes = false): PunchInOutMode
{
$auth = $this->createMock(AuthorizationCheckerInterface::class);
$auth->method('isGranted')->willReturn($allowApiTimes);
return new PunchInOutMode($auth);
}
public function testDefaultValues(): void
{
$sut = new PunchInOutMode();
$sut = $this->createSut();
self::assertFalse($sut->canEditBegin());
self::assertFalse($sut->canEditEnd());
@@ -32,6 +41,18 @@ class PunchInOutModeTest extends TestCase
self::assertEquals('punch', $sut->getId());
}
public function testValuesForAdmin(): void
{
$sut = $this->createSut(true);
self::assertFalse($sut->canEditBegin());
self::assertFalse($sut->canEditEnd());
self::assertFalse($sut->canEditDuration());
self::assertTrue($sut->canUpdateTimesWithAPI());
self::assertTrue($sut->canSeeBeginAndEndTimes());
self::assertEquals('punch', $sut->getId());
}
public function testCreate(): void
{
$startingTime = new \DateTime('22:54');
@@ -39,7 +60,7 @@ class PunchInOutModeTest extends TestCase
$timesheet->setBegin($startingTime);
$request = new Request();
$sut = new PunchInOutMode();
$sut = $this->createSut();
$sut->create($timesheet, $request);
self::assertEquals($timesheet->getBegin(), $startingTime);
}
@@ -49,7 +70,7 @@ class PunchInOutModeTest extends TestCase
$timesheet = (new Timesheet())->setUser(new User());
$request = new Request();
$sut = new PunchInOutMode();
$sut = $this->createSut();
$sut->create($timesheet, $request);
self::assertInstanceOf(\DateTime::class, $timesheet->getBegin());
}