Release 2.13 (#4659)

src/Saml/SamlAuthFactory.php

@@ -20,8 +20,8 @@ use Symfony\Component\HttpFoundation\RequestStack;
 class SamlAuthFactory
 {
     public function __construct(
-        private RequestStack $request,
-        private SamlConfigurationInterface $configuration
+        private readonly RequestStack $request,
+        private readonly SamlConfigurationInterface $configuration
     ) {
     }
 

src/Saml/SamlAuthenticator.php

@@ -35,12 +35,12 @@ class SamlAuthenticator extends AbstractAuthenticator
     ];
 
     public function __construct(
-        private HttpUtils $httpUtils,
-        private SamlAuthenticationSuccessHandler $successHandler,
-        private SamlAuthenticationFailureHandler $failureHandler,
-        private SamlAuthFactory $samlAuthFactory,
-        private SamlProvider $samlProvider,
-        private SamlConfigurationInterface $configuration
+        private readonly HttpUtils $httpUtils,
+        private readonly SamlAuthenticationSuccessHandler $successHandler,
+        private readonly SamlAuthenticationFailureHandler $failureHandler,
+        private readonly SamlAuthFactory $samlAuthFactory,
+        private readonly SamlProvider $samlProvider,
+        private readonly SamlConfigurationInterface $configuration
     ) {
     }
 

src/Saml/SamlBadge.php

@@ -13,7 +13,7 @@ use Symfony\Component\Security\Http\Authenticator\Passport\Badge\BadgeInterface;
 
 final class SamlBadge implements BadgeInterface
 {
-    public function __construct(private SamlLoginAttributes $samlToken)
+    public function __construct(private readonly SamlLoginAttributes $samlToken)
     {
     }
 

src/Saml/SamlLogoutSubscriber.php

@@ -15,7 +15,7 @@ use Symfony\Component\Security\Http\Event\LogoutEvent;
 
 final class SamlLogoutSubscriber implements EventSubscriberInterface
 {
-    public function __construct(private SamlAuthFactory $samlAuth)
+    public function __construct(private readonly SamlAuthFactory $samlAuth)
     {
     }
 
@@ -26,7 +26,7 @@ final class SamlLogoutSubscriber implements EventSubscriberInterface
         ];
     }
 
-    public function logout(LogoutEvent $event)
+    public function logout(LogoutEvent $event): void
     {
         $token = $event->getToken();
 

src/Saml/SamlProvider.php

@@ -22,9 +22,9 @@ final class SamlProvider
      * @param UserProviderInterface<User> $userProvider
      */
     public function __construct(
-        private UserRepository $repository,
-        private UserProviderInterface $userProvider,
-        private SamlConfigurationInterface $configuration
+        private readonly UserRepository $repository,
+        private readonly UserProviderInterface $userProvider,
+        private readonly SamlConfigurationInterface $configuration
     ) {
     }
 
@@ -123,7 +123,7 @@ final class SamlProvider
         $user->setAuth(User::AUTH_SAML);
     }
 
-    private function getPropertyValue(SamlLoginAttributes $token, $attribute)
+    private function getPropertyValue(SamlLoginAttributes $token, $attribute): string
     {
         $results = [];
         $attributes = $token->getAttributes();