split timesheet validator to simplify imports (#3974)

2023-04-27 13:56:07 +02:00
parent 046ed313c9
commit f60065d089
11 changed files with 213 additions and 77 deletions
--- a/tests/Validator/Constraints/TimesheetDeactivatedValidatorTest.php
+++ b/tests/Validator/Constraints/TimesheetDeactivatedValidatorTest.php
@@ -0,0 +1,86 @@
+<?php
+
+/*
+ * This file is part of the Kimai time-tracking app.
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
+namespace App\Tests\Validator\Constraints;
+
+use App\Entity\Activity;
+use App\Entity\Customer;
+use App\Entity\Project;
+use App\Entity\Timesheet;
+use App\Validator\Constraints\TimesheetDeactivated;
+use App\Validator\Constraints\TimesheetDeactivatedValidator;
+use Symfony\Component\Validator\Constraints\NotBlank;
+use Symfony\Component\Validator\Exception\UnexpectedTypeException;
+use Symfony\Component\Validator\Test\ConstraintValidatorTestCase;
+
+/**
+ * @covers \App\Validator\Constraints\TimesheetDeactivated
+ * @covers \App\Validator\Constraints\TimesheetDeactivatedValidator
+ * @extends ConstraintValidatorTestCase<TimesheetDeactivatedValidator>
+ */
+class TimesheetDeactivatedValidatorTest extends ConstraintValidatorTestCase
+{
+    protected function createValidator(): TimesheetDeactivatedValidator
+    {
+        return new TimesheetDeactivatedValidator();
+    }
+
+    public function testConstraintIsInvalid(): void
+    {
+        $this->expectException(UnexpectedTypeException::class);
+
+        $this->validator->validate(new Timesheet(), new NotBlank());
+    }
+
+    public function testInvalidValueThrowsException(): void
+    {
+        $this->expectException(UnexpectedTypeException::class);
+
+        $this->validator->validate(new NotBlank(), new TimesheetDeactivated(['message' => 'myMessage']));
+    }
+
+    public function testDisabledValuesDuringStart(): void
+    {
+        $begin = new \DateTime('-10 hour');
+        $customer = new Customer('foo');
+        $customer->setVisible(false);
+        $activity = new Activity();
+        $activity->setVisible(false);
+        $project = new Project();
+        $project->setVisible(false);
+        $project->setCustomer($customer);
+        $activity->setProject($project);
+
+        $timesheet = new Timesheet();
+        $timesheet
+            ->setBegin($begin)
+            ->setActivity($activity)
+            ->setProject($project)
+        ;
+
+        $this->validator->validate($timesheet, new TimesheetDeactivated(['message' => 'myMessage']));
+
+        $this->buildViolation(TimesheetDeactivated::getErrorName(TimesheetDeactivated::DISABLED_ACTIVITY_ERROR))
+            ->atPath('property.path.activity')
+            ->setCode(TimesheetDeactivated::DISABLED_ACTIVITY_ERROR)
+            ->buildNextViolation(TimesheetDeactivated::getErrorName(TimesheetDeactivated::DISABLED_PROJECT_ERROR))
+            ->atPath('property.path.project')
+            ->setCode(TimesheetDeactivated::DISABLED_PROJECT_ERROR)
+            ->buildNextViolation(TimesheetDeactivated::getErrorName(TimesheetDeactivated::DISABLED_CUSTOMER_ERROR))
+            ->atPath('property.path.customer')
+            ->setCode(TimesheetDeactivated::DISABLED_CUSTOMER_ERROR)
+            ->assertRaised();
+    }
+
+    public function testGetTargets(): void
+    {
+        $constraint = new TimesheetDeactivated();
+        self::assertEquals('class', $constraint->getTargets());
+    }
+}