Release 2.23.0 (#5075)

This commit is contained in:
Kevin Papst
2024-10-03 10:34:20 +02:00
committed by GitHub
parent 40154be8f9
commit fb9a0dc499
142 changed files with 855 additions and 910 deletions

View File

@@ -285,7 +285,7 @@ class BaseQuery
return $this;
}
public function setBookmark(Bookmark $bookmark): void
public function setBookmark(?Bookmark $bookmark): void
{
$this->bookmark = $bookmark;
}

View File

@@ -128,18 +128,6 @@ class TimesheetQuery extends ActivityQuery implements BillableInterface, DateRan
$this->timesheetUser = $user;
}
/**
* @return array<int>
*/
public function getActivityIds(): array
{
return array_values(array_filter(array_unique(array_map(function (Activity $activity) {
return $activity->getId();
}, $this->activities)), function ($id) {
return $id !== null;
}));
}
/**
* @return array<Activity>
*/

View File

@@ -620,7 +620,7 @@ class TimesheetRepository extends EntityRepository
if ($query->hasActivities()) {
$qb->andWhere($qb->expr()->in('t.activity', ':activity'))
->setParameter('activity', $query->getActivityIds());
->setParameter('activity', $query->getActivities());
}
if ($query->hasProjects()) {