jjsm01/kimai2
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

fix hydration issues in favorites (#5068)

Browse Source
This commit is contained in:
Kevin Papst
2024-09-20 22:43:16 +02:00
committed by GitHub
parent 537c120ad9
commit 036b297a76
2 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/Controller/FavoriteController.php
View File

@@ -32,7 +32,7 @@ final class FavoriteController extends AbstractController
{ {
$favoriteRecordService->addFavorite($timesheet); $favoriteRecordService->addFavorite($timesheet);
return $this->render('favorite/index.html.twig'); return $this->redirectToRoute('favorites_timesheets');
} }
#[Route(path: '/timesheet/remove/{id}', name: 'favorites_timesheets_remove', methods: ['GET'])] #[Route(path: '/timesheet/remove/{id}', name: 'favorites_timesheets_remove', methods: ['GET'])]
@@ -41,6 +41,6 @@ final class FavoriteController extends AbstractController
{ {
$favoriteRecordService->removeFavorite($timesheet); $favoriteRecordService->removeFavorite($timesheet);
return $this->render('favorite/index.html.twig'); return $this->redirectToRoute('favorites_timesheets');
} }
} }

4
src/Timesheet/FavoriteRecordService.php
View File

@@ -112,11 +112,11 @@ final class FavoriteRecordService
public function removeFavorite(Timesheet $timesheet): void public function removeFavorite(Timesheet $timesheet): void
{ {
if ($timesheet->getUser() === null) { if ($timesheet->getUser() === null) {
throw new \InvalidArgumentException('Cannot favorite timesheet without user'); throw new \InvalidArgumentException('Cannot remove favorite without user');
} }
if ($timesheet->getId() === null) { if ($timesheet->getId() === null) {
throw new \InvalidArgumentException('Cannot favorite unsaved timesheet'); throw new \InvalidArgumentException('Cannot remove unsaved favorite');
} }
$this->removeFavoriteById($timesheet->getUser(), $timesheet->getId()); $this->removeFavoriteById($timesheet->getUser(), $timesheet->getId());