LDAP authentication support (#815)

tests/Entity/AbstractEntityTest.php

@@ -18,10 +18,10 @@ use Symfony\Component\Validator\ConstraintViolationInterface;
 abstract class AbstractEntityTest extends KernelTestCase
 {
     /**
-     * @param $entity
+     * @param object $entity
      * @param array|string $fieldNames
      */
-    protected function assertHasViolationForField($entity, $fieldNames)
+    protected function assertHasViolationForField(object $entity, $fieldNames)
     {
         self::bootKernel();
         $validator = static::$kernel->getContainer()->get('validator');

tests/Entity/ActivityTest.php

@@ -24,7 +24,7 @@ class ActivityTest extends AbstractEntityTest
         $this->assertNull($sut->getName());
         $this->assertNull($sut->getComment());
         $this->assertTrue($sut->getVisible());
-        // timesheets
+        self::assertIsIterable($sut->getTimesheets());
         $this->assertNull($sut->getFixedRate());
         $this->assertNull($sut->getHourlyRate());
         $this->assertNull($sut->getColor());

tests/Entity/CustomerTest.php

@@ -10,7 +10,6 @@
 namespace App\Tests\Entity;
 
 use App\Entity\Customer;
-use App\Entity\Project;
 
 /**
  * @covers \App\Entity\Customer
@@ -24,7 +23,8 @@ class CustomerTest extends AbstractEntityTest
         $this->assertNull($sut->getName());
         $this->assertNull($sut->getNumber());
         $this->assertNull($sut->getComment());
-        // projects
+        self::assertIsIterable($sut->getProjects());
+        self::assertEmpty($sut->getProjects());
         $this->assertTrue($sut->getVisible());
 
         $this->assertNull($sut->getCompany());
@@ -61,10 +61,6 @@ class CustomerTest extends AbstractEntityTest
         $this->assertInstanceOf(Customer::class, $sut->setColor('#fffccc'));
         $this->assertEquals('#fffccc', $sut->getColor());
 
-        $projects = [(new Project())->setName('Test')];
-        $this->assertInstanceOf(Customer::class, $sut->setProjects($projects));
-        $this->assertSame($projects, $sut->getProjects());
-
         $this->assertInstanceOf(Customer::class, $sut->setCompany('test company'));
         $this->assertEquals('test company', $sut->getCompany());
 

tests/Entity/ProjectTest.php

@@ -9,10 +9,8 @@
 
 namespace App\Tests\Entity;
 
-use App\Entity\Activity;
 use App\Entity\Customer;
 use App\Entity\Project;
-use App\Entity\Timesheet;
 
 /**
  * @covers \App\Entity\Project
@@ -29,10 +27,12 @@ class ProjectTest extends AbstractEntityTest
         $this->assertNull($sut->getComment());
         $this->assertTrue($sut->getVisible());
         $this->assertEquals(0.0, $sut->getBudget());
-        // activities
         $this->assertNull($sut->getFixedRate());
         $this->assertNull($sut->getHourlyRate());
-        $this->assertNull($sut->getTimesheets());
+        self::assertIsIterable($sut->getTimesheets());
+        self::assertEmpty($sut->getTimesheets());
+        self::assertIsIterable($sut->getActivities());
+        self::assertEmpty($sut->getActivities());
         $this->assertNull($sut->getColor());
     }
 
@@ -62,17 +62,9 @@ class ProjectTest extends AbstractEntityTest
         $this->assertInstanceOf(Project::class, $sut->setBudget(12345.67));
         $this->assertEquals(12345.67, $sut->getBudget());
 
-        $activities = [(new Activity())->setName('foo')];
-        $this->assertInstanceOf(Project::class, $sut->setActivities($activities));
-        $this->assertSame($activities, $sut->getActivities());
-
         $this->assertInstanceOf(Project::class, $sut->setFixedRate(13.47));
         $this->assertEquals(13.47, $sut->getFixedRate());
         $this->assertInstanceOf(Project::class, $sut->setHourlyRate(99));
         $this->assertEquals(99, $sut->getHourlyRate());
-
-        $timesheets = [(new Timesheet())->setDescription('foo'), (new Timesheet())->setDescription('bar')];
-        $this->assertInstanceOf(Project::class, $sut->setTimesheets($timesheets));
-        $this->assertSame($timesheets, $sut->getTimesheets());
     }
 }

tests/Entity/UserTest.php

@@ -116,6 +116,13 @@ class UserTest extends AbstractEntityTest
         $user->addPreference($preference);
         $this->assertEquals('foobar', $user->getPreferenceValue('test', 'foo'));
         $this->assertEquals($preference, $user->getPreference('test'));
+
+        $user->setPreferenceValue('test', 'Hello World');
+        $this->assertEquals('Hello World', $user->getPreferenceValue('test', 'foo'));
+
+        $this->assertNull($user->getPreferenceValue('test2'));
+        $user->setPreferenceValue('test2', 'I like rain');
+        $this->assertEquals('I like rain', $user->getPreferenceValue('test2'));
     }
 
     public function testToString()