activate bleeding edge phpstan rules (#2898)

This commit is contained in:
Kevin Papst
2021-11-02 13:33:21 +01:00
committed by GitHub
parent 36c08b0dea
commit 1b35356f81
32 changed files with 73 additions and 142 deletions

View File

@@ -76,11 +76,7 @@ class SelectWithApiDataExtension extends AbstractTypeExtension
$formPrefix = implode('_', array_reverse($formPrefixes));
$formField = $formPrefix;
if (!empty($formField)) {
$formField .= '_';
}
$formField .= $apiData['select'];
$formField = $formPrefix . '_' . $apiData['select'];
$view->vars['attr'] = array_merge($view->vars['attr'], [
'data-form-prefix' => $formPrefix,

View File

@@ -50,6 +50,9 @@ class QuickEntryForm extends AbstractType
foreach ($value->getRows() as $row) {
$project = $row->getProject();
$activity = $row->getActivity();
if ($project === null || $activity === null) {
continue;
}
foreach ($row->getTimesheets() as $timesheet) {
$timesheet->setProject($project);
$timesheet->setActivity($activity);

View File

@@ -21,7 +21,6 @@ use App\Form\Type\TagsType;
use App\Form\Type\UserType;
use App\Form\Type\YesNoType;
use App\Repository\CustomerRepository;
use App\Repository\ProjectRepository;
use Symfony\Component\Form\AbstractType;
use Symfony\Component\Form\FormBuilderInterface;
use Symfony\Component\Form\FormEvent;
@@ -39,15 +38,10 @@ class TimesheetEditForm extends AbstractType
* @var CustomerRepository
*/
private $customers;
/**
* @var ProjectRepository
*/
private $projects;
public function __construct(CustomerRepository $customer, ProjectRepository $project)
public function __construct(CustomerRepository $customer)
{
$this->customers = $customer;
$this->projects = $project;
}
/**